Commit graph

7896 commits

Author SHA1 Message Date
Sam Doran
6e7fcf38a8 [stable-2.8] Get minor version number for CentOS and Debian (#57814) (#58538)
* [stable-2.8] Get minor version number for CentOS and Debian (#57814)

* Get the most detailed version number from distro.version() for CentOS and Debian
* Update tests and fixtures
* Update fixture generation script to gather distro info and work with Python 3
* Update LinuxMint fixtures
* Cleanup fixture formatting
* Improvements based on feedback from abadger:
    - use unicode since that is what distro returns
    - use frozenset with a tuple
    - include link Debian to bug
(cherry picked from commit ab6a9ef130)

Co-authored-by: Sam Doran <sdoran@redhat.com>

* Add a changelog for the version number in facts change
2019-06-30 16:59:38 -07:00
Toshio Kuratomi
83c04bdec5 [stable-2.8] Skip tests with unsatisfied deps (#55853)
* Skip gitlab tests if dependencies aren't met

* Skip certain unittests if passlib is not installed

* Fix tests with deps on paramiko to skip if paramiko is not installed

* Use pytest to skip for cloudstack

If either on Python-2.6 or the cs library is not installed we cannot run
this test so skip it
(cherry picked from commit 8acf71f)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2019-06-29 11:31:58 -07:00
Sloane Hertel
c67980e07b Handle vaulted non-ascii characters for Python2 (#58503)
* Handle vaulted non-ascii characters for Python2

* Add a test to ensure str() no longer raises UnicodeEncodeError

(cherry picked from commit 826f224f02)
2019-06-29 11:13:55 -07:00
Sam Doran
7700c5086d [stable-2.8] Use atexit to cleanup tmp dirs (#56532)
* Wrap everything in try/except to avoid leaving files behind
* Add unit tests, integration tests, and changelog
* Do text the correct way.
(cherry picked from commit 6cf6f5a34b)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-29 11:13:28 -07:00
Sloane Hertel
cb70656c99 Fix notifying handlers by using an exact match (#55624)
* Fix notifying handlers by using an exact match rather than a string subset if listen is text rather than a list

* Enforce better type checking for listeners

* Share code for validating handler listeners

* Add test for handlers without names

* Add test for templating in handlers

* Add test for include_role

* Add a couple notes about 'listen' for handlers

* changelog

(cherry picked from commit ec1287ca7e)
2019-06-28 09:22:39 -07:00
Sam Doran
8cc128b8f5 [stable-2.8] podman_image_info - Do not fail when nonexistant image name is provided (#57962)
* Account for older versions of Podman lacking 'exists'
(cherry picked from commit 9ba7015458)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-28 09:16:24 -07:00
Sam Doran
bbbacebf01 [stable-2.8] Make nuage_vspk test more reliable
- don't background the nuage-vsd-sim
- increase the asncy timeout
- use uri to actually query the simulator API to make sure it is ready for connections
(cherry picked from commit 911a2ec6d3)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-26 14:47:11 -07:00
Alicia Cozine
af1ca7bfcb
Datadog_monitor: Fix docs with datatypes of params (#58371) (#58404)
Fixes: #58342

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

(cherry picked from commit bc3c90f2f1)
2019-06-26 11:56:53 -05:00
Andrey Klychkov
a6ecc6c243 Backport 57507 postgresql_pg_hba bugfix (#58384)
* Merge authentication options back into a single field to prevent losing options beyond the first (#57507)

* Merge authentication options back into a single field to prevent losing options beyond the first

* Add integration test and changelog

* Fix multiple options for local type connections. Also fix sorting errors between local type connections that lack a src

* Build again because of github problems?

* Add spaces before comments

(cherry picked from commit 5cc6486a2b)
2019-06-26 08:32:46 -07:00
Tobias
95c2763f40 [2.8] ipaddr: Handle ipaddress index in network correctly
* This commit prevents integer indices from being parsed as ip nets
* ipaddr: unit tests for empty string

Fixes #57895

Signed-off-by: Tobias Schramm <tobleminer@gmail.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit e7c39460ed)
2019-06-24 19:35:27 -07:00
Felix Fontein
b75ff85e9c Use newer test container.
(cherry picked from commit b78d23d4ad)
2019-06-24 15:44:17 -07:00
Andrey Klychkov
8f97d6da8b Backport PR of 57391 postgresql_table - fix conflicts 2019-06-24 15:18:25 -07:00
Andrey Klychkov
5ebc83bce6 Backport PR of 57391 postgresql_table - bugfix of schema handling 2019-06-24 15:18:25 -07:00
Felix Fontein
5e177d73a9 openssl_certificate: fix failing SAN comparisons (#58256)
* Fix failing SAN comparison for older cryptography versions due to not implemented __hashh__ functions.

* Fix SAN comparison: IPv6 addresses need to be normalized before comparing strings.

* Add changelog.

* Fix comment.

(cherry picked from commit 75ca8eb42f)
2019-06-24 15:17:41 -07:00
lolcube
5d3eebb610 openssh_keypair: bugfix make regenerating keypairs via force possible… (#57801)
* openssh_keypair: bugfix make regenerating keypairs via force possible / add invalid file handling

* openssh_keypair: change permissions of read-only file instead of deleting it for regeneration; add changelog fragment

* address review feedbak, refactor

* add integration tests for bigfixes

* linter: fix indent

* fixup integration tests: use force when regenerating an invalid file

* linter: fix indent

* openssh_keypair: address review feedback

* openssh_keypair: fixup, remove backtick

* openssh_keypair: address review feedback

* Only pass 'y' into stdin of ssh-keygen when file exists.

(cherry picked from commit 547a29805e)
2019-06-24 15:17:08 -07:00
Andrey Klychkov
7a9fe9ea7b postgresql_privs: bugfix of 27327 - incorrect views handling (#58272)
(cherry picked from commit 278c59b17e)
2019-06-24 15:16:07 -07:00
Felix Fontein
7c22c81c5c Adjust tests to new error messages for older docker-py versions. (#58253)
(cherry picked from commit 66a4000058)
2019-06-24 15:13:30 -07:00
Felix Fontein
b7cc98e86e docker_* modules: improve error message when docker-py is missing (#57914)
* Improve error for docker modules when docker-py can't be imported.

* Add changelog.

* Mention platform and Python interpreter in more cases.

* Clarify wording.

* Adjust tests.

(cherry picked from commit 4a12be31fb)
2019-06-24 15:13:30 -07:00
Mariusz Mazur
d9155944cf Backport/2.8/57685 (#57794)
* kubevirt: enable/update tests + fix merge_dicts() (#57685)

* Actually run the unit tests and separate them into two files

* Re-add recursion to merge_dicts()

* Update tests to work with current code

(cherry picked from commit 51add5aa79)

* Changelog fragment

* Replace nested function with dict_transformations.dict_merge
2019-06-24 09:26:42 -07:00
Sam Doran
6bd8e3d002 [stable-2.8] Add Fedora 30 to test matrix (#57713)
Remove Fedora 28 from test matrix
(cherry picked from commit 7b9d991f78)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-21 15:39:18 -07:00
Sumit Jaiswal
062074e68e Backport PR to fix ios_facts ansible_net_model (#58174)
* PR to fix where ansible_net_model was not being populated (#58159)

* fix bug 57285

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* minor fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* adding TC fix related

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable error

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 58d446e61a)

* fix ansible_net_model

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* Fix ios test for python2 non-ascii paths

(cherry picked from commit eb7e4591ae)
2019-06-21 15:35:33 -07:00
Sam Doran
9d82c470ca [stable-2.8] Check that provider['options'] is a dictionary in validate-modules (#58078)
(cherry picked from commit dc8f7b38e6)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-21 12:13:21 -07:00
Brian Coca
04e94274fb safe_eval fix (#57188)
* just dont pass locals

 - also fix globals
 - added tests

* fixed tests

(cherry picked from commit b9b0b23015)
2019-06-20 18:22:29 -07:00
Sam Doran
169dfc807e [stable-2.8] passwordstore lookup - replace expired GPG key (#58141)
- Replace private key that expired an 2019-06-20 with a key that does not expire
- Document how to generate a new GPG key using an input file
(cherry picked from commit b9d77b997e)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-20 15:33:00 -07:00
Dmitriy Yakovlev
cd00cb1e8c docker_swarm_service: Added default value for mounts.source (#58039)
* Added default value for mounts.source

* Added the changelog fragment

* Added tests

* Fixed separators

* Moved the teardown section at the end

(cherry picked from commit 122d4164c5)
2019-06-20 13:58:45 -07:00
Paul Belanger
546cc087aa Use wait_for in prepare_junos_tests.yaml (#57073)
This should reduce the amount of time we are waiting for netconf to come
online.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit 7f536630eb)
2019-06-20 13:58:08 -07:00
Felix Fontein
ad00823266 docsite: remove lexers which have been fixed in Pygments 2.4.0 (#57508)
* Remove lexers which have been fixed in Pygments 2.4.0.
* Add Pygments >= 2.4.0 to test runner.
* Fix pages that triggered lexer errors.

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
(cherry picked from commit 505c99265c)
2019-06-20 11:12:16 -07:00
Sumit Jaiswal
4cb505a310 PR to fix ios bgp TC failure (#58010)
* fix ios bgp tc failure

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* skip test with 15.6(T)2 ios

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* skip test with 15.6(T)2 ios

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 77b6255305)
2019-06-20 11:01:35 -07:00
Sam Doran
32503a55c4 [stable-2.8] Change integration tests in order to pass on Fedora 30 (#58081)
* Use different package for DNF tests
    Ninja caused errors in Fedora 30. This works in both Fedora 29 and 30.

* Fix git integration tests
    Git >= 2.21.0 has either a bug or change in behavior where it errors when fetching a
    repository containing submodules that are behind the upstream submodule commits.
    It's weird and I don't fully understand it.

    Get around this my checking out specific commits from a repository rather than
    switch the origin URL.

* Fix PostgreSQL tests
    The error message is slightly different
(cherry picked from commit 18feeb51a8)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-19 10:55:13 -07:00
Paul Belanger
7bd503c52a Remove pause logic form junos_netconf tests (#57966)
We can switch to wait_for / meta, as using pause can lead to race
conditions on slower / faster hardware.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit 8dc51dfe1c)
2019-06-19 10:54:46 -07:00
Nilashish Chakraborty
05c7f7a230 Remove backup from iosxr replace_config test (#57830)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
(cherry picked from commit af25274d6a)
2019-06-19 10:53:41 -07:00
Daniel Mellado Area
20fa1156b7 Add support for vlan update on ovs bridges (#57168)
This commit adds support for vlan update on openvswitch_bridge module.

(cherry picked from commit 091bebcbf7)
2019-06-19 06:18:30 -07:00
Ganesh Nalawade
bafc95eb0f More iosxr integration zuul CI test fixes (#57909)
* Ignore `<rpc-reply>` node from candidate and
  running configuration in xml diff

* Add route-policy as prerequisite to BGP coonfiguration
  in integration test

(cherry picked from commit 4a3e14f90b)
2019-06-19 06:16:08 -07:00
Ganesh B Nalawade
ae995a19e2 Fix junos integration zuul CI failures
(cherry picked from commit 0957835a4814bfc0c7649675963de5e88df5060e)
2019-06-18 11:20:39 -07:00
Guillaume Martinez
36df5d22a4 gitlab_runner: Fix idempotency when creating runner (#57833)
(cherry picked from commit ec7b18952b)
2019-06-18 10:51:51 -07:00
Chris Archibald
fa6e39ddf2 Backport/2.8/57320 (#58009)
* new feature

(cherry picked from commit dbeaf30f975190cc20fbece88b12d8dd062aad07)

* add fragment
2019-06-18 10:47:47 -07:00
Paul Belanger
ee02a98d19 ansible-test: ios_command cli test should only be network_cli (#56955)
We do not support testing under ansible_connection=local

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 21:57:07 -07:00
Kevin Breit
81dc2ac233 [stable-2.8] - Restructure meraki_network execution (#57663)
* Resolve conflicts

* Fixes for the merge since 2.8 and devel are quite different

* Add changelog
2019-06-17 21:56:40 -07:00
ShachafGoldstein
ee48ceaf10 win_get_url - Fix handling of restricted headers (#57892)
* fix 57880

* ADded test

* Remove host header from test

* TEst error

* Fix tests

* fix user agent test

(cherry picked from commit 66728cb93f)
2019-06-17 21:47:14 -07:00
Jordan Borean
c1391fd636 win_shell - fix space escaping for custom executable (#57455)
(cherry picked from commit d0c4914469)
2019-06-17 21:38:16 -07:00
Sam Doran
0cc78fa3af [stable-2.8] Change RHEL8 image name to match changes in ansible-test (#57807)
* Change RHEL8 image name to match changes in ansible-test

Continue to use the beta version of RHEL 8 until we fix tests that are breaking with the GA version.

* Skip ufw integration test on RHEL 8 Beta
(cherry picked from commit 84075fe351)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-06-17 20:07:05 -07:00
YuandongXu
bb6955c5eb Backport/2.8/57257 option is marked as required but specifies a default (#57750)
* option is marked as required but specifies a default (#57257)

* required and default are conflicting

(cherry picked from commit 05e6339c49)

* add a changelog fragment for PR 57750.
2019-06-17 18:29:35 -07:00
Felix Fontein
fd04094bde acme_*: new test container, tests for IP certificates (#57530)
* Bump container version.

* Use new URLs.

* Add IP certificate tests.

* Disable IPv6 IP from IP certificate.

Background: in CI, the ACME test container apparently has no IPv6 support.
Without IPv6 support, Pebble can't connect to validate, and thus validation
fails.

(cherry picked from commit c50a75a41e)
2019-06-17 18:27:47 -07:00
Martin Krizek
0690aab25d Actually run valid_include_keywords test (#57687)
(cherry picked from commit e8948f7655)
2019-06-17 18:27:02 -07:00
Anton Nikulin
afb718f001 [stable-2.8] ftd_configuration: fix a bug with response parsing (#57480) (#57676)
* FTD configuration module: fix a bug with response parsing (#57480)

* Update dependence's name to firepower-kickstart

* Check response type before getting attributes

* Add unit test for construct_ansible_facts method

* Update error message

(cherry picked from commit 4fa93d5b9b)

* Add backlog entry
2019-06-17 16:27:42 -07:00
ShachafGoldstein
dfc47bd6d6 win_pagefile: not using testPath (#57093)
* win_pagefile: not using testPath

* Added changelog

(cherry picked from commit a87495d07c)
2019-06-17 15:48:47 -07:00
Paul Belanger
07806f36b6 Remove hardcoded ansible user for junos_user integration tests (#56452)
It is possible we are using a different username then 'ansible' for
testing junos. By using ansible_user_id, this should be a more dynamic
check.

Depends-On: https://github.com/ansible/ansible/pull/57639
Depends-On: https://github.com/ansible/ansible/pull/57638
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 15:46:33 -07:00
Sloane Hertel
4b0c8f1a12 [FactCache] define first_order_merge method (#55781)
* Add first_order_merge method

Add test for updating a key that already exists

* changelog

(cherry picked from commit 598a058afe)
2019-06-17 15:45:58 -07:00
Sebastiaan Mannem
7b73604058 Issue 56430 (#57147)
* Adding integration test for 127.0.0.1/32 and ::1/128.

* Making sure file is not corrupted when render fails

* Fixes #56430

* Adding changelog for MR 57147/Issue 56430
2019-06-17 13:01:08 -07:00
Paul Belanger
57e323dd8f Fix ios_smoke failure
Set ansible_buffer_read_timeout to be larger then
ansible_command_timeout, as both appliance / controller are on the same
physical network and we are not triggering ansible_command_timeout.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-06-17 12:55:30 -07:00