Commit graph

39626 commits

Author SHA1 Message Date
Michael Price
ad91793428 Resolve issues in NetApp E-Series Host module (#39748)
* Resolve issues in NetApp E-Series Host module

The E-Series host module had some bugs relating to the update/creation
of host definitions when iSCSI initiators when included in the
configuration. This patch resolves this and other minor issues with
correctly detecting updates.

There were also several minor issues found that were causing issues with
truly idepotent updates/changes to the host definition.

This patch also provides some unit tests and integration tests to help
catch future issues in these areas.

fixes #28272

* Improve NetApp E-Series Host module testing

The NetApp E-Series Host module integration test lacked feature test
verification to verify the changes made to the storage array.

The NetApp E-Series rest api was used to verify host create, update, and
remove changes made to the NetApp E-Series storage arrays.
2018-08-24 15:44:59 +01:00
Pierre Gaxatte
3122860f22 Update os_server docs when removing an instance (#41963)
When removing an instance via its ID, it is not clearly explained that one should use the `name` parameter.

Also a simple example is provided.

+label: docsite_pr
2018-08-24 10:42:25 -04:00
njferrant
507d6e241e NetApp: return lun info for na_ontap_lun_map module (#42961)
* return lun details for na_ontap_lun_map

return lun details for na_ontap_lun_map.py and added return value documentation
2018-08-24 15:37:28 +01:00
Victor da Costa
53405f673c friendly message when requirement is not installed (#42321)
* friendly message when requirement is not installed
2018-08-24 15:08:24 +01:00
Dag Wieers
86147d598f Various improvements to script module docs (#44637)
This PR includes:
- Use uppercase in descriptions
- Add trailing dot to descriptions
- Grammar/spelling fixes
- Adding names to examples as a best practice
- Simplify structure
2018-08-24 09:56:44 -04:00
Chris Coley
ce5530e08d Fix incorrect default value for shutdown_command (#44607) 2018-08-24 09:51:14 -04:00
Ihor Dvoretskyi
5d5782ce9d Fixed links to the CLI clients (#35792)
CLI clients link is incorrect, fixed.
2018-08-24 08:40:53 -05:00
Yanis Guenane
9869f378fd inventory/vultr: Few minor improvements (#44622) 2018-08-24 15:35:29 +02:00
Yuma Inaura (稲浦悠馬)
34c582287a Fix script module document (#42778)
script module seems does not create / remove files
it seems only checks file existence or not existence


+label: docsite_pr
2018-08-24 14:59:04 +02:00
linnil1
1651483e44 [Junos] Add l3-interface option for vlan (#43863)
* [Junos] Add l3-interface option for vlan

* Add version_added for new option
2018-08-24 18:06:27 +05:30
Ganesh Nalawade
b454fbe684
Update netconf_config module doc and return diff (#44634)
* Update netconf_config module doc
* Return santizied before and after config
  in diff key
2018-08-24 17:57:12 +05:30
Ganesh Nalawade
d20b4ee56a
Fix netconf_config source option issue (#44630) 2018-08-24 17:01:48 +05:30
Yanis Guenane
957c90934a BOTMEA: Add for lib/ansible/plugins/inventory/vultr.py (#44623) 2018-08-24 10:55:33 +02:00
Alex Mayer
e4e45a419a Firewalld: Switch "true" To "yes" In Examples (#44588)
Matches documentation section values
Make module examples more consistent with core modules
2018-08-24 10:17:56 +02:00
Abhijeet Kasurde
f59d189d02 Minor typo fix in package module documentation (#44617)
Added missing round bracket

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-24 10:14:58 +02:00
Samer Deeb
a07af2a1f7 issue:43021 add support for onyx version 3.6.6000 and above (#44527)
* issue:43021 add support for onyx version 3.6.6000

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* issue:43021 add support for onyx version 3.6.6000

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-08-24 07:59:10 +01:00
Ondra Machacek
56b9823bb8 ovirt_vm: Fix undefined variable (#44618)
Fix unassigned variable while suspending vm.
2018-08-24 02:29:02 -04:00
Trishna Guha
8b175d99c6
ignore file_pull (#44614)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-24 10:51:57 +05:30
Abhijeet Kasurde
33f5b1aa0f
VMware: new module: vmware_local_role_facts (#44553)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-24 10:00:40 +05:30
Matt Clay
c2d16b754d Move azure_rm_appgateway certs into files.
This avoids ~20 minutes of runtime on the no-tests-as-filters sanity test.
2018-08-23 21:20:29 -07:00
Toshio Kuratomi
f46c943d3d Fix another corner case of too many warnings for world readable current working directory
There should be no warning if there is no ansible.cfg file i nthe
current working directory.
2018-08-23 20:23:59 -07:00
Toshio Kuratomi
8ed7e80fc8
Remove from roadmap, thing that aren't going to make it for 2.7 (#44481)
* Remove from roadmap, thing that aren't going to make it for 2.7
* Added actual Windows roadmap deliverables
2018-08-23 19:32:27 -07:00
Sam Doran
4d9218cec4 Add reboot action plugin (#35205)
* Update docs

* Add reboot action plugin

Refactor win_reboot so it is subclassed from reboot

* Use new connection methods

* Test fixes

* Use better uptime command for Linux

Use who -b to get the last time the system was booted rather than uptime, which changes every second.

* Use distribution specefic commands and flags

Query the managed node to determien its distribution, then set the appropriate command and flags.

* Tune debug messages a bit

* Update module docs with details about pre_reboot_delay

s docs

* Ensure that post_reboot_delay is a positive number

* Remove the stringification

* Add integration tests

* Make sure aliases are honored

* Handle systems that have an incorrect last boot time

SystemD and fakehw-clock do not properly set the
last boot time and instead always set it to epoch.
Use a different command if that is the case.

* Copyright and encoding fixes

* Minor fixes based on feedback

* Add exponential backoff to sucess check method

* Update integration test

Skip the integration test if it would try to reboot the control node. We need a new mechanism to account for this scenario in ansible-test, so tests must currently be run manually for this plugin.

* Update integration test

Skip the integration test if it would try to reboot the control node. We need a new mechanism to account for this scenario in ansible-test, so tests must currently be run manually for this plugin.

* Fail early with running with local connection

* Update docs based on feedback

* minor refactoring, state mgmt changes
2018-08-23 18:12:12 -07:00
Will Thames
60e3af42d5 sns_topic boto3 port (#39292)
* Port sns_topic to boto3 and add tests
2018-08-23 21:04:18 -04:00
Stephen SORRIAUX
a78cc15099 Add new parameters to manage mtime and atime for file module, fixes #30226 (#43230)
* Add new parameters related to mtime and atime for file module, fixes #30226
2018-08-23 17:20:54 -07:00
Balthazar Rouberol
1b3f074ec6 Change DataDog to Datadog (#34273) 2018-08-23 20:20:29 -04:00
Brian Coca
9cc56981b5
Add new host_pinned strategy (#44586)
The 'free' strategy still attempts to do all hosts per task before going to the next, it just doesn't wait for slow hosts,
This strategy processes each host as fast as possible to the end of the play before trying to process another host in the pool.
2018-08-23 20:16:32 -04:00
Matt Clay
3fb5056606 Fix PEP8 issue. 2018-08-23 16:43:59 -07:00
Sloane Hertel
79ecb4c41f
Add diff mode for ec2_group (#44533)
* Add (preview) diff mode support ec2_group

* Add diff mode to some ec2_group integration tests

* Remove unnecessary arguments and add comment to the module notes

* Add changelog
2018-08-23 19:43:18 -04:00
Sloane Hertel
b152515fcb RDS inventory plugin (#41919)
Comments out uses of rds_instance in the integration tests and replace with AWS CLI until rds_instance has been merged
2018-08-23 19:42:32 -04:00
Dag Wieers
3d70274864
Added an async 'started' test (like 'finished') (#43445) 2018-08-24 01:29:34 +02:00
Dag Wieers
cc2164f92a
ACI: Add specific info about running locally (#43903)
Since the ACI modules (like most network-related modules) run on the
local controller, this PR adds the necessary details so users are aware
of this particular feature.
2018-08-24 01:28:39 +02:00
Matt Clay
18da873531 Ignore CentOS 6.10 for passwordstore test. 2018-08-23 15:39:57 -07:00
Yanis Guenane
a791bd2059 BOTMETA: Create a $team_scaleway and add Spredzy in it (#44597) 2018-08-23 23:34:23 +01:00
Abhijeet Kasurde
419e09d9ec botmeta: IPA: Notify IPA team for module_utils changes (#44577)
Add team_ipa for changes in module_utils/ipa.py

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-23 23:41:07 +02:00
Matt Martz
242e9229a1
Pin deprecation of tags in params for include to deprecation of include (#44596) 2018-08-23 16:25:33 -05:00
Felix Fontein
0e6234ab04 Adding module which allows to complete certificate chains (#44169)
* Adding certificate_complete_chain module.

* Avoid code smell errors.

* Removing input_chain_src.

* Make sure line ending is there.
2018-08-23 23:18:36 +02:00
Yanis Guenane
72d4880b85 Vultr: Introduce the Vultr inventory plugin (#44400)
This commit introduce the Vultr inventory plugin.
2018-08-23 23:14:26 +02:00
sirkubax
07375be490 Fix docs errors (#33704) 2018-08-23 16:11:07 -05:00
Tim Rupp
14909e76ec
Adds features to device connectivity (#44598)
Adds new parameter and removes f5-sdk
2018-08-23 17:08:28 -04:00
Tim Rupp
9c12d845ab
Removes f5-sdk code from bigip modules (#44595)
This patch is part of an ongoing effort to fully remove the f5sdk
from the f5 modules.
2018-08-23 16:53:34 -04:00
GElkayam
4bea004a4e Fix assign_public_ip: no disregarded (#29691) (#43954)
in case assign_public_ip is False, it is not handled.
2018-08-23 16:43:44 -04:00
Pilou
9e072c7501 botmeta: scaleway isn't core (#44511) 2018-08-23 21:04:16 +01:00
Tim Rupp
05920b92d6
Misc fixes to bigip modules. (#44594)
Adding docs, formatting docs, adding validation checks and values
2018-08-23 15:57:08 -04:00
Matt Martz
2787bda0fa
Deprecated version should be an explicit version number (#44593) 2018-08-23 14:45:39 -05:00
Tim Rupp
1fd6821db0
Add parameter and remove netaddr (#44584)
This patch adds a description parameter to most fields. It also removes
netaddr from the modules.
2018-08-23 15:28:08 -04:00
Matt Clay
31a5b874a1 Use runtime instead of datetime for test output. 2018-08-23 12:05:10 -07:00
Alan Rominger
34b36d5178 add missing entry to package_data (#44585) 2018-08-23 14:00:22 -05:00
Matt Martz
dab975d302
Unit tests for ansible.playbook.become (#38541) 2018-08-23 13:47:20 -05:00
Jose Rodriguez
14e3febb2c Prevent utf-8 codec error in py3 (#44228)
Cannot upload templates in Python 3.x. Gives utf-8 codec error.
Fixes this by opening the template file in binary mode.
2018-08-23 14:33:00 -04:00