Commit graph

18235 commits

Author SHA1 Message Date
Chris Meyers
f00f2466d4 tests for InventoryModule error conditions (#31381)
* tests for InventoryModule error conditions

* modified unicode in tests to ahear to Ansible best practices

* flake8 fixes

(cherry picked from commit cf938e9992)
2017-11-08 10:56:19 -08:00
Jan Pazdziora
000df969dc Fix #31694: running with closed stdin on python 3 (#31695)
(cherry picked from commit e5dbf63b65)
2017-11-08 12:02:33 +01:00
Brian Coca
aa54a3510f handle ignore_errors in loop
ensures we get both a templated ignore_errors and a
correct 'summary' result for ignore_errors when used in loops

fixes #32384

(cherry picked from commit d22627d944)
2017-11-07 19:53:18 -05:00
Kevin Zhao
24743e5cdc cherry-pick changes of azure_rm_common from devel to 2.4 (#32607)
* remove explicit provider reg from azure_rm (#31369)

* now that it's handled automatically as of msrest > 0.4.9

* add user-agent to Azure API calls (#31872)

* addi Ansible user-agent in Azure API calls

* fix import error

* add user agent for cloud shell (#32332)
2017-11-07 14:56:09 -08:00
Ryan S. Brown
e9b5e14764 [cloud] sns_topic: Fix unreferenced variable
Cherry-pick of 4e759a9cce
2017-11-07 09:55:26 -05:00
David Hain
97c3037206 Use to_native when validating proxy result (#32596)
* Use bytes directly instead of converting to text
(cherry picked from commit 708829fab9)
2017-11-06 09:22:17 -08:00
Sloane Hertel
793c473fe2 Use region derived from get_aws_connection_info() in dynamodb_table to fix tagging bug (#32557) 2017-11-06 08:49:09 -05:00
Martin Krizek
36bcab8a68 yum: use the C locale when screen scraping (#32203)
(cherry picked from commit a8ab1a0b20)
2017-11-06 11:31:32 +01:00
Martin Krizek
d8bfed678c git: fix archive when update is set to no (#31829)
(cherry picked from commit e3a847a142)
2017-11-06 11:28:46 +01:00
Toshio Kuratomi
0796190053 Prefer the stdlib SSLContext over urllib3 context
We do not go through the effort of finding the right PROTOCOL setting if
we have SSLContext in the stdlib.  So we do not want to hit the code
that uses PROTOCOL to set the urllib3-provided ssl context when
SSLContext is available.  Also, the urllib3 implementation appears to
have a bug in some recent versions.  Preferring the stdlib version will
work around that for those with Python-2.7.9+ as well.

Fixes #26235
Fixes #25402
Fixes #31998

(cherry picked from commit 725ae96e1b)
2017-11-04 13:11:45 -07:00
patlachance
309dbecbc7 iam.py: return iam.role dict when creating roles (#28964)
(cherry picked from commit 45e35be4c1)
2017-11-03 10:07:21 -04:00
Toshio Kuratomi
07fa571502 Fix non-ascii errors in config manager
(cherry picked from commit d166bba126)
2017-11-02 19:32:12 -07:00
Jordan Borean
e771b64f1b win_service: quoted path fix (#32469)
* win_service: fix for path in quotes

* Added tests to verify behaviour doesn't regress

(cherry picked from commit 5b1db00b65)
2017-11-03 09:56:08 +10:00
Brian Coca
07674f5062 ini plugin should recursively instantiate pending
solves inconsistent behaviour on ini host format depending on definition order
fixes #32196

(cherry picked from commit 9d28973b5e)
2017-11-02 17:58:19 -04:00
Ondra Machacek
dd930344b6 ovirt_hosts: Don't fail upgrade when NON_RESPONSIVE state 2017-11-02 14:40:31 -04:00
Ondra Machacek
3df921a14a ovirt_clusters: Fix fencing and kuma comparision 2017-11-02 14:37:19 -04:00
Ondra Machacek
dd19f96561 ovirt_host_networks: Fix label assignment 2017-11-02 14:34:39 -04:00
Brian Coca
fa289a022c correctly deal with changed (#31812)
(cherry picked from commit 21cdddce74)
2017-11-02 12:31:52 -04:00
u571kills
0140372d0f Fix example on comparing master config (#32406)
Current example produces error message:

"msg": "Unsupported parameters for (ios_config) module: diff_config Supported parameters include: after,auth_pass,authorize,backup,before,defaults,diff_against,diff_ignore_lines,force,host,intended_config,lines,match,multiline_delimiter,parents,password,port,provider,replace,running_config,save,save_when,src,ssh_keyfile,timeout,username"
(cherry picked from commit 869cf3fbdb)
2017-11-01 17:44:01 -07:00
Jordan Borean
6a7333950a win_find: allow module to skip on files it fails to check (#32105)
* win_find: allow module to skip on files it fails to check

* fixed up test creation to work pre psv5

(cherry picked from commit 56a7278256)
2017-11-02 09:36:53 +10:00
Ganesh Nalawade
5bbf70afe1
Fixes #31090. In network parse_cli filter plugin, this change moves the creation of a (#31092) (#32458)
new match(block). It previously only occurred if a new match occurred,
but suggest it should occur when an end of a block match is found.
(cherry picked from commit 7553c42e09)

Update CHANGELOG
2017-11-01 23:46:14 +05:30
Ganesh Nalawade
bc01b5d981
eos_eapi: adding the desired state config to the new vrf fixes #32111 (#32112) (#32452)
* adding the desired state config to the new vrf fixes #32111

* fix default vrf initial configured

* add unit test

* Update CHANGELOG

(cherry picked from commit 2c99cbc874)
2017-11-01 23:02:51 +05:30
Ganesh Nalawade
b8ee3bb24f
Fix wrong prompt issue for network modules (#32426) (#32442)
* Fix wrong prompt issue for network moodules

Fixes #31161
Fixes #32416

*  Store the device prompt in case of error
   from remote device
*  Check for prompt value in ios action plugin

*  Add integration test
*  Update Changelog

(cherry picked from commit 26583adb58)
2017-11-01 22:35:47 +05:30
Yawei Wang
0faa72e8c4 add check mode for acs delete (#32063)
(cherry picked from commit d7c8fdbd79)
2017-11-01 08:58:28 -07:00
Kedar K
ac1c7b03ff - Fix logging module issue where facility is being deleted along with host (#32234)
- Remove default facility, as facility is not standard on remote syslog server
(cherry picked from commit 7d5dccefe5)
2017-11-01 08:54:33 -07:00
Paul Neumann
de60b9e1a8 ios_logging: Fix some smaller issues, add unit test (#32321)
* ios_logging: Fix typo in documentation

* ios_logging: Fix traceback when setting buffered destination without size

When the size parameter is not configured while configuring the buffered
destination, a traceback occurs due to the fact that validate_size expects the
parameter to be an int. Explicitely converting value to int makes the
check work for every case.

* ios_logging: Update size parameter documentation

Update the documentation of the size paramter to reflect the current behaviour
of setting a default of 4096 for the buffered dest.

* ios_logging: Add unit test

Add unit test for ios_logging testing the behaviour clarified in the previous
commits.

* ios_logging: Fix python 2.6 compliance

(cherry picked from commit 53fead7c96)
2017-11-01 08:53:39 -07:00
Brian Coca
9233ece224 calculate max fail against all hosts in batch
currently it is doing only from the 'active' hosts in the batch which means
the percentage goes up as hosts fail instead of staying the same.
added debug info for max fail

fixes #32255

(cherry picked from commit 4fb9e54c50)
2017-11-01 08:46:15 -07:00
Ganesh Nalawade
8c1dfdbc31
Move asa provider to suboptions (#32356)
Fixes #32343

* Move provider arg spec as part of suboptions
  to validate input args against provider spec.
* This handles `no_log` for password arg correctly.

Merged to devel PR #28984

( cherry picked from commit 599fe23ed6 )
2017-11-01 09:16:53 +05:30
Matt Davis
8ae0079ef7 luseradd defaults to creating w/o need for -m (#32411)
and -M is incorrect in this case

(cherry picked from commit 3e80f9caf4)
2017-10-31 14:37:22 -07:00
Brian Coca
5398d653ca corrected package docs
(cherry picked from commit 43714a0091)
2017-10-31 16:39:05 -04:00
Brian Coca
f79cd6c846 adjust nohome param when using luser
fixes #32199

(cherry picked from commit bd321a0af6)
2017-10-31 16:37:10 -04:00
Trishna Guha
cb696ba112
Handle ip name-server lines containing multiple nameservers (#32235) (#32373)
In CSR, multiple nameservers are defined in one line, whereas on IOS
it's on multiple ones.
This change handles both.
(cherry picked from commit 80c8b99a62)
2017-10-31 12:06:49 +05:30
Brian Coca
34d7f9e3db remove misleading group vars as they are flat (#32276)
* remove misleading group vars as they are flat

* fixed vars display

(cherry picked from commit 75a6f9dbc2)
2017-10-30 13:00:03 -04:00
Brian Coca
3cf7e31c4e ensure we always have a basedir
(cherry picked from commit 64220fcbcc)
2017-10-30 12:29:15 -04:00
Toshio Kuratomi
fdcb419c8d Revert "Removed a force conditional (#28851)" (#32282)
This reverts commit 07acc579db.

On closer examination of this code, the conditional that had force in it
was not a parent of this one.  So handling of force is needed i both
branches.

See the recent comments on #23391
(cherry picked from commit 2e12a5f8c2)
2017-10-28 07:29:54 -07:00
Benjamin Schweizer
1e318f6224 Enable TLS1.1 and TLS1.2 for win_package (#32184)
(cherry picked from commit f2023a84a6)
2017-10-27 12:04:31 +10:00
Toshio Kuratomi
c495103996 New release v2.4.2.0-0.1.beta1 2017-10-26 17:00:44 -07:00
awkspace
124b3dce50 Fix ec2_lc failing to create multi-volume configurations (#32191) 2017-10-27 09:08:57 +10:00
Sloane Hertel
2a42800c44 An availability zone will be selected if none is provided. Set az to an empty string if it's None to avoid traceback. (#32216) 2017-10-27 09:07:19 +10:00
Ryan Brown
a0c123a86e [cloud] Bugfix for aws_s3 empty directory creation (#32198)
* [cloud] Bugfix for aws_s3 empty directory creation

Backport of #32169

* Only make DeleteObject call if there are objects to delete

* Remove pauses from integration tests
2017-10-26 15:04:00 -04:00
Sam Doran
bb7977c5b4 Return all elements in a more robust way
If a trailing ':' is set or not, always return all secrets from a path.

Update examples.

(cherry picked from commit 6a6ea663ea)
2017-10-26 14:50:26 -04:00
Sam Doran
4a8ffe56a9 Enable ECHO in prompt module (#32083)
* Enable ECHO in prompt module

Fixes #14160

* Set flags to make it possible to edit echoed input as well as hide control charcters

Only do this if a time limit is not set.

* Consolidate settings

(cherry picked from commit 104934c095)
2017-10-26 12:39:53 -04:00
Marc Mercer
10d6e1be90 Cast target port to an int in elb_target_group. Fixes #32098 (#32202)
(cherry picked from commit 17a008654a)
2017-10-26 09:35:43 -07:00
Dave Thelen
2340c7ac6e eos_user: sends user secret first on user creation fixes #31680 (#32162)
* fix command order

* add integration test

* test cleanup

* remove redudant commands

(cherry picked from commit 602a618e60)
2017-10-26 07:43:19 -07:00
Trishna Guha
6d4d2d88b4 fix nxos_igmp_snooping (#31688)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 529b7a7b78)
2017-10-26 07:38:23 -07:00
Kedar K
70c3aefdaf - Fix to return error message back to the module. (#31035)
(cherry picked from commit 916e6be888)
2017-10-26 07:38:23 -07:00
rahushen
a69f93f4f5 Fixes #31056 (#31057)
(cherry picked from commit 046d430a26)
2017-10-26 07:38:23 -07:00
rahushen
f2e8339467 Fix nxos_banner removal idempotence issue in N1 images (#31259)
* Fix nxos_banner removal idempotence issue in N1 images

* handle pep8 error

(cherry picked from commit 025386c56b)
2017-10-26 07:38:23 -07:00
Prasad Katti
a59eede7a2 [cloud] add boto3 requirement to cloudformation module docs (#31135) 2017-10-26 07:37:47 -07:00
tedder
f29285b4b5 Exclude stack policy when running in check mode.
Fixes #31931
2017-10-26 07:37:47 -07:00