wbrawner/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
26687 commits 42 branches 295 tags 186 MiB
Commit graph

13302 commits

Author SHA1 Message Date
Rob
09b7470983 Added doc for new get_ec2_security_group_ids_from_names function in m… 2016-12-08 11:34:11 -05:00
Gonçalo Luiz
8a1aee53bc fixed not resolving latest to snapshot for MD5 check when the file ex… 2016-12-08 11:34:11 -05:00
Adrian Likins
a66a0187d1 Expect 204 status when using hipchat v2 api. 
When posting to the room notication api with hipchat
v2 api, the expected return code is 204, as per:
https://www.hipchat.com/docs/apiv2/method/send_room_notification

fixes #2143
 2016-12-08 11:34:11 -05:00
Ryan G. Hunter
67967d04ee monit startup fix 2016-12-08 11:34:11 -05:00
Toshio Kuratomi
7212bc294e Fix documentation 2016-12-08 11:34:11 -05:00
Michael Scherer
2f51bf3a9c Fix arguments and docs (#2147) 
- oauthkey shouldn't be logged
- action should be restricted and checked and the
doc should correspond to the code
 2016-12-08 11:34:11 -05:00
krzwalko
a7fe4cee03 Fix datacenter_name and cluster_name module params (#2142) 2016-12-08 11:34:11 -05:00
Rudi Meyer
913afa9a99 Jira will return a HTTP status code 201 on some actions, fx. 'comment'. (#2115) 2016-12-08 11:34:11 -05:00
Toshio Kuratomi
fda13deb08 Switch blockinfile to using the latest best way to get ansible version 2016-12-08 11:34:11 -05:00
René Moser
41c8e43e34 readme: add build state image from travis 2016-12-08 11:34:11 -05:00
Rene Moser
87e975776a azure_rm_deployment: fix docs and move import utils near main() 
fixes build
 2016-12-08 11:34:11 -05:00
Michael Scherer
ab26847e06 Remove unused import of 'socket' module 2016-12-08 11:34:11 -05:00
Michael Scherer
6c959dc77e Mark api_key as no_log, since that's supposed to be kept secret 2016-12-08 11:34:11 -05:00
Michael Scherer
557d27513c Use type=path for arguments, and remove code doing the conversion (#1903) 2016-12-08 11:34:10 -05:00
Michael Scherer
07f8846134 Mark api_key as no_log to avoid potential leaks (#2048) 2016-12-08 11:34:10 -05:00
Brian Coca
b5033fb597 updated version added for pvs 2016-12-08 11:34:10 -05:00
Markus Ostertag
8fd23c7d75 Change success status code to 202 
As I already mentioned here: a1b1182662 (diff-d04a476e5d71372918cb6e7e5b39a683R120) @jimi-c added some "hidden" additional check in his urllib commit and broke the whole module for everybody as Datadog answers with an 202 in case of success (http://docs.datadoghq.com/api/#troubleshooting).
 2016-12-08 11:34:10 -05:00
p53
517feda4ac Add pvs parameter to documentation 
Add pvs parameter to documentation
 2016-12-08 11:34:10 -05:00
Pavol Ipoth
a273efbcd2 Removing, unwanted pull 2016-12-08 11:34:10 -05:00
Pavol Ipoth
168ca49103 Adding new ansible module lvol_cache 2016-12-08 11:34:10 -05:00
Pavol Ipoth
aa9152d169 Fixes #2008 Lvol module is not indempodent for cache lv's 2016-12-08 11:34:10 -05:00
Pavol Ipoth
c91b94402b Added pvs parameter to lvol module 2016-12-08 11:34:10 -05:00
Toshio Kuratomi
69bccf57d6 Recategorize git_config and shift version to 2.1 2016-12-08 11:34:10 -05:00
chouseknecht
ff624f9ef4 Updated per PR comments 2016-12-08 11:34:10 -05:00
chouseknecht
1d7a109867 Rename azure_deploy to azure_rm_deployment. Refactor to use azure_common. 2016-12-08 11:34:10 -05:00
Brian Coca
12ca251c86 updated version added 2016-12-08 11:34:10 -05:00
Matthew
a24444eb9c Add git_config module (#1945) 
* Add git_config module

This module can be used for reading and writing git configuration at all
three scopes (local, global and system). It supports --diff and --check
out of the box.

This module is based off of the following gist:
https://gist.github.com/mgedmin/b38c74e2d25cb4f47908
I tidied it up and added support for the following:
- Reading values on top of writing them
- Reading and writing values at any scope
The original author is credited in the documentation for the module.

* Respond to review feedback

- Improve documentation by adding choices for parameters, requirements
  for module, and add missing description for scope parameter.
- Fail gracefully when git is not installed (followed example of puppet
  module).
- Remove trailing whitespace.

* Change repo parameter to type 'path'

This ensures that all paths are automatically expanded appropriately.

* Set locale to C before running commands to ensure consistent error messages

This is important to ensure error message parsing occurs correctly.

* Adjust comment
 2016-12-08 11:34:10 -05:00
Michael Scherer
2ec17e4614 Add partial doc on return value of virt (#2116) 2016-12-08 11:34:10 -05:00
jhawkesworth@users.noreply.github.com
e878cf43f6 Fix for https://github.com/ansible/ansible-modules-extras/issues/2090 2016-12-08 11:34:10 -05:00
Hans-Joachim Kliemeck
b36fc23a50 suggestion by @nitzmahone to not use Get-Attr in combination with ConvertTo-Bool, improved documentation regarding organize 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck
ba0c75f5a7 fixed version added and tests 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck
867b7a9649 fixed bugs with flipped protection attribute 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck
632df80276 introduced state to differentiate between enabled/disabled inheritance. renamed copy to reorganize, since the meaning for inheritance=enabled is different 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck
bdf0a888bb suggestions by @marcind 2016-12-08 11:34:09 -05:00
Hans-Joachim Kliemeck
a240b14e09 added module to disable acl inheritance 2016-12-08 11:34:09 -05:00
Brian Coca
954d650e6a promoted to core, including fixes 2016-12-08 11:34:09 -05:00
James Cammarata
fa0c10017e Removing docker_login as it's now in core 2016-12-08 11:34:09 -05:00
René Moser
e47aee031b docs: fix make docs (#2107) 2016-12-08 11:34:09 -05:00
Tim Rupp
a13141413a Adds the __main__ conditional check (#2098) 
As is done in other ansible modules, this adds the __main__ check
to the module so that the module code itself can be used as a library.
For instance, when testing the code.
 2016-12-08 11:34:09 -05:00
Joshua Gilman
c0a677aa3a Change disk type to str to allow correct usage of rootfs for LXC (#2091) 2016-12-08 11:34:09 -05:00
Rene Moser
002ce4b352 consul: add docs, fix typos, minor style fix 2016-12-08 11:34:09 -05:00
Sun JianKang
f7b6523ff5 add service address when register service (#1299) 2016-12-08 11:34:09 -05:00
Ner'zhul
bb4751e791 Add mongodb parameter module (#1596) 
* Add mongodb parameter module

This module permit to configure mongodb live parameters to tune the running engine
 2016-12-08 11:34:09 -05:00
Adrià Galín Figueras
d802e00417 Fixed netif params when create lxc container (#2064) 2016-12-08 11:34:09 -05:00
Toshio Kuratomi
07e150779d Switch from deprecated ANSIBLE_VERSION to ansible.__version__ 2016-12-08 11:34:08 -05:00
Rene Moser
9e05fc35ea vmware_vm_shell: doc: add missing defaults 2016-12-08 11:34:08 -05:00
Ritesh Khadgaray
378707e1f7 vmware_vm_shell: speed up vm_name search (#1909) 2016-12-08 11:34:08 -05:00
Chris Lamb
c0787b12ce system/ufw.py: Add security warning re. removing ufw application prof… 
It's not particularly obvious that removing an application will remove it
from ufw's own state, potentially leaving ports open on your box if you
upload your configuration.

Whilst this applies to a lot of things in Ansible, firewall rules might
cross some sort of line that justifies such a warning in his instance.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
 2016-12-08 11:34:08 -05:00
jhawkesworth@users.noreply.github.com
b94a614b7e fix problem where you couldn't compare empty strings in win_regedit following my previous change 2016-12-08 11:34:08 -05:00
Emil Bostijancic
3d24895606 Fixes maven_artifact - verify_md5 only called for SNAPSHOT 
* fixed https://github.com/ansible/ansible-modules-extras/issues/2066

* fixes https://github.com/ansible/ansible-modules-extras/issues/2066
 2016-12-08 11:34:08 -05:00
Michael Scherer
bcf4c6be49 Fix aibrake 2016-12-08 11:34:08 -05:00
Stefan Magnus Landrø
fb3e970bd3 Honouring verify_ssl when using username/password for authentication … 2016-12-08 11:34:08 -05:00
James Cammarata
c6e8b9a0b7 Fixing/cleaning up kubernetes submission 
1) Removed kubectl functionality. We'll move that into a different
   module in the future. Also removed post/put/patch/delete options,
   as they are not Ansible best practice.
2) Expanded error handling in areas where tracebacks were most likely,
   based on bad data from users, etc.
3) Added an 'insecure' option and made the password param optional, to
   enable the use of the local insecure port.
4) Allowed the data (both inline and from the file) to support multiple
   items via a list. This is common in YAML files where mutliple docs
   are used to create/remove multiple resources in one shot.
5) General bug fixing.
 2016-12-08 11:34:08 -05:00
Eric Johnson
a59cb5cae1 Adding kubernetes module 2016-12-08 11:34:08 -05:00
Michael Scherer
d1c6b6f3b8 Fix default url in airbrake_deployment doc (#2078) 2016-12-08 11:34:08 -05:00
Toshio Kuratomi
7b1704640e Make main() only run when invoked as a script (style cleanup) 2016-12-08 11:34:08 -05:00
Dreamcat4
314843b431 win-firewall-rule: temp disable strict-mode for the time being 2016-12-08 11:34:08 -05:00
Dreamcat4
820d5a7a3e fix: win-environment strict-mode fixes 2016-12-08 11:34:08 -05:00
Dreamcat4
572b6669c4 fix: win-scheduled-task strict-mode fixes 2016-12-08 11:34:08 -05:00
Laurent Mazuel
8973ecae5b Add user-agent information for analytics 2016-12-08 11:34:08 -05:00
Andre Price
28b0a52245 Get failed deployments when create fails also 2016-12-08 11:34:07 -05:00
Laurent Mazuel
098a4c9ee4 Updated to use ServicePrincipalCredentials class and get rid of requests 2016-12-08 11:34:07 -05:00
Laurent Mazuel
ee6fc470db Fixes after Travis feedback 2016-12-08 11:34:07 -05:00
Laurent Mazuel
771c40952b Py2.6 compatible + minor fixes 2016-12-08 11:34:07 -05:00
Laurent Mazuel
96ea53d1f2 Fix YAML documentation 2016-12-08 11:34:07 -05:00
Laurent Mazuel
5d5cac57ff Add update from @obsoleted 2016-12-08 11:34:07 -05:00
Laurent Mazuel
801c44df9e Azure plugin using Azure Python SDK 2.0.0rc1 2016-12-08 11:34:07 -05:00
David Justice
a4cc8dfa2c add azure resource manager template deployment module 2016-12-08 11:34:07 -05:00
Rob
1d01d232a9 New module - ec2_snapshot_facts (#1088) 2016-12-08 11:34:07 -05:00
Adam Romanek
faa3c54531 Fixed #237 - improved embedded JSON support handling (#1530) 2016-12-08 11:34:07 -05:00
Victor Costan
e5742c3a47 amazon/GUIDELINES.md: Fix copy-paste typo (#2060) 2016-12-08 11:34:07 -05:00
jhawkesworth@users.noreply.github.com
b08b1cf2f3 Documentation improvements 2016-12-08 11:34:07 -05:00
jhawkesworth@users.noreply.github.com
aaa9541abd Further fixes to support binary data. Added boolean return values and return documentation. 2016-12-08 11:34:07 -05:00
jhawkesworth@users.noreply.github.com
c2ca0a9e93 adding the ability to manage binary registry data 2016-12-08 11:34:07 -05:00
Robin Roth
5464b71561 Zypper repository rewrite (#1990) 
* Remove support for ancient zypper versions

Even SLES11 has zypper 1.x.

* zypper_repository: don't silently ignore repo changes

So far when a repo URL changes this got silently ignored (leading to
incorrect package installations) due to this code:

    elif 'already exists. Please use another alias' in stderr:
        changed = False

Removing this reveals that we correctly detect that a repo definition
has changes (via repo_subset) but don't indicate this as change but as a
nonexistent repo. This makes us currenlty bail out silently in the above
statement.

To fix this distinguish between non existent and modified repos and
remove the repo first in case of modifications (since there is no force
option in zypper to overwrite it and 'zypper mr' uses different
arguments).

To do this we have to identify a repo by name, alias or url.

* Don't fail on empty values

This unbreaks deleting repositories

* refactor zypper_repository module

* add properties enabled and priority
* allow changing of one property and correctly report changed
* allow overwrite of multiple repositories by alias and URL
* cleanup of unused code and more structuring

* respect enabled option

* make zypper_repository conform to python2.4

* allow repo deletion only by alias

* check for non-existant url field and use alias instead

* remove empty notes and aliases

* add version_added for priority and overwrite_multiple

* add version requirement on zypper and distribution

* zypper 1.0 is enough and exists

* make suse versions note, not requirement

based on comment by @alxgu
 2016-12-08 11:34:07 -05:00
Michael Scherer
3d21f7c5a4 Mark the token as sensitive, since it shouldn't be printed (#2043) 2016-12-08 11:34:07 -05:00
Jiri Tyr
48c20dd981 Describing the _none_ value of the proxy option (#2053) 2016-12-08 11:34:06 -05:00
Jay Jahns
09aa205209 Add Maintenance Mode support for VMware (#1754) 
* add vmware maintenance mode support

* changed version number in documentation

* updated version_added to 2.0 since CI is failing

* changed version to 2.0 due to CI - error asking for 2.1

* added RETURN

* updated formatting of return values and added some to clarify actions taken
 2016-12-08 11:34:06 -05:00
codehopper-uk
e2e0f51739 Basic ability to set masquerade options from ansible, according to current code design/layout (mostly) (#2017) 
* Support for masquerade settings

Ability to enable and disable masquerade settings from ansible via:
- firewalld: mapping=masquerade state=disabled permanent=true zone=dmz

Placeholder added (mapping) to support masquerade and port_forward
choices initially - port_forward not implemented yet.

* Permanent and Immediate zone handling differentiated

* Corrected naming abstraction for masquerading functionality

Removed mapping tag with port_forward choices - not applicable!

* Added version info for new masquerade option

Pull Request #2017 failing due to missing version info
 2016-12-08 11:34:06 -05:00
Jordan Cohen
e07cc7d9a2 idempotency fix (#2024) 2016-12-08 11:34:06 -05:00
Karim Boumedhel
e57ef71ed3 Add cloudinit support to ovirt.py module 2016-12-08 11:34:06 -05:00
Michael Scherer
567bcf1341 Do not leak password by error for ovirt module (#1991) 2016-12-08 11:34:06 -05:00
Michael Scherer
5d2063aa38 Remove the +x from crypttab and cronvar (#2039) 
While this change nothing, it is better to enforce consistency
 2016-12-08 11:34:06 -05:00
Michael Scherer
d79c427722 Set api_key as no_log, since that's likely something that should be kept private (#2038) 2016-12-08 11:34:06 -05:00
Fernando José Pando
94c5e16fe3 Add SQS queue policy attachment functionality (#1716) 
* Add SQS queue policy attachment functionality

SQS queue has no attribute 'Policy' until one is attached, so this special
case must be handled uniquely

SQS queue Policy can now be passed in as json
 2016-12-08 11:34:06 -05:00
Michael Scherer
ad54180d17 Do not use a default value for -n parameter, fix #1400 (#1417) 2016-12-08 11:34:06 -05:00
Michael Scherer
a7b843ca80 Use type=path for pem_file, since that's a file (#1934) 2016-12-08 11:34:06 -05:00
Evgeni Golov
3bbef8dc24 fix handling of config options that share the same prefix 
container_config:
      - "lxc.network.ipv4.gateway=auto"
      - "lxc.network.ipv4=192.0.2.1"

might try to override lxc.network.ipv4.gateway in the second entry as both
start with "lxc.network.ipv4".
use a regular expression to find a line that contains (optional) whitespace
and an = after the key.

Signed-off-by: Evgeni Golov <evgeni@golov.de>
 2016-12-08 11:34:06 -05:00
Evgeni Golov
317ca77193 strip whitespace from key and value before inserting it into the config 
before the following would produce four entries:

    container_config:
      - "lxc.network.flags=up"
      - "lxc.network.flags =up"
      - "lxc.network.flags= up"
      - "lxc.network.flags = up"

let's strip the whitespace and insert only one "lxc.network.flags = up"
into the final config

Signed-off-by: Evgeni Golov <evgeni@golov.de>
 2016-12-08 11:34:06 -05:00
Michael Scherer
b4c3d32366 Mark conf_file as a path, for various user expansion 2016-12-08 11:34:06 -05:00
Christopher M. Fuhrman
310b7ce3d8 pkgin: Fix bad regexp which did not catch packages such as p5-SVN-Notify 
The previous version of my regexp did not take into account packages
such as 'p5-Perl-Tidy' or 'p5-Test-Output', so use a greedy match up to
the last occurrance of '-' for matching the package.  This regex has
been extensively tested using all packages as provided by pkgsrc-2016Q1[1].

Footnotes:
[1]  http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/?only_with_tag=pkgsrc-2016Q1
 2016-12-08 11:34:06 -05:00
Michael Scherer
7c19002f34 Fix arguments for pushover module 
Since user_key and app_token are used for authentication, I
suspect both of them should be kept secret.

According to the API manual, https://pushover.net/api
priority go from -2 to 2, so the argument should be constrained.
 2016-12-08 11:34:06 -05:00
Ricardo Carrillo Cruz
eda5e2f571 Add os_project_facts module 
This module gathers facts about OpenStack projects
 2016-12-08 11:34:05 -05:00
Jasper Lievisse Adriaanse
0fb01e45fb Sprinkle some LANG/LC_* where command output is parsed (#2019) 2016-12-08 11:34:05 -05:00
Jasper Lievisse Adriaanse
8913f1a11d Tweak and extend the pkgin module 
- make path to pkgin a global and stop passing it around; it's not going
  to change while ansible is running
- add support for several new options:
  * upgrade
  * full_upgrade
  * force
  * clean
- allow for update_cache to be run in the same task as upgrading/installing
  packages instead of needing a separate task for that
 2016-12-08 11:34:05 -05:00
Jens Carl
cf804fb0b8 Fix code example (#2018) 2016-12-08 11:34:05 -05:00
Werner Dijkerman
1bcc43ca4e New module for creating gitlab projects (#968) 2016-12-08 11:34:05 -05:00
Werner Dijkerman
37b7c1d0cd New module for creating gitlab groups (#967) 2016-12-08 11:34:05 -05:00
Werner Dijkerman
22c62debb5 New module for creating gitlab users (#966) 2016-12-08 11:34:05 -05:00
René Moser
5197654437 cloudstack, cs_firewall: fix network not found error in return results (#2006) 
Only a small issue in results.

In case of type is ingress, we rely on ip address, but in results we also return the network.
Resolving the ip address works without zone params. If the ip address is not located in the default zone and zone param is not set,
the network won't be found because default zone was used for the network query listing.

However since network param is not used for type ingress we skip the return of the network in results.
 2016-12-08 11:34:05 -05:00
René Moser
d7e8dd22df cloudstack: cs_instance: fix template not found (#2005) 
Let users decide which filter should be used to find the template.
 2016-12-08 11:34:05 -05:00
Rene Moser
b5e4edd9f9 cloudstack: cs_template: fix state=extracted 
* url arg is optional but we enforced it
* url is in a required together, but args only relevant while registering
 2016-12-08 11:34:05 -05:00
Rene Moser
1b99ae4ac1 cloudstack: fix doc, display_text not required 2016-12-08 11:34:05 -05:00
Rene Moser
871f586378 cloudstack: cs_template: fix cross_zones template removal 2016-12-08 11:34:05 -05:00
David Shrewsbury
b928ffb5ac New OpenStack module os_port_facts (#1986) 2016-12-08 11:34:05 -05:00
Michael Scherer
1d1fba5476 Mark token as no_log, since that's used for auth (#2011) 2016-12-08 11:34:05 -05:00
Andrea Scarpino
b4064a352e The enable parameter is a boolean, then convert to a boolean. (#1607) 
At the moment, this only works when 'enable' is equals to 'yes' or 'no'.

While I'm on it, I also fixed a typo in the example and added a required
parameter.
 2016-12-08 11:34:05 -05:00
Kamil Szczygieł
26fe35fd0c VMware datacenter module shouldn't hold pyvmomi context in Ansible module object (#1568) 
* VMware datacenter module rewritten to don't hold pyvmomi context and objects in Ansible module object

fixed exceptions handling

added datacenter destroy result, moved checks

changed wrong value

wrong value again... need some sleep

* check_mode fixes

* state defaults to present, default changed to true

* module check fixes
 2016-12-08 11:34:04 -05:00
Michael Scherer
e986aad9aa Remove dead code (#1303) 
The review on https://github.com/ansible/ansible-modules-extras/pull/1303
show the problem was already fixed, so we just need to remove the
code.
 2016-12-08 11:34:04 -05:00
stoned
6a77e62df4 cpanm: search both its stderr and its stdout for the message 'is up t… 
Note that since cpanm version 1.6926 its messages are sent to stdout
when previously they were sent to stderr.

Also there is no need to initialize out_cpanm and err_cpanm and
check for their truthiness as module.run_command() and str.find()
take care of that.
 2016-12-08 11:34:04 -05:00
Evgeni Golov
ab07c9c7e8 do not set LXC default config 
this was accidentally re-introduced in 7120fb4b

Signed-off-by: Evgeni Golov <evgeni@golov.de>
 2016-12-08 11:34:04 -05:00
Ricardo Carrillo Cruz
079a7dc490 Add os_user_facts module 
This module gather facts about one or more OpenStack users
 2016-12-08 11:34:04 -05:00
Ricardo Carrillo Cruz
aba0597e45 Add os_keystone_domain_facts module 
This module gathers one or more OpenStack domains facts
 2016-12-08 11:34:04 -05:00
Matt Hite
a0b483746e Fixes issue #1992 -- fixes issue adding and deleting pools (#1994) 2016-12-08 11:34:04 -05:00
Michael Scherer
7a704ac600 Auth_toekn is a secret, shouldn't be logged (#1999) 2016-12-08 11:34:04 -05:00
Joerg Fiedler
518b03d73f add chroot flag to pkgng in order to allow installation of packages into chroot environments, e.g. jails (#1218) 2016-12-08 11:34:04 -05:00
Him You Ten
87ce503767 added stdout and stderr outputs (#1900) 
* added stdout and stderr outputs

Added stdout and stderr outputs of the results from composer as the current msg output strips \n so very hard to read when debugging

* using stdout for fail_json

using stdout for fail_json so we get the stdout_lines array
 2016-12-08 11:34:04 -05:00
Matt Hite
d2d4001dc5 New preserve_node parameter to skip unreferenced node removal 2016-12-08 11:34:04 -05:00
kubilus1
bcfab26d78 Unchecked index causes IndexError. 2016-12-08 11:34:04 -05:00
Jasper Lievisse Adriaanse
3a319b9a84 support for 'update_cache' in pkgin module 2016-12-08 11:34:04 -05:00
Michael Scherer
971b570b67 Do not leak passwords in case of error in cloudstack modules 2016-12-08 11:34:04 -05:00
Jonathan Mainguy
4b948af706 Enable stdout and stderr on sucessful runs, making show_diff useable 
omit color symbols as ansible makes them illegible
 2016-12-08 11:34:04 -05:00
Brian Beggs
75b172c706 hipchat api v2 rooms are now url escaped 2016-12-08 11:34:04 -05:00
Aaron Brady
7e1a538b93 Add to_destination parameter 2016-12-08 11:34:04 -05:00
Vlad Gusev
317fe95be0 system/puppet: add --tags parameter (#1916) 
* system/puppet: add --tags parameter

--tags [1] is used to apply a part of the node’s catalog.

In puppet:
puppet agent --tags update,monitoring

In ansible:
puppet: tags=update,monitoring

[1] https://docs.puppetlabs.com/puppet/latest/reference/lang_tags.html#restricting-catalog-runs

* Add example of tag usage.

* system/puppet: add list type for a tags dict.
 2016-12-08 11:34:03 -05:00
Michael Scherer
817335ae0d Client_secret is supposed to be kept secret, so mark it as no_log (#1995) 2016-12-08 11:34:03 -05:00
nitzmahone
bd3172b2e8 win_updates fix to use documented InstanceGuid property name 2016-12-08 11:34:03 -05:00
nitzmahone
e20eac089f win_updates shouldn't install hidden updates 2016-12-08 11:34:03 -05:00
Michael Scherer
e7e1a8bfea Avoid token leak by marking it as sensitive with no_log (#1966) 2016-12-08 11:34:03 -05:00
Michael Scherer
ed69d8335e Properly label path argument with type='path' (#1940) 2016-12-08 11:34:03 -05:00
Michael Scherer
b8706a1f95 Do not leak mail password by error 2016-12-08 11:34:03 -05:00
Michael Scherer
0dd3296ddd Mark password as 'no_log', to avoid leaking it 2016-12-08 11:34:03 -05:00
Rob
b93fda8573 Updated Amazon module guidelines regarding boto3 
* Updated Amazon module guidelines regarding boto3

* Spelling correction
 2016-12-08 11:34:03 -05:00
Andy Baker
c0d281e290 type should be 'list' not the default of 'string' 2016-12-08 11:34:03 -05:00
Evgeni Golov
1847f19e41 don't create world-readable archives of LXC containers 
with the default umask tar will create a world-readable archive of the

container, which may contain sensitive data

Signed-off-by: Evgeni Golov <evgeni@golov.de>
 2016-12-08 11:34:03 -05:00
Michael Scherer
3b79c1621b Prevent password leaks in notification/irc 2016-12-08 11:34:03 -05:00
Michael Scherer
67b2623e92 Use no_log=True for campfire module to avoid leaks 2016-12-08 11:34:03 -05:00
Michael Scherer
f2bf444395 Set no log for jabber.py password 2016-12-08 11:34:03 -05:00
Evgeni Golov
16b2d85d34 do not use a predictable filenames in the LXC plugin 
* do not use a predictable filename for the LXC attach script

* don't use predictable filenames for LXC attach script logging

* don't set a predictable archive_path

this should prevent symlink attacks which could result in

* data corruption

* data leakage

* privilege escalation
 2016-12-08 11:34:03 -05:00
Michael Scherer
f47a756c46 Add proper type to cpanm arguments 
from_path, locallib, executable should be path to benefits
from path expansion for ~user.
 2016-12-08 11:34:03 -05:00
Chulki Lee
432a9a31ca osx_defaults: fix datetime 
Fix #1742
 2016-12-08 11:34:02 -05:00
Matt Martz
c8bd27f1e8 Rebase PRs against $TRAVIS_BRANCH before performing tests 2016-12-08 11:34:02 -05:00
mo@oclab.net
20fd04b9e7 firewalld: fixes documentation 
- removes warning, aligning to existing documentation
- adds version
 2016-12-08 11:34:02 -05:00
mo@oclab.net
8b2d484032 firewalld: add/remove interfaces to/from zones 2016-12-08 11:34:02 -05:00
David Hocky
aabd6390d4 fix dscp marking documentation in iptables module 2016-12-08 11:34:02 -05:00
Evgeni Golov
88d8820f1b explicitly set "default: null" in the docs 2016-12-08 11:34:02 -05:00
Evgeni Golov
e1846d2e4b do not set a default config for lxc containers 
otherwise deploying user-containers fail as these require information
from ~/.config/lxc/default.conf that the LXC tools will load if no
--config was supplied

Signed-off-by: Evgeni Golov <evgeni@golov.de>
 2016-12-08 11:34:02 -05:00
Chris Porter
2b8b04638d fix security vulnerability in lxc module 
octal/decimal confusion makes file world-writable before executing it
 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
e3d8facc7f fixxed tests 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
c82d72e12a fixed problems related to userpricincipalname (user@domain) and undefined variables fixed variable capitalization 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
186197397c fixxed problem with match @ 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
9ba30d2cea only call set-acl if necessary 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
700ca56c61 as suggested by @marcind, convert to boolean 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
404483ea83 fixed documentation 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
de4a271dd0 added userprincipal support 2016-12-08 11:34:02 -05:00
Hans-Joachim Kliemeck
65d5658553 added separate module to change owner, since win_acl is ACL only and should not be more complex 2016-12-08 11:34:02 -05:00
Marcos Diez
1aec0a3ffb mongodb_user.py: changes on comments 2016-12-08 11:34:01 -05:00
Marcos Diez
37ba9a3fe1 mongodb_user: fix checking if the roles of an oplog reader user changed 2016-12-08 11:34:01 -05:00
Guillaume Dufour
dc83f2c6d7 use python fallback to avoid error on old mongo version without roles 2016-12-08 11:34:01 -05:00
Guillaume Dufour
467d9a8090 avoid problem with old mongo version without roles 2016-12-08 11:34:01 -05:00
Guillaume Dufour
b07e1c13f7 fix #1731 : mongodb_user always says changed 2016-12-08 11:34:01 -05:00
John Barker
d20b7ee6e6 restore version_added in dynamodb_table.py 2016-12-08 11:34:01 -05:00
Matt Hite
846a538648 Allow port 0 as a valid pool member port 2016-12-08 11:34:01 -05:00
Jason Witkowski
48931065e5 The current module supporting F5 BIGIP pool creation does not support a setup where the port number must be zero to signify the pool will listen on multiple ports. This change implements that functionality and fixes an illogical conditional. 2016-12-08 11:34:01 -05:00
Michael Scherer
a21ab5b990 Use type='path' for reposdir, since that's a path 2016-12-08 11:34:01 -05:00
Rene Moser
051b11b983 openstack: doc: add return doc, fixes build 2016-12-08 11:34:01 -05:00
Paul Seiffert
48223fd268 Allow Datadog metric alerts to define multiple thresholds 2016-12-08 11:34:01 -05:00
David Shrewsbury
33d3616bab Add OpenStack os_user_role module 2016-12-08 11:34:01 -05:00
Michael Scherer
dc94ce72c7 Use boolean instead of "yes" + choice for most option 
This enable a more standard behavior with others modules
 2016-12-08 11:34:01 -05:00
Michael Scherer
2a0c9bb3a2 Use type 'path' for rootdir, for pkgng 2016-12-08 11:34:01 -05:00
Michael Gruener
bdeb5af740 cloudflare_dns: Cosmetic cleanup 2016-12-08 11:34:01 -05:00
Michael Gruener
90503c9f2a cloudflare_dns: normalize return value and docs 2016-12-08 11:34:00 -05:00
Michael Gruener
95f270089b cloudflare_dns: Cleanup record update handling 2016-12-08 11:34:00 -05:00
Michael Gruener
78640328cb cloudflare_dns: Allow CNAME content updates 2016-12-08 11:34:00 -05:00
Michael Gruener
41ed47d66e cloudflare_dns: Fix solo SRV record creation 2016-12-08 11:34:00 -05:00
Michael Gruener
85d41db922 cloudflare_dns: Fix SRV record idempotency 2016-12-08 11:34:00 -05:00
Pavel Sychev
594c9ff217 Added version restriction for uid_owner and reject_with. 2016-12-08 11:34:00 -05:00
Pavel Sychev
0c888bd19f Added docs for reject_with and uid_owner. 2016-12-08 11:34:00 -05:00
Pavel Sychev
30bd75e3ae Added reject_with and uid_owner support. 2016-12-08 11:34:00 -05:00
Julien Recurt
5d68e4fe06 Add option to use ZabbixApi via auth basic protection 2016-12-08 11:34:00 -05:00
Linus Unnebäck
5f9d5c1403 make: move down ansible import 2016-12-08 11:34:00 -05:00
Linus Unnebäck
e79e024016 make: add empty return docs 2016-12-08 11:34:00 -05:00
Linus Unnebäck
d605860b39 module: system/make 2016-12-08 11:34:00 -05:00
Tyler Cross
c84bd72496 Add note server 2012 note to win_scheduled_task. 
This change adds a note to the win_scheduled_task module
docs that indicates Windows Server 2012 or later is required.
This is because the module relies on the Get-ScheduledTask
cmdlet, which is a part of the Server 2012 OS. Previous
versions, like Server 2008, simply can't work with this
module.
 2016-12-08 11:34:00 -05:00
Brian Coca
0ebabc50e4 change name to be a list type 
remove implicit split that expects a , separated string, let list type
deal with multiple possible compatible input types.
also removed unused imports
 2016-12-08 11:34:00 -05:00
David Shrewsbury
2dddfbe67c Add shade version check to os_flavor_facts 
The range_search() API was added to the shade library in version
1.5.0 so let's check for that and let the user know they need to
upgrade if they try to use it.
 2016-12-08 11:34:00 -05:00
Chris Tooley
b2c7d28f41 Modify consul certificate validation bypass keyword from 'verify' to 'validate_certs' 2016-12-08 11:34:00 -05:00
Chris Tooley
ca1efafc50 Add version_added to documentation 2016-12-08 11:33:59 -05:00
Chris Tooley
6c41d9cd38 Add https support for consul clustering modules 2016-12-08 11:33:59 -05:00
Brian Coca
41af347d8d renamed sl to sl_vm and updated docs 
namespace for softlayer modules should now be sl_
 2016-12-08 11:33:59 -05:00
Matt Colton
8f444b8c4b Added Softlayer Module 2016-12-08 11:33:59 -05:00
Dag Wieers
67222d9b5b Update the issue and pull-request templates in sync with ansible/ansible 2016-12-08 11:33:59 -05:00
Julia Kreger
011267c04e Add os_ironic_inspect module 
Addition of an os_ironic_inspect module to leverage the OpenStack
Baremetal inspector add-on to ironic or ironic driver out-of-band
hardware introspection, if supported and configured.
 2016-12-08 11:33:59 -05:00
James Slagle
b7ef068d3e Add quotes and equals for set option documentation 
set is an option for the openvswitch_port module, however the documentation
example omitted the equals sign and quotes around the option value.
 2016-12-08 11:33:59 -05:00
Matthew Gamble
b58eaca7e8 Remove dead code from pacman module 
The manual check to see if get_bin_path() returned anything is
redundant, because we pass True to the required parameter of
get_bin_path(). This automatically causes the task to fail if the pacman
binary isn't available. Therefore, the code within the if statement
being removed is never called.
 2016-12-08 11:33:59 -05:00
Guillaume Dufour
8227105f02 fix #1747 mongodb_user support check mode 2016-12-08 11:33:59 -05:00
Ricardo Carrillo Cruz
ba3515bc30 Allow passing domain name on os_project 2016-12-08 11:33:59 -05:00
Rene Moser
7a28ad63f7 dynamodb_table: doc fix 2016-12-08 11:33:59 -05:00
Matt Ferrante
99c8e82b60 dynamo db indexes 2016-12-08 11:33:59 -05:00
Michael Scherer
eefd716e8c Add better type checking for elasticsearch_plugin 2016-12-08 11:33:59 -05:00
Michael Scherer
4c63a958e5 Use no_log for the password for maven_artifact module 2016-12-08 11:33:59 -05:00
Michael Scherer
9f90c2355f Add the proper type for the various path argument 2016-12-08 11:33:59 -05:00
Casey Lucas
4cd9933388 fix edge case where boto returns empty list after subnet creation 2016-12-08 11:33:59 -05:00
Michael Gruener
1d0ae2f4ed cloudflare_dns: Fix wrong variable name 2016-12-08 11:33:58 -05:00
Emilien Macchi
1c94395a96 system/puppet: allow to run puppet -e 
-e or --execute [1] allows to execute a specific piece of Puppet code
such a class.

For example, in puppet you would run:
puppet apply -e 'include ::mymodule'

Will be in ansible:
puppet: execute='include ::mymodule'

[1] http://docs.puppetlabs.com/puppet/latest/reference/man/apply.html#OPTIONS
 2016-12-08 11:33:58 -05:00
Andrea Scarpino
45a32137ad win_unzip: Use absolute path for src and dest 
win_unzip fails to extract files when either src or dest contains
complex paths such as "..\..\" or "C:\\Program Files" (double slashes).
Fix this by fetching absolute path of both before invoking CopyHere
method.
 2016-12-08 11:33:58 -05:00
jhawkesworth@users.noreply.github.com
d2fe2287f9 Added return documentation to win_regmerge module 2016-12-08 11:33:58 -05:00
Michael Scherer
184d9fc4e5 Fix type used by the module 
Set int for the various port (and so avoid to convert them later)
Set no_log=True for the login_password
Verify that db is a int, so avoid a conversion
 2016-12-08 11:33:58 -05:00
Michael Scherer
8abe22c917 Fix ssl to be a bool, required to fix #1732 
May also fix #1869
 2016-12-08 11:33:58 -05:00
Michael Scherer
1a05e0f1c8 Use proper type for riak config_dir argument 2016-12-08 11:33:58 -05:00
Michael Scherer
49aa069c94 Add proper type to path and link 
Since both of them are path, it should be checked using the
proper type.
 2016-12-08 11:33:58 -05:00
Michael Scherer
2760c2ded0 Reindent with_items, fix #1849 2016-12-08 11:33:58 -05:00
Dennis Conrad
0254cbad9a Fix for existing ENIs w/ multiple security groups 
Do a sorted comparison of the list of security groups supplied via `module.params.get('security_groups')` and the list of security groups fetched via `get_sec_group_list(eni.groups)`.  This fixes an incorrect "The specified address is already in use" error if the order of security groups in those lists differ.
 2016-12-08 11:33:58 -05:00
Andrea Scarpino
f56c557a93 Fix issue #1406 about win_firewall_rule 
I changed the logic here to always use 'netsh ... show rule' keywords as keys for $fwsettings map. While the translation (e.g. Enabled -> enable) is performed when invoking 'netsh ... add rule' command.

I tested rule creation and rule creation when the rule was already existing on Windows Server 2012.
 2016-12-08 11:33:58 -05:00
Andrea Scarpino
e16bd19401 win_unzip: overwrite any existing file 2016-12-08 11:33:58 -05:00
Rob White
7b0b4262e5 Allow SNS topics to be created without subscriptions. Also added better error handling around boto calls. 2016-12-08 11:33:58 -05:00
Fernando J Pando
be083a8fbe author added 2016-12-08 11:33:58 -05:00
Fernando J Pando
6d69956f83 Fix SNS topic attribute typo 
Enables adding SNS topic policy. 'Policy' attribute is capitalized.
 2016-12-08 11:33:58 -05:00
Joel Thompson
61672e5c61 Ensure ec2_win_password doesn't leak file handle 
Currently the module doesn't explicitly close the file handle. This
wraps the reading of the private key in a try/finally block to ensure
the file is properly closed.
 2016-12-08 11:33:58 -05:00
Rene Moser
b92b30e3b3 ec2_vpc_dhcp_options: doc fix, add version_added to new args 
See #1640
 2016-12-08 11:33:58 -05:00
Andy Nelson
5718a5caac Updated ec2_vpc_dhcp_options 2016-12-08 11:33:57 -05:00
Justin Good
f85f575a58 Add support for recursive znode deletion 2016-12-08 11:33:57 -05:00
James Moore
0ecaea3ac1 Added a source parameter for setting the JIT client name 2016-12-08 11:33:57 -05:00
Darek Kaczyński
9e918b5955 Removed debug return values 2016-12-08 11:33:57 -05:00
Darek Kaczyński
7127a45d96 ecs_service will now compare whole model and update it if any difference found. Documentation #1483. Workaround for datetime fileds #1348. 2016-12-08 11:33:57 -05:00
Darek Kaczyński
9b27ed6c5d ecs_service_facts documentation fixes #1483. Workaround for datetime fileds #1348. 2016-12-08 11:33:57 -05:00
Nate Smith
b820017ed0 Allow numeric npm package versions 
When passing a package version that parses as a number (e.g. `1.9`), the version should be converted to a string before being concatenated to the package name.
 2016-12-08 11:33:57 -05:00
Ritesh Khadgaray
d8ea847739 zabbix_host : add the ability to set inventory_mode 2016-12-08 11:33:57 -05:00
Rene Moser
427ab2f016 osx_defaults: doc fix, add version_added for host agrument 
See #1364
 2016-12-08 11:33:57 -05:00
Greg Hurrell
a58a91410d osx_defaults: add "host" attribute 
This allows us to configure defaults using the `-currentHost` or `-host`
arguments to the `defaults` executable.
 2016-12-08 11:33:57 -05:00
Alex Kalinin
e97ca89953 Fix vmware_portgroup throwing an error if port group already exists 2016-12-08 11:33:57 -05:00
t.goto
8a3c60cfd2 add exit_json 
add exit_json code to succesfully exit, when you want to delete the already
deleted host.
Without this, playbook fails with
`Specify at least one group for creating host`
which is not correct message.
 2016-12-08 11:33:57 -05:00
t.goto
b03d1da393 change host.delete() parameter for newer ZBX api. 
As of Zabbix API 2.4, host.delete() will not takes parameter with
`hostid` property but only the array of it.
https://www.zabbix.com/documentation/2.2/manual/api/reference/host/delete

fix #1800
 2016-12-08 11:33:57 -05:00
nonshankus
30d76cd37c Fixing win_updates example for listing available updates. 2016-12-08 11:33:57 -05:00
Rene Moser
2430e295a6 lvol: remove unused import 
See #1425
 2016-12-08 11:33:57 -05:00
Jonas Vermeulen
2149a7b1f6 Added resizing based on %values. Included support for VG|PVS|FREE 2016-12-08 11:33:57 -05:00
lsb
2095aa5100 Update mongodb_user.py 
Typo
 2016-12-08 11:33:56 -05:00
Rene Moser
39ece09e86 cloudflare_dns: minor code improvments 
Tweaked some things on top of the well done PR #1768

- json import
- fix expetion handling
- fix indentation
 2016-12-08 11:33:56 -05:00
Michael Gruener
68fc8e75f6 Module to manage Cloudflare DNS records 2016-12-08 11:33:56 -05:00
Toshio Kuratomi
5b84102a15 Doc fixes 2016-12-08 11:33:56 -05:00
Michael Scherer
61bdf9ee0f Fix #1809, use the proper method to fail 2016-12-08 11:33:56 -05:00
Matt Clay
9c883f689d Add optional mysql connect timeout. 2016-12-08 11:33:56 -05:00
Gabriel Burkholder
6a202054f8 Fixes route53_facts to use max_items parameter with record_sets query. 2016-12-08 11:33:56 -05:00
nonshankus
a1fdff4c97 Adding missing attributes regarding the hosted zone. 2016-12-08 11:33:56 -05:00
Emilien Macchi
f0f1d1edc4 system/puppet: add --certname parameter 
certname [1] can be a useful parameter when we need to specify a
certificate name different from the default value [2] in Puppet.

Ex: the hosts have different names, in advanced network isolation
setups.

Also, it can be used when we want to run Puppet with a specific node
definition and not using hostname or fqdn to match the nodes where we want to
run Puppet [3] (not recommended by Puppetlabs though).

[1] https://docs.puppetlabs.com/puppet/latest/reference/configuration.html#certname
[2] Defaults to the node’s fully qualified domain name
[3] http://docs.puppetlabs.com/puppet/latest/reference/lang_node_definitions.html#naming
 2016-12-08 11:33:56 -05:00
saez0pub
029b608e1e Prevent reinstallation in case of group package 2016-12-08 11:33:56 -05:00
Miguel Martín
da668dca56 Replace deprecated zabbix api method 'exists' to support zabbix 3.0 2016-12-08 11:33:56 -05:00
David Shrewsbury
cd2c7deec4 Add os_group.py OpenStack module 
Allows an admin (or privileged user) to manage Keystone v3
groups.
 2016-12-08 11:33:56 -05:00
David Shrewsbury
e25c04aeb0 Add new os_flavor_facts.py module 
New module to retrieve facts about existing instance flavors.
By default, facts on all available flavors will be returned.
This can be narrowed by naming a flavor or specifying criteria
about flavor RAM or VCPUs.
 2016-12-08 11:33:56 -05:00
David Shrewsbury
b697d986c1 Add new os_keystone_role module. 
This new module allows for creating and deleting Keystone
roles.
 2016-12-08 11:33:56 -05:00
Doug Luce
030fbaef64 Use os module for checking absolute/joining paths 2016-12-08 11:33:55 -05:00
Doug Luce
d4275e576e cronvar.py: support absolute destinations 
Mainly so /etc/crontab can be written to.
 2016-12-08 11:33:55 -05:00
Rene Moser
c00688a118 iptables: add defaults to docs 2016-12-08 11:33:55 -05:00
David Hocky
4abd217aa5 add version added to new params 2016-12-08 11:33:55 -05:00
David Hocky
a3b7dbe1df fix doc issue 2016-12-08 11:33:55 -05:00
David Hocky
994edea253 add support for setting dscp marks with iptables module 2016-12-08 11:33:55 -05:00
liquidat
7abe6b0e8c correct win_firewall state parameter 
- original parameter comment was probably copy&paste error
- new comment highlights that firewall rules can be
  added or removed altering this parameter
 2016-12-08 11:33:55 -05:00
Toshio Kuratomi
32ff89b30e Fix module docs 2016-12-08 11:33:55 -05:00
Rene Moser
fd68e66827 cloudstack: new module cs_zone_facts 2016-12-08 11:33:55 -05:00
Michael Scherer
4589b67a44 Remove unused variables 
Session_id is unused in update_session, changed is always specifically
set in all exit_json call, and consul_client.session.destroy return True
or False, and is unused later (nor checked)
 2016-12-08 11:33:55 -05:00
Michael Scherer
fabd619070 Rename consul variable to consul_client 
Since the module is also named consul, pyflakes emit a warning
about it since the variable shadow the module.
 2016-12-08 11:33:55 -05:00
Michael Scherer
78571c053b Pyflakes complain about unused import, so remove it 2016-12-08 11:33:55 -05:00
Michael Scherer
334bfbd465 Add a datacenter parameter, fix #1693 2016-12-08 11:33:55 -05:00
Eike Frost
b8b2613c35 Replace deprecated exists API for Zabbix 3.0 compatibility 2016-12-08 11:33:55 -05:00
Calvin Walton
f623057e0e zabbix_maintenance: Stop using api removed in zabbix 3.0 2016-12-08 11:33:55 -05:00
Ricky Cook
4a9daf6bae New json_fail syntax for dnsimple module 2016-12-08 11:33:55 -05:00
yta
0446231380 osx_defaults: Do not make any changes in check mode 2016-12-08 11:33:55 -05:00
Ritesh Khadgaray
06d2682b08 Fix test failure for lxc_container 
TRACE:
    while parsing a block mapping
      in "<string>", line 33, column 13:
                    description: resulting state of  ...
                    ^
    expected <block end>, but found ','
      in "lxc_container.RETURN", line 419, column 53:
         ... "/tmp/test-container-config.tar",

ERROR: RETURN is not valid YAML. Line 419 column 53
 2016-12-08 11:33:54 -05:00
Brian Coca
bb355e6ccd add container name to return and document return 
fixes #1848
 2016-12-08 11:33:54 -05:00
mxpt user
0798bfe2dc Fixing typo in bigip_monitors Correcting set_template_int_property to set_template_integer_property 2016-12-08 11:33:54 -05:00
nitzmahone
2afecc7198 fix version_added issues in win_iis_website 2016-12-08 11:33:54 -05:00
nitzmahone
2e4cb9c651 added doc note to win_iis_website site_id arg 2016-12-08 11:33:54 -05:00
Corwin Brown
659c1078ba Updated Documentation to include site_id param 2016-12-08 11:33:54 -05:00
Corwin Brown
2c9512aece Adding Site_ID param 2016-12-08 11:33:54 -05:00
Brian Coca
864bf4e19e added new puppet path to bin search 
fixes #1835
 2016-12-08 11:33:54 -05:00
Brian Coca
b1281319c1 updated to match core module forms 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
bb27e38578 corrected replacement of last backslash 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
cd0e97dc77 corrected requirements 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
5f9eaf193e fixxed problems related to path input 2016-12-08 11:33:54 -05:00
Hans-Joachim Kliemeck
0d01a36dd9 first implementation of win_share module 2016-12-08 11:33:54 -05:00
Marcin Dobosz
6f68db5c1a Fix win_iis_webapppool module to not null ref when removing an apppool using PS4 2016-12-08 11:33:54 -05:00
nitzmahone
092c3ccbde fix default arg handling and error messages in win_file_version 2016-12-08 11:33:54 -05:00
nitzmahone
db58300aa7 fix missing bracket in win_file_version 2016-12-08 11:33:54 -05:00
Sam Liu
a077c4bc9d fix some error for passing CI build. 2016-12-08 11:33:53 -05:00
Sam Liu
b174416895 Fixed: exception swallowing 2016-12-08 11:33:53 -05:00
Sam Liu
d5fe7633e2 new module win_file_version 2016-12-08 11:33:53 -05:00
liquidat
87bc5fcb24 remove legacy action style from examples 
- "action" style invoking is a legacy way to call modules
- the examples were updated to the typical style of calling complex
  modules:

ovirt:
  parameter1: value1
  parameter2: value2
  ...
 2016-12-08 11:33:53 -05:00
Matt Martz
019a944fb3 Catch errors related to insufficient (old) versions of pexpect. Fixes #13660 2016-12-08 11:33:53 -05:00
Will Keeling
876fe06290 Better handling of package groups in pacman module 2016-12-08 11:33:53 -05:00
Jonathan Mainguy
ac8b171da4 fixes bug where puppet fails if logdest is not specified 2016-12-08 11:33:53 -05:00
Toshio Kuratomi
c602d49d42 Fail due to no dnf module installed earlier as we use a dnf utility function to determine if we have permission to install packages. 2016-12-08 11:33:53 -05:00
Jiri Tyr
bb194b03bc Removing parameter from yum_repository module 2016-12-08 11:33:53 -05:00
Jiri Tyr
709ae10207 Adding more options to the yum_repository module 2016-12-08 11:33:53 -05:00
Eike Frost
85f6bb4d8e Check whether interface-list exits before querying its length 2016-12-08 11:33:53 -05:00
Ricardo Carrillo Cruz
9fea94b5bf Fix instantiation of openstack_cloud object in os_project 
The os_project module instantiates the openstack cloud object
by passing the module params kwargs.
As the params contain a key named 'domain_id', this is used
for domain in the OpenStack connection, instead of the domain value
the user specifies on the OSCC clouds.yaml or OpenStack envvars.
This fix corrects this by popping the 'domain_id' key, so it we
keep the value but it's not passed later on module.params.
 2016-12-08 11:33:53 -05:00
Darek Kaczyński
17a6cea512 ecs_task module documentation fixes 2016-12-08 11:33:53 -05:00
Joseph Callen
773db55233 Resolves issue with vmware_migrate_vmk module for v2.0 
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_migrate_vmk module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
- name: Migrate Management vmk
      local_action:
        module: vmware_migrate_vmk
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        esxi_hostname: "{{ hostvars[item].hostname }}"
        device: vmk1
        current_switch_name: temp_vswitch
        current_portgroup_name: esx-mgmt
        migrate_switch_name: dvSwitch
        migrate_portgroup_name: Management
      with_items: groups['foundation_esxi']
```

Module Testing
```
TASK [Migrate Management vmk] **************************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/migrate_vmk.yml:3
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252 )" )
localhost PUT /tmp/tmpdlhr6t TO /root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695485.85-245405603184252/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168 )" )
localhost PUT /tmp/tmpqfZqh1 TO /root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695490.35-143738865490168/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882 )" )
localhost PUT /tmp/tmpf3rKZq TO /root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/vmware_migrate_vmk
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/vmware_migrate_vmk; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695491.96-124154332968882/" > /dev/null 2>&1
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp001", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-01"}
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp002", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-02"}
ok: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": false, "invocation": {"module_args": {"current_portgroup_name": "esx-mgmt", "current_switch_name": "temp_vswitch", "device": "vmk1", "esxi_hostname": "cscesxtmp003", "hostname": "172.27.0.100", "migrate_portgroup_name": "Management", "migrate_switch_name": "dvSwitch", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root"}, "module_name": "vmware_migrate_vmk"}, "item": "foundation-esxi-03"}
```
 2016-12-08 11:33:53 -05:00
Joseph Callen
eece1346ab missing doc fragment 2016-12-08 11:33:53 -05:00
Joseph Callen
3721a4647c Resolves issue with vmware_vm_vss_dvs_migrate module for v2.0 
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_vm_vss_dvs_migrate module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
- name: Migrate VCSA to vDS
      local_action:
        module: vmware_vm_vss_dvs_migrate
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        vm_name: "{{ hostname }}"
        dvportgroup_name: Management
```

Module Testing
```
ASK [Migrate VCSA to vDS] *****************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:260
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859 )" )
localhost PUT /tmp/tmpkzD4pF TO /root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/vmware_vm_vss_dvs_migrate
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/vmware_vm_vss_dvs_migrate; rm -rf "/root/.ansible/tmp/ansible-tmp-1454695546.3-207189190861859/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => {"changed": true, "invocation": {"module_args": {"dvportgroup_name": "Management", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "username": "root", "vm_name": "cscvcatmp001"}, "module_name": "vmware_vm_vss_dvs_migrate"}, "result": null}

```
 2016-12-08 11:33:53 -05:00
Joseph Callen
cef9e42896 Resolves issue with vmware_host module for v2.0 
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_host module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
    - name: Add Host
      local_action:
        module: vmware_host
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        datacenter_name: "{{ mgmt_vdc }}"
        cluster_name: "{{ mgmt_cluster }}"
        esxi_hostname: "{{ hostvars[item].hostname }}"
        esxi_username: "{{ esxi_username }}"
        esxi_password: "{{ site_passwd }}"
        state: present
      with_items: groups['foundation_esxi']
```

Module Testing
```
TASK [Add Host] ****************************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:214
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937 )" )
localhost PUT /tmp/tmppmr9i9 TO /root/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937/vmware_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937/vmware_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693866.1-87710459703937/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834 )" )
localhost PUT /tmp/tmpVB81f2 TO /root/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834/vmware_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834/vmware_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693943.8-75870536677834/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563 )" )
localhost PUT /tmp/tmpFB7VQB TO /root/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563/vmware_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563/vmware_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454693991.56-163414752982563/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "esxi_hostname": "cscesxtmp001", "esxi_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "esxi_username": "root", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_host"}, "item": "foundation-esxi-01", "result": "'vim.HostSystem:host-15'"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "esxi_hostname": "cscesxtmp002", "esxi_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "esxi_username": "root", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_host"}, "item": "foundation-esxi-02", "result": "'vim.HostSystem:host-20'"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": true, "invocation": {"module_args": {"cluster_name": "Foundation", "datacenter_name": "Test-Lab", "esxi_hostname": "cscesxtmp003", "esxi_password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "esxi_username": "root", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "username": "root"}, "module_name": "vmware_host"}, "item": "foundation-esxi-03", "result": "'vim.HostSystem:host-21'"}

```
 2016-12-08 11:33:53 -05:00