Commit graph

47985 commits

Author SHA1 Message Date
Toshio Kuratomi
4cad7e479c
Galaxy publish fix (#63580)
* Handle galaxy v2/v3 API diffs for artifact publish response

For publishing a collection artifact
(POST /v3/collections/artifacts/), the response
format is different between v2 and v3.

For v2 galaxy, the 'task' url returned is
a full url with scheme:

        {"task": "https://galaxy-dev.ansible.com/api/v2/collection-imports/35573/"}

For v3 galaxy, the task url is relative:

        {"task": "/api/automation-hub/v3/imports/collections/838d1308-a8f4-402c-95cb-7823f3806cd8/"}

So check which API we are using and update the task url approriately.

* Use full url for all wait_for_import messages

Update unit tests to parameterize the expected
responses and urls.

* update explanatory comment

* Rename n_url to full_url.

* Fix issue with overwrite of the complete path

* Fixes overwrite of the complete path in case there's extra path stored
  in self.api_sever
* Normalizes the input to the wait_import_task function so it receives
  the same value on both v2 and v3

Builds on #63523

* Update unittests for new call signature

* Add changelog for ansible-galaxy publish API fixes.
2019-10-16 15:23:12 -07:00
Matt Martz
82ee341fe0
Explicitly use multiprocessing fork start method (#63581)
* Explicitly use multiprocessing fork start method

* Remove unused import

* Remove unused import

* Fallback to just multiprocessing on py2
2019-10-16 15:30:50 -05:00
Pouyan Azari
f638f29e44 Replaced old DSC links that given 404 (#63556)
Replace DSC links that returned "not found" with updated, working links.
2019-10-16 12:52:30 -05:00
Prasad Katti
275b3972cb [lightsail] make delete operation idempotent (#63317)
Fixes #63315
2019-10-16 13:01:50 -04:00
Jan Meerkamp
94c23136be one_vm: moved to pyone added Persisten Deployment (#57393)
* moved to pyone added Persisten Deployment

Moved from python-oca to pyone.
Added Persistent deployment of VMs.

* Cleanup fixed missing whitespace

* cleanup whitesüace and indent

* corrected Versions and fixed disk count in error msg

* inc version

* wrong version for vm_start_on_hold

* added datastore for new instances

* added multiple Disks

* fixed missing info
2019-10-16 12:11:08 -04:00
Matt Clay
7448084858 Update default-test-container to 1.10.1.
This brings in the final Python 3.8.0 release instead of a release candidate.
2019-10-16 09:07:09 -07:00
GomathiselviS
6d7620b646 Added fix for bug 63290 (#63308) 2019-10-16 19:17:46 +05:30
benjdudas
88013e7159 generalized on_become prompt match for ios (#63528) 2019-10-16 19:13:57 +05:30
Andrey Klychkov
3a733cb0a1 postgresql_user: remove unused import (#63559) 2019-10-16 08:51:08 -04:00
Andreas Olsson
98b025239a nsupdate: Don't try fixing non-existing TXT values (#63408)
The commit 4e895c1 aimed to ensure that TXT record values were sanely
quoted. Sadly it failed to take the scenario of non-existing values
into account. While record values are required for record creation
they are not required for record deletion.

This change rectifies that oversight, saving Ansible from
unsuccessfully trying to operate on NoneType objects.

Resolves #63364
2019-10-16 17:58:41 +05:30
René Moser
332b220854 cloudscale: fix boilerplate (#63533) 2019-10-16 11:02:32 +02:00
Andrey Klychkov
c4ce4a6c03 mysql_variables: update MySQL in CI to 8.0 (#63454) 2019-10-16 08:30:33 +02:00
Matt Clay
d829a50a5b Fix use of deprecated function in xml module. 2019-10-15 15:29:11 -07:00
Matt Clay
32b57d57a0 Add constraint for pathspec.
This fixes installation of pathspec on Python 2.6.
2019-10-15 14:39:29 -07:00
Felix Fontein
4bc298af83 Fix return value documentation (2/2) (#63478)
* Fix return value documentation (2/2).
* Avoid validation errors for missing 'contains:'.
* Convert JSON text to JSON dict.
* example -> sample.
* Fix YAML.
2019-10-15 15:53:46 -05:00
Matt Clay
20be8693ba Revert "Remove top-level arguments from network modules (#62603)"
This reverts commit d5ac3f7e77.
2019-10-15 12:53:51 -07:00
houtd
e4eea0510c Fix warnings for ufw examples (#63505) 2019-10-15 11:55:45 -04:00
pando85
e0f67b58ce Fix doc - porting_guide_2.8 value example (#63493) 2019-10-15 10:50:10 -05:00
Nathaniel Case
d5ac3f7e77
Remove top-level arguments from network modules (#62603)
Eh, 2.10 is close enough

* drop top-level authorize

* Remove from documentation

* Remove load_params

* nxos_hsrp: I don't think this is an actual module parameter

* Move local params to provider

* Promote 'timeout' to a real parameter for eos_eapi

* Provider now always has auth_pass
2019-10-15 11:41:35 -04:00
Felix Fontein
6bea1597cc Fix return value documentation (1/2) (#63477)
* Fix return value documentation (1/2).
* Avoid validation errors for missing 'contains:'.
2019-10-15 10:03:08 -05:00
Martin Nečas
16e49fdd44 ovirt_vm add warning about next run configuration (#63458) 2019-10-15 09:42:32 -04:00
Andrey Klychkov
ecf71dd720 mysql_user: add seealso (#63497) 2019-10-15 10:48:13 +02:00
Jeff Gibson
e967060b9f Update unarchive.py - Further clarify extra_opts (#58102)
* Update unarchive.py - Further clarify extra_opts
Update the description in the options to help assist with what the module is looking for in the extra_opts.  #31873 alone is not enough since if you are not familiar with the option given in the example it may not be obvious that both elements are part of the same option instead of being two different options.

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-10-14 15:38:49 -05:00
Sam Doran
2b1e24fc49 package_facts - use AnsibleModule.warn() for warnings 2019-10-14 13:30:16 -07:00
Guillaume Martinez
7bb90999d3 Fix Gitlab module deprecation warning (#60425)
* gitlab modules : Fix deprecation warnings and parameters

Also preparing for 2.10 deprecation

* gitlab modules : Correct deprecation message
2019-10-14 15:58:21 -04:00
Sam Doran
e9d10f94b7
user - fix shadow file parsing on AIX (#62547)
Initialize variables in case the shadow file is not found.
Handle IndexErrors if something goes wrong with file parsing.
2019-10-14 15:44:22 -04:00
Matt Martz
d8389d9f55
Ensure we preserve the /api appended URL (#63472) 2019-10-14 13:34:07 -05:00
Niklas Beinghaus
da46800f1b Update 'delete' parameter description in synchronize module (#63450)
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-14 13:49:43 -04:00
Martin Nečas
0beab6bf69 ovirt update fetch_nested param doc (#63191) 2019-10-14 12:21:17 -04:00
Sam Doran
e9d29b1fe4 Properly mask no_log values is sub parameters during failure (#63405)
* Get no_log parameters from subspec

* Add changelog and unit tests

* Handle list of dicts in suboptions

Add fancy error message (this will probably haunt me)

* Update unit tests to test for list of dicts in suboptions

* Add integration tests

* Validate parameters in dict and list

In case it comes in as a string

* Make changes based on feedback, fix tests

* Simplify validators since we only need to validate dicts

Add test for suboptions passed in as strings to ensure they get validated properly and turned into a dictionary.

ci_complete

* Add a few more integration tests
2019-10-14 09:20:07 -07:00
Petr Ruzicka
876a2d57be Changed with_items to loop in VMware example (#63022) 2019-10-14 21:48:20 +05:30
flowerysong
ab249a469e ini_file: remove incorrect documentation (#63394) 2019-10-14 12:14:32 -04:00
Matt Martz
4c2b137728
Deprecate hash_behaviour (#63300)
* Deprecate hash_behaviour

* Fix wording
2019-10-14 10:35:11 -05:00
Nathaniel Case
ffe8f45ddd
Pickle non-str objects to survive connection return (#63110)
* Fail more helpfully when data is not str

* Pickle arbitrary objects to return from connection
2019-10-14 11:34:37 -04:00
sky-joker
11dc3a972f Fix example typo for vmware_host_facts module (#63434) 2019-10-14 11:14:50 -04:00
Amrita42
7a8c909876 Enter should be Italics as it is a menu option (#63441) 2019-10-14 11:04:05 -04:00
Xu Yuandong
36457bebc9 add a new module ce lacp to manage Eth-Trunk interfaces mode (#58077)
* add a new module to manage lacp

* add a new module to manage lacp

* add a new module to manage lacp

* add a new module to manage lacp

* add a new module to manage lacp

* update for shippable.

* update for shippable

* add units test to module ce_lacp.

* add units test to module ce_lacp.

* add units test to module ce_lacp.

* update

* update

* update

* update

* update

* update

* update for shippable.

* for shippable

* update ignore.txt to reslove conflict

* update for shippable

* update

* update unittest to remove provider.

* update unittest for shipppable.

* use to_native.

* intergration test

* syntax error

* syntax error

* syntax error

* update for `Andersson007` review and thanks.

* update for shippable
2019-10-14 15:14:43 +01:00
Martin Nečas
500f056b4e ovirt_vm correct graphical port (#63379) 2019-10-14 07:57:13 -04:00
Martin Nečas
2fe2a12440 ovirt_disk add state imported (#62859)
* ovirt_disk add state imported

* change search_by_name to get_id_by_name

* add disk_module.create as ret
2019-10-14 07:16:50 -04:00
Martin Nečas
aa0d4ef4ab ovirt_template remove unnecessary ret (#63382) 2019-10-14 07:16:34 -04:00
Andrey Klychkov
0ca682384d mysql_variables: add seealso, add return value (#63442) 2019-10-14 09:28:00 +01:00
Felix Fontein
d753168e9d
docker_node_info: improve error handling (#63418)
* Improve error handling for get_service_inspect().

* Add changelog fragment.
2019-10-13 14:16:02 +02:00
Felix Fontein
7f643690c7 docker modules: improve return value list documentation (#63145)
* Improve type documentation.

* Also improve return values.
2019-10-12 15:08:20 -04:00
zhongjun2
6170f3a6f6 Add route module (#60189)
* Add route module

* Update hwc_vpc_route.py

* Update hwc_vpc_route.py

* Update hwc_vpc_route.py

* Update main.yml

* Update hwc_vpc_route.py

* Update hwc_vpc_route.py

* Update hwc.py

* Update hwc_vpc_route.py
2019-10-12 18:15:02 +02:00
Felix Fontein
61b3784131 docker_image: fix option parameter so that warnings are issued (#63345)
* Fix option parameter so that warnings are issued.

* Add changelog.
2019-10-12 08:09:03 -04:00
yanzhangi
d4bbb8e2b8 Update ce_facts to fix bugs (#63331) 2019-10-11 21:11:22 -04:00
Felix Fontein
054285c34c crypto modules: improve return value list documentation (#62929)
* Improve return value documentation by allowing entry for return values.
* Add docs formatting, adjust styling.
* Fix sample return value. (Taken from https://tools.ietf.org/html/rfc7517#appendix-A.1.)
* Work around abuse of .
2019-10-11 13:59:15 -05:00
Sandra McCann
ae265bc546 Move galaxy appendix info to a new Galaxy section (#63356)
* start galaxy docs restructure
* shared snippets in txt files
* moved all content to galaxy section
2019-10-11 13:19:44 -05:00
Roman
504d76e956 acl: fix module failure if there're spaces in a path (#63280)
* Make acl module to work with whitespaces in path

* Added a changelog fragment

* Add quotes to changelog fragment
2019-10-11 10:40:19 -07:00
Benjamin Brabant
29939383e6 Improve ecs_ecr module to handle image_tag_mutability feature (#62871)
Since 2019 jul. 26, AWS Elastic Container Registry can be configured to be immutable that prevent overwritting of an existing tag in the registry.
https://aws.amazon.com/fr/about-aws/whats-new/2019/07/amazon-ecr-now-supports-immutable-image-tags/
https://docs.aws.amazon.com/AmazonECR/latest/userguide/image-tag-mutability.html

By default, ecr is created MUTABLE, as this was the only option before this feature.
This module leverage new capabilities of boto3 to configure image_tag_mutability option.
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ecr.html#ECR.Client.put_image_tag_mutability

The image_tag_mutability option definition was inspired by existing terraform module.
https://www.terraform.io/docs/providers/aws/r/ecr_repository.html
2019-10-11 09:13:13 -07:00