Commit graph

2721 commits

Author SHA1 Message Date
Michael Scherer
ea6567dbf7 fix incorrect send_data call. there is no client variable, and send_data
is a class method. Pyflakes complained about it.
2013-11-07 08:11:56 +01:00
Michael Scherer
eb77ca80df remove unused variable (pyflakes) 2013-11-07 08:11:56 +01:00
Michael Scherer
061394fff7 make pyflakes a bit more silent
- explictely import json, since this is used ( only to silence pyflakes)
- remove shutil as it is unused
2013-11-07 08:11:56 +01:00
James Tanner
ce29c158a9 Address #4573 Check interface keys and return gracefully on solaris zones 2013-11-06 18:11:22 -05:00
jctanner
31b5b66eb1 Merge pull request #4776 from jlaska/ec2_wait_on_terminate
Honor wait on ec2 instance termination
2013-11-06 12:02:00 -08:00
jctanner
15a9f7700f Merge pull request #4760 from urbanmapping/devel
make cloudformation module accept template_parameters from command line
2013-11-06 08:12:11 -08:00
jctanner
8b774f27c2 Merge pull request #4786 from SalesSeek/find-correct-easy-install
Fix determination of correct, possibly customized, 'easy_install' executable
2013-11-06 07:39:19 -08:00
jctanner
5eab293421 Merge pull request #4811 from dragon3/duplicate_download_s3file
Remove duplicate "download_s3file" execution when the destination path doesn't exist
2013-11-05 16:00:33 -08:00
James Tanner
65d68bb1b4 Addresses #4735 Verify the virtualenv command supports --no-site-packages before passing it 2013-11-05 18:51:41 -05:00
jctanner
9aa93fa307 Merge pull request #4735 from chrisalbright/patch-1
pip module: fix unexpected behavior when creating virtualenvs
2013-11-05 15:50:08 -08:00
jctanner
7dac397d1a Merge pull request #4797 from weaselkeeper/devel
fix for https://github.com/ansible/ansible/issues/4795 (incorrect changed result in cron module)
2013-11-05 12:25:54 -08:00
dragon3
e54832a730 Remove duplicate "download_s3file" execution when the destination path doesn't exist 2013-11-05 22:03:40 +09:00
willthames
723af8c370 Ensure async terminates when time limit is not divisible by 5
Because async_wrapper subtracts 5 from time_limit and checks for
equality to zero, values not divisible by 5 will go negative and
continue forever.
2013-11-05 09:42:28 +10:00
jctanner
8e105bbfba Merge pull request #4772 from mscherer/fix_4763
Try/finally is a python 2.5 construct, so not working on EL5. Fix #4763
2013-11-04 15:36:02 -08:00
James Tanner
c1ed47933b Fixes #4485 add an ipv6 parameter to accelerate so that the daemon will bind to an ipv6 port instead of ipv4 2013-11-04 17:20:03 -05:00
Jim Richardson
bbfe11fc1e return True/False from remove_job_file()
revised fix for https://github.com/ansible/ansible/issues/4795
2013-11-04 14:14:53 -08:00
James Tanner
5c34ed0827 Addresses #4676 Add module notes about the behavior of sudo and the destination paths within the synchronize module. 2013-11-04 12:19:31 -05:00
James Tanner
9fb4be0e73 Update synchronize docstrings for rsync_timeout parameter 2013-11-04 10:57:08 -05:00
James Tanner
0adf095677 Add a timeout to the synchronize module to prevent infinite hangs while waiting on passwords for misconfigured users 2013-11-04 10:52:44 -05:00
Jim Richardson
bcc08564e7 fix for https://github.com/ansible/ansible/issues/4795
Incorrect changed result in cron module.
Report changed=False if no cron is removed:wq
2013-11-03 17:43:51 -08:00
Michael DeHaan
83d50b1984 Make it slightly more clear what side of the connection is missing keyczar if using accelerate mode. 2013-11-03 12:46:21 -05:00
Michael DeHaan
6e6884d6e0 Merge pull request #4789 from mohangk/devel
Fix for connect method parameter order
2013-11-03 08:49:00 -08:00
Mohan Krishnan
56bd9a14d5 Fix for connect method parameter order 2013-11-03 14:48:35 +07:00
Steve Tjoa
626d41c1d1 Changed parameter from 'user' to 'name' in the examples to coincide with the specs. 2013-11-02 22:42:44 -07:00
Mohan Krishnan
0ae9128c7b ec2_eip connect method references module var that is not passed in 2013-11-03 05:18:27 +07:00
Pedro Romano
78c616f271 Obsolete attempts at determining the full path to the desired
'easy_install' executable were still left behind and need to be removed
for the customizable 'executable' task argument to correctly work:
'_get_easy_install' should take care of all the functionality related to
determining the correct 'easy_install' executable to use.
2013-11-02 19:25:51 +00:00
Michael DeHaan
334dcfa2fa Update module documentation. 2013-11-02 09:34:44 -04:00
Michael Scherer
1ef9bed752 Try/finally is a python 2.5 construct, so not working
on EL5. Fix #4763
2013-11-02 11:24:29 +01:00
James Laska
2a5874b94f Honor wait on ec2 instance termination 2013-11-01 18:57:20 -04:00
Michael DeHaan
e725eea4be Merge pull request #4770 from dragon3/devel
ec2_vol: return volume_id/device even when volume mapping already exists
2013-11-01 09:32:54 -07:00
James Tanner
afa5988391 Fixes #4540 Use shared module snippet to evaluate ec2 credentials 2013-11-01 11:59:24 -04:00
dragon3
19b5008c0a return volume_id/device even when volume mapping already exists 2013-11-01 23:59:42 +09:00
James Tanner
f4b59fe285 Fixes #4516 file module: check prev_state earlier and use that if state is not specified 2013-11-01 09:31:32 -04:00
Michael DeHaan
337b6ce642 Fix documentation formatting. 2013-10-31 20:00:11 -04:00
Brian Cavagnolo
869f32123b make cloudformation module accept template_parameters from command line
Passing cloudformation template_parameters on the command line
like so was failing:

    ansible localhost -m cloudformation -a "...template_parameters=foo=5,bar=4..."
2013-10-31 17:00:03 -07:00
Michael DeHaan
7f125567cb Some simplification of include_vars and renamed include_files to include_vars. 2013-10-31 19:24:35 -04:00
Michael DeHaan
b69ab89eb1 Merge branch 'include_files' of git://github.com/bennojoy/ansible into devel 2013-10-31 19:14:27 -04:00
Michael DeHaan
187ebf2f56 Leverage 4318b27 and no longer treat instance tags as JSON, but as dictionary types which could be key=value or dicts or JSON or references. 2013-10-31 18:46:13 -04:00
Michael DeHaan
b520902852 Merge pull request #4756 from mscherer/fix_4739
Fix accelerate module on centos 5 by removing
2013-10-31 15:21:51 -07:00
Michael DeHaan
6d16f85b30 Suggest keyscan for github/other SCM hanging. 2013-10-31 18:00:24 -04:00
Michael DeHaan
aae3a0ea8d Merge pull request #4740 from retr0h/return-server-object-not-list
Need to compare on server object not list
2013-10-31 14:51:08 -07:00
Michael DeHaan
3a0d67024c Merge pull request #4736 from dmkoch/assemble-temp-file-cleanup
Clean up temp file left behind by assemble module
2013-10-31 14:50:28 -07:00
Michael DeHaan
3705f41992 Merge pull request #4754 from mscherer/fix_4648
Fix 4648, cron module is not working on solaris
2013-10-31 14:49:25 -07:00
Michael DeHaan
d34a26e307 Undo an inadvertant revert from template changes so we still allow pythonic imports in module land. 2013-10-31 16:53:05 -04:00
Michael Scherer
8efe53eebb Fix accelerate module on centos 5 by removing
unsupported string prefix in 2.4

http://docs.python.org/release/2.4/ref/strings.html
This is also ignored on later version of python 2
and is present only for python 3 conversion, as seen
on http://docs.python.org/2/reference/lexical_analysis.html#string-literals

Also see http://stackoverflow.com/questions/6269765/what-does-the-b-character-do-in-front-of-a-string-literal

Fix https://github.com/ansible/ansible/issues/4739
2013-10-31 21:04:34 +01:00
Michael Scherer
9e7b02aaee make cron module work on solaris
Cron on solaris do not take the same
set of option than vixie cron on linux, and
among the biggest difference, root cannot set
the crontab of a user directly from a file. Thus the
use of su to run the crontab command. Fix issue #4648
2013-10-31 19:58:26 +01:00
Michael Scherer
506ce6a809 remove unused function 2013-10-31 19:58:26 +01:00
Scott Dunlop
dbc1e20462 add "zle" as a supported ZFS compression type
ZFS supports "zle" compression, which compresses runs of null bytes efficiently.
2013-10-31 10:48:41 -07:00
Sheldon Hearn
6a02c75b7c Fix description of nova_compute:name option
It's the name of the instance, not of an image.
2013-10-31 12:34:04 +02:00
John Dewey
f1fa16b65f Need to compare on server object not list
TASK: [create test controller 0] **********************************************
    failed: [127.0.0.1] => {"failed": true, "parsed": false}
    invalid output was: Traceback (most recent call last):
      File "/Users/jdewey/.ansible/tmp/ansible-1383197329.62-262790004573235/nova_compute", line 1203, in <module>
        main()
      File "/Users/jdewey/.ansible/tmp/ansible-1383197329.62-262790004573235/nova_compute", line 261, in main
        _get_server_state(module, nova)
      File "/Users/jdewey/.ansible/tmp/ansible-1383197329.62-262790004573235/nova_compute", line 197, in _get_server_state
        if server.status != 'ACTIVE':
    AttributeError: 'list' object has no attribute 'status'
2013-10-30 22:41:02 -07:00