Commit graph

47957 commits

Author SHA1 Message Date
Matt Clay
78eca0eb5d Fix SSL protocol references in mqtt module. 2019-10-17 17:40:21 -07:00
Matt Clay
437e9b7063 Fix ansible-test sanity requirements install.
This fixes ansible-test so it no longer tries to install sanity test dependencies on unsupported Python versions.
2019-10-17 17:40:04 -07:00
Gonéri Le Bouder
424f9f0dac vmware_guest_network/test: fix name of test VM
The test VM is called `test_vm1` since
https://github.com/ansible/ansible/issues/63302.

Also, avoid the `00:50:56` prefix for the MAC address, since it's known
for being source of problem: https://github.com/ansible/ansible/issues/63302
2019-10-17 17:38:42 -04:00
Felix Fontein
a129499cf4
Improve module return values (#63541)
* Remove lists from contains:, fix types, some more details.

* Adjust types.

* Add new type.

* Re-add meraki_mx_l7_firewall docs at right indentation level.
2019-10-17 22:02:39 +02:00
Hossein Torabi
d8b9f9fb4f Fix example in pip module documentation (#63462) 2019-10-17 15:40:13 -04:00
abarbare
017f0cb2f8 Add scaleway maintainer to BOTMETA (#63439) 2019-10-17 15:34:04 -04:00
Sander Steffann
faf8fc62cb Add inventory cache to the netbox plugin (#57644)
* Add cache to netbox inventory plugin

* add changelog fragment
2019-10-17 15:18:07 -04:00
Mark Chappell
8d0737edf0 Integration tests for s3_logging (#63257)
* s3_logging: (integration tests) updated AWS policy

* s3_logging: fix sanity test issues

* s3_logging: Integration tests

* Add pauses to cope with evenual consistency

* Mark s3_logging tests as 'unsupported' for now due to testing instability
2019-10-17 11:33:55 -07:00
JayalakshmiV
1a384a61fb exos_lldp_interfaces resource module (#62108)
* exos_lldp_interfaces resource module

* Fix exos_lldp_interfaces and add integration tests

* Fix deleted testcase for integration test
2019-10-17 13:40:17 -04:00
Nathaniel Case
f5e0995cae
Fix netconf post "delay persistent connections" (#63463)
* ensure_connect on manager use

* Remove ensure_connected from individual netconf plugins
2019-10-17 11:22:48 -04:00
Andrea Tartaglia
7da37e58de Added changelog fragment 2019-10-17 08:12:49 -07:00
Andrea Tartaglia
202ad4f89a Fixes --version in ansible-galaxy cli 2019-10-17 08:12:49 -07:00
Matt Martz
81d49c38f8
Default lookups to community (#63631) 2019-10-17 09:44:24 -05:00
Andrea Tartaglia
b4bb3dee9a gitlab_user: Fix ssh key add and group membership add when there's other changes (#63621)
* Fixed syntax in sshkey/group add

* Added changelog

* pep8 fix
2019-10-17 10:22:15 -04:00
Andrey Klychkov
7dd46f7b2d postgresql_privs: add support a type parameter option for types (#63555)
* postgresql_privs: add support a type parameter option for types

* postgresql_privs: add support a type parameter option for types, add changelog fragment

* postgresql_privs: add support a type parameter option for types, add schema handling

* postgresql_privs: add support a type parameter option for types, fix typo

* postgresql_privs: add support a type parameter option for types, add comment
2019-10-17 14:59:06 +01:00
Andrey Klychkov
ae16a840f6 mysql_replication: fix typo in setup role (#63625) 2019-10-17 13:17:15 +01:00
willtome
f2ca4cce2b Add Constructed to Foreman inventory plugin (#62542)
* add constructed

* changelog
2019-10-17 11:43:22 +02:00
Felix Fontein
ba686154b9
openssl_csr: deprecate version option (#63432)
* Deprecate openssl_csr's version.

* Add changelog.

* Change PR so that version will no longer accept values != 1 from 2.14 on.

* Make sure it is a string.
2019-10-17 10:42:05 +02:00
Felix Fontein
d00d0c81b3
openssl_privatekey: add support for format option (#60388)
* Add support for format option.

* Improve private key format detection.

* Fix raw format handling.

* Improve error handling.

* Improve raw key handling.

* Add failed raw test.

* Improve raw key loading.

* Simplify tests.

* Add raw format tests.

* Fail if format != 'auto_ignore' is specified for pyopenssl backend.

* Fix quoting.

* Bump version.

* Allow to convert private keys between different formats.

* Improve description.
2019-10-17 10:40:13 +02:00
Sergey
e3c7e35656 Add extra args and executable name to podman connection plugin (#63166)
* Add extra args and executable name to podman connection plugin

Like there is for docker plugin, add extra arguments for command
line of podman. Also add configurable executable and checking if
this executable exists on host. Fail module if executable is not
in PATH.

* Update changelogs/fragments/63166-add-extra-args-executalbe-podman-connection.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-10-17 13:48:29 +05:30
Pavan Bidkar
b6ea43efc3 VMware: Support instance_uuid to find the vm for vmware_guest_network module (#62818) 2019-10-17 12:23:13 +05:30
Andrey Klychkov
d615d7ea19 mysql_variables tests: change CI host group (#63602) 2019-10-17 08:26:09 +02:00
Toshio Kuratomi
4cad7e479c
Galaxy publish fix (#63580)
* Handle galaxy v2/v3 API diffs for artifact publish response

For publishing a collection artifact
(POST /v3/collections/artifacts/), the response
format is different between v2 and v3.

For v2 galaxy, the 'task' url returned is
a full url with scheme:

        {"task": "https://galaxy-dev.ansible.com/api/v2/collection-imports/35573/"}

For v3 galaxy, the task url is relative:

        {"task": "/api/automation-hub/v3/imports/collections/838d1308-a8f4-402c-95cb-7823f3806cd8/"}

So check which API we are using and update the task url approriately.

* Use full url for all wait_for_import messages

Update unit tests to parameterize the expected
responses and urls.

* update explanatory comment

* Rename n_url to full_url.

* Fix issue with overwrite of the complete path

* Fixes overwrite of the complete path in case there's extra path stored
  in self.api_sever
* Normalizes the input to the wait_import_task function so it receives
  the same value on both v2 and v3

Builds on #63523

* Update unittests for new call signature

* Add changelog for ansible-galaxy publish API fixes.
2019-10-16 15:23:12 -07:00
Matt Martz
82ee341fe0
Explicitly use multiprocessing fork start method (#63581)
* Explicitly use multiprocessing fork start method

* Remove unused import

* Remove unused import

* Fallback to just multiprocessing on py2
2019-10-16 15:30:50 -05:00
Pouyan Azari
f638f29e44 Replaced old DSC links that given 404 (#63556)
Replace DSC links that returned "not found" with updated, working links.
2019-10-16 12:52:30 -05:00
Prasad Katti
275b3972cb [lightsail] make delete operation idempotent (#63317)
Fixes #63315
2019-10-16 13:01:50 -04:00
Jan Meerkamp
94c23136be one_vm: moved to pyone added Persisten Deployment (#57393)
* moved to pyone added Persisten Deployment

Moved from python-oca to pyone.
Added Persistent deployment of VMs.

* Cleanup fixed missing whitespace

* cleanup whitesüace and indent

* corrected Versions and fixed disk count in error msg

* inc version

* wrong version for vm_start_on_hold

* added datastore for new instances

* added multiple Disks

* fixed missing info
2019-10-16 12:11:08 -04:00
Matt Clay
7448084858 Update default-test-container to 1.10.1.
This brings in the final Python 3.8.0 release instead of a release candidate.
2019-10-16 09:07:09 -07:00
GomathiselviS
6d7620b646 Added fix for bug 63290 (#63308) 2019-10-16 19:17:46 +05:30
benjdudas
88013e7159 generalized on_become prompt match for ios (#63528) 2019-10-16 19:13:57 +05:30
Andrey Klychkov
3a733cb0a1 postgresql_user: remove unused import (#63559) 2019-10-16 08:51:08 -04:00
Andreas Olsson
98b025239a nsupdate: Don't try fixing non-existing TXT values (#63408)
The commit 4e895c1 aimed to ensure that TXT record values were sanely
quoted. Sadly it failed to take the scenario of non-existing values
into account. While record values are required for record creation
they are not required for record deletion.

This change rectifies that oversight, saving Ansible from
unsuccessfully trying to operate on NoneType objects.

Resolves #63364
2019-10-16 17:58:41 +05:30
René Moser
332b220854 cloudscale: fix boilerplate (#63533) 2019-10-16 11:02:32 +02:00
Andrey Klychkov
c4ce4a6c03 mysql_variables: update MySQL in CI to 8.0 (#63454) 2019-10-16 08:30:33 +02:00
Matt Clay
d829a50a5b Fix use of deprecated function in xml module. 2019-10-15 15:29:11 -07:00
Matt Clay
32b57d57a0 Add constraint for pathspec.
This fixes installation of pathspec on Python 2.6.
2019-10-15 14:39:29 -07:00
Felix Fontein
4bc298af83 Fix return value documentation (2/2) (#63478)
* Fix return value documentation (2/2).
* Avoid validation errors for missing 'contains:'.
* Convert JSON text to JSON dict.
* example -> sample.
* Fix YAML.
2019-10-15 15:53:46 -05:00
Matt Clay
20be8693ba Revert "Remove top-level arguments from network modules (#62603)"
This reverts commit d5ac3f7e77.
2019-10-15 12:53:51 -07:00
houtd
e4eea0510c Fix warnings for ufw examples (#63505) 2019-10-15 11:55:45 -04:00
pando85
e0f67b58ce Fix doc - porting_guide_2.8 value example (#63493) 2019-10-15 10:50:10 -05:00
Nathaniel Case
d5ac3f7e77
Remove top-level arguments from network modules (#62603)
Eh, 2.10 is close enough

* drop top-level authorize

* Remove from documentation

* Remove load_params

* nxos_hsrp: I don't think this is an actual module parameter

* Move local params to provider

* Promote 'timeout' to a real parameter for eos_eapi

* Provider now always has auth_pass
2019-10-15 11:41:35 -04:00
Felix Fontein
6bea1597cc Fix return value documentation (1/2) (#63477)
* Fix return value documentation (1/2).
* Avoid validation errors for missing 'contains:'.
2019-10-15 10:03:08 -05:00
Martin Nečas
16e49fdd44 ovirt_vm add warning about next run configuration (#63458) 2019-10-15 09:42:32 -04:00
Andrey Klychkov
ecf71dd720 mysql_user: add seealso (#63497) 2019-10-15 10:48:13 +02:00
Jeff Gibson
e967060b9f Update unarchive.py - Further clarify extra_opts (#58102)
* Update unarchive.py - Further clarify extra_opts
Update the description in the options to help assist with what the module is looking for in the extra_opts.  #31873 alone is not enough since if you are not familiar with the option given in the example it may not be obvious that both elements are part of the same option instead of being two different options.

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-10-14 15:38:49 -05:00
Sam Doran
2b1e24fc49 package_facts - use AnsibleModule.warn() for warnings 2019-10-14 13:30:16 -07:00
Guillaume Martinez
7bb90999d3 Fix Gitlab module deprecation warning (#60425)
* gitlab modules : Fix deprecation warnings and parameters

Also preparing for 2.10 deprecation

* gitlab modules : Correct deprecation message
2019-10-14 15:58:21 -04:00
Sam Doran
e9d10f94b7
user - fix shadow file parsing on AIX (#62547)
Initialize variables in case the shadow file is not found.
Handle IndexErrors if something goes wrong with file parsing.
2019-10-14 15:44:22 -04:00
Matt Martz
d8389d9f55
Ensure we preserve the /api appended URL (#63472) 2019-10-14 13:34:07 -05:00
Niklas Beinghaus
da46800f1b Update 'delete' parameter description in synchronize module (#63450)
Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-14 13:49:43 -04:00