Commit graph

36536 commits

Author SHA1 Message Date
Alicia Cozine
fee754fa59 playbooks_intro.rst: remove duplicite playbook (#38521) (#41864)
(cherry picked from commit f1e41cbb36)
2018-07-03 12:06:39 -07:00
Brian Coca
e9a32c1107 fix vars hostname fallback (#41858)
also made it optimistic, rely on exceptions instead of copmlex if chains

(cherry picked from commit 11dbed1350)
2018-07-03 12:06:23 -07:00
Brian Coca
40c47b7785 fix minor issues with debug and item labels (#41331) (#41815)
* fix minor issues with debug and item labels

 - no more `item=None`, we always have a label now
 - debug should only show expected information, either msg= or the var in var=
 - also fixed method name, deprecated misleading _get_item

(cherry picked from commit 27c43daab8)
2018-07-03 12:05:13 -07:00
Nilashish Chakraborty
9101dd6857 Fixed eos_logging test issue (#41777) 2018-07-03 12:04:35 -07:00
Nilashish Chakraborty
b9904b9fe7 Fix vyos_vlan aggregate issue & added tests CP into 2.5 (#41638) (#41775)
* Fix vyos_vlan aggregate issue & added tests (#41638)

* Fix vyos_vlan aggregate issue & Added tests

* Fix #2 for vyos_vlan aggregate issue

(cherry picked from commit 837c216587)

* Added changelog for vyos_vlan aggregate issue fix
2018-07-03 12:02:11 -07:00
Martin Krizek
dcf95a3adc Backport 2.5: apt: fix apt-mark on debian6 (#41724)
* apt: fix apt-mark on debian6 (#41530)


(cherry picked from commit 2e68811c34)

* Add changelog/fragment
2018-07-03 12:01:36 -07:00
Brian Coca
36b0756c3b update play_context for reset_connection (#40866) (#41655)
steps taken from lib/ansible/executor/task_executor.py

fixes: https://github.com/ansible/ansible/issues/27520
(cherry picked from commit 23fbe0ce8e)
2018-07-03 11:58:49 -07:00
Markos Chandras
e20294c1e1 facts: suse: Fix major version detection for SUSE (#41416) (#41650)
When parsing the distribution files such as /etc/os-release, we extract
the full distribution version but not the major version. As such, the
ansible_distribution_major_version ends up being 'NA' whereas the
ansible_distribution_version contains the full version.

Before this patch we get this on openSUSE Leap 15

ansible -o localhost -m setup -a filter=ansible_distribution_major_version
localhost | SUCCESS => {"ansible_facts": {"ansible_distribution_major_version": "NA"}, "changed": false}

After this patch we get this

ansible -o localhost -m setup -a filter=ansible_distribution_major_version
localhost | SUCCESS => {"ansible_facts": {"ansible_distribution_major_version": "15"}, "changed": false}

This also fixes the Tumbleweed distribution test to report a proper
major version and also adds a test for openSUSE Leap 15.0 to avoid
potential future regressions.

Fixes: #41410
(cherry picked from commit 1737b7be3e)
2018-07-03 11:58:00 -07:00
Ricordeau Raphael
4314798d3e Fix changelog order in the rpm spec file (#38272) 2018-07-03 11:57:23 -07:00
Trishna Guha
15ac94f87c fix nxos_linkagg issue (#41550) (#41620)
* fix nxos_linkagg issue (#41550)

* fix nxos_linkagg issue

* fix shippable

(cherry picked from commit 119e6d680b)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-07-03 11:50:57 -07:00
Toshio Kuratomi
f56197df94 [stable-2.5] sort the port list properly (.sort() returns None) (#41603)
(cherry picked from commit 63f2ad8776)

Co-authored-by: schp <schonhofen@gmail.com>
2018-07-03 11:50:36 -07:00
Toshio Kuratomi
b9b1a65067 [2.5] Update user module docs (#41572) (#41602)
* Clarify append and groups behavior
* Document return values.
(cherry picked from commit 6fa2d9ac6f)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2018-07-03 11:50:13 -07:00
Toshio Kuratomi
7b325baa22 Bkprt recursive copy fix (#40268)
* Fixes #34893 (#40166)

Fixes several bugs exposed in #34893
* Fixes relative path handling in copy so that it splits directories and
  reconstructs the correct file path
* Return failed in the proper circumstances

(cherry picked from commit ca4147f2cc)

* Add changelog for recursive copy fix

(cherry picked from commit cab0f21564)
2018-07-03 11:49:45 -07:00
Toshio Kuratomi
6a7c43b0ba [stable-2.5] Make the copy module pass correct parameters to file module (#42021)
(cherry picked from commit d994595660)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2018-07-03 08:55:42 -07:00
Matt Clay
9fcf256817 Disable remaining failing rabbitmq_* tests.
(cherry picked from commit 5880404151)
2018-06-21 15:56:22 -07:00
Matt Clay
cd9d18a93b Revert "Disable failing rabbitmq_user test."
This reverts commit e954633739.
2018-06-21 15:55:33 -07:00
Matt Clay
e954633739 Disable failing rabbitmq_user test. 2018-06-21 13:57:37 -07:00
Jordan Borean
2f0cfa857a win_updates fix when win_updates is run with async (#41756) (#41763)
(cherry picked from commit 11bd3fd318)
2018-06-20 16:27:53 -07:00
Matt Clay
317388e967 Temporarily disable gem test on osx.
Disabled due to lack of newer TLS version support on the test system.

(cherry picked from commit dce708e63e)
2018-06-19 17:02:14 -07:00
Matt Davis
4202d1d769 skip winrm unit tests if winrm is not installed (#41596)
(cherry picked from commit b01779ad18)
2018-06-15 10:26:33 -07:00
Matt Davis
5f6e1a70a6 New release v2.5.5 2018-06-14 14:14:39 -07:00
Michael Doyle
40a6a19042 Change falied_conditions to proper spelling (#41284) (#41418)
(cherry picked from commit e892646bc7)
2018-06-14 11:59:18 -07:00
Rosiney Gomes Pereira
a6c6011ed4 SUMMARY (#41560)
The module name, missmatch in documentation.

ISSUE TYPE
- Documentation

COMPONENT NAME

bigip_configsync_action

ANSIBLE VERSION

stable-2.5

Signed-off-by: Rosiney Gomes Pereira <rosiney.pereira@agilitynetworks.com.br>
2018-06-14 11:58:22 -07:00
Trishna Guha
68134cc635 Don't retrieve config in running_config when config is provided for diff stable 2.5 (#41557)
* don't retrieve config in running_config when config is provided for diff (#41400)

* don't retrieve config in running_config when config is provided for diff

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix for eos, nxos

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 8ab0d654f3)

* add changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-06-14 11:55:58 -07:00
Jordan Borean
20a55c5fdc Fix typos in blocks documentation examples. (#41508) (#41524)
(cherry picked from commit a4f49ed648)
2018-06-14 11:55:32 -07:00
Toshio Kuratomi
b4cb0b46e3 Tasks that are expected to fail need to begin with a special string (#41466)
(cherry picked from commit a5fd86cf6d)
2018-06-14 11:55:06 -07:00
Will Thames
cbaef99489 Fail with nice error message if elb target_type=ip not supported (#38313) (#41430)
* Add helpful failure message if target_type=ip is not supported

Create test case for target_type=ip not supported

* Update elb_target_group module to latest standards

Use AnsibleAWSModule
Improve exception handling
Improve connection handling

(cherry picked from commit 29770a297a)
2018-06-14 11:54:32 -07:00
Sam Doran
3db865bd5e Update docs on import/include tasks (#33032) (#41406)
(cherry picked from commit 30da71d880)
2018-06-14 09:52:20 -07:00
Sylvain Rabot
c54990fd81 Fix rabbitmq_user when using force on user with permissions (#41361)
On rabbitmq 3.7 using `force: yes` fails because outputs of rabbitmqctl gives an empty line

```
root@rabbitmq-vm1:~# rabbitmqctl -q list_user_permissions john

root@rabbitmq-vm1:~#
```

Provoking an error on

456af458fc/lib/ansible/modules/messaging/rabbitmq_user.py (L185)

Because `perm.split('\t')` does not find any `\t`

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
(cherry picked from commit 8ddca3e6cfd906f0ff48a2c08410a9f82d195deb)
2018-06-14 09:52:01 -07:00
Toshio Kuratomi
d9c5614b92 Make admin_users only contain root and toor because admin is used for non-privileged accounts (#41352)
This fixes one specific instance of failure to chown from a privileged
account:
https://github.com/ansible/ansible/issues/16052#issuecomment-384976615

Fixes #41160

(cherry picked from commit 461a2733e6)
2018-06-14 09:50:28 -07:00
Martin Krizek
ffd4ee1be7 first_found: fix examples to match the code (#40821) (#41328)
(cherry picked from commit 23a337918c)
2018-06-14 09:49:50 -07:00
Sam Doran
f9b95d12ed Fix typeo in param name (#41287) (#41325)
(cherry picked from commit effa235eb6)
2018-06-14 09:49:30 -07:00
Julien Vey
f73d123ef4 cloudfront_distribution: fix the order of headers to avoid updates again and again (#37340)
* Fix python2/3 compatibilities issues

* Sort cloudfront_distribution headers to avoid useless updates

(cherry picked from commit ec2e027980)
2018-06-14 09:48:59 -07:00
Jordan Borean
459342ecc1 Update winrm.py (#41303) (#41305)
fix the typos for winrm port

(cherry picked from commit 7fb92b6f45)
2018-06-14 09:47:57 -07:00
Toshio Kuratomi
698b8e04f3 Bkprt nolog fix (#41453)
* no_log even when task_result doesn't provide key

 - now also checks task property
 - added reproducer to tests for unreachable status on item loop

(cherry picked from commit 336b3762b2)

* Add changelog entry for the no_log fix

(cherry picked from commit 5fdd101a3e)
2018-06-12 12:28:29 -07:00
Matt Davis
0a6bff20d0 fixed prerelease support in deb packaging
(cherry picked from commit 0371e7c866)
2018-06-12 10:57:14 -07:00
Trishna Guha
8fe99ae001 Fix nxos_l3_interface no switchport issue with loopback and svi interfaces, nxos_snapshot issue (#41318)
* Fix nxos_l3_interface no switchport issue with loopback and svi interfaces

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Fix nxos_snapshot compare (#41386)

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 1998707eda)

* changelog nxos_snapshot

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-06-11 09:21:49 -07:00
Nilashish Chakraborty
da67d279be Fixes eos_logging idempotence CP into 2.5 (#40931)
* Fixes eos_logging idempotence issue #31862 (#40604)

* eos_logging idempotence fix

* fixed eos_logging idempotence issue

* Fixed pylint and pep8 errors

* Added tests for eos_logging & minor fix

* Removed q statements

(cherry picked from commit b9ea646839)

* Added changelogs for eos_logging idempotence fix

* changelog tweak
2018-06-07 17:15:56 -07:00
Sloane Hertel
fe2520a830 2.5 backport #40826 to fix async for aws_s3 (#41276)
* cherry-picked from 89cea78e30 and fixed merge conflicts from restructuring the integration tests in devel

Fix async for aws_s3

Add a test that async is able to be used on aws_s3 tasks

(cherry picked from commit cef92e3942cdd76866c47d25f903625e6d7eb6ed)

* changelog format tweak
2018-06-07 17:12:13 -07:00
Jordan Borean
6c5be7d33c Add some dots at the end of sentences (#41176) (#41226)
See e.g. https://docs.ansible.com/ansible/devel/reference_appendices/config.html#default-scp-if-ssh
In the docs the list of strings is just concatenated without additional interpunctuation.

+label: docsite_pr

(cherry picked from commit edb1735ca0)
2018-06-07 17:11:12 -07:00
Will Thames
1256fedd61 Fix ec2_ami block_device_mapping volume_size to be int in 2.5 (#40938) (#41217)
* Fix ec2_ami block_device_mapping volume_size to be int in 2.5 (#40938)

* fix ec2_ami block_device_mapping size to be int

* fixed cr issues

renamed `type` to `attribute_type`
reused `new_item` instead of creating new variable `value`

(cherry picked from commit ab96a84154)

* changelog

(cherry picked from commit e6cd727181cb6c7e08f9cbad44dc7d625e78406a)

* changelog format tweak
2018-06-07 17:10:45 -07:00
Sloane Hertel
125d1e3867 aws_s3: don't decrypt file before uploading - fixes #39287 (#39634) (#41205)
* aws_s3: don't decrypt file before uploading - fixes #39287 (#39634)

* aws_s3: do not decrypt file before uploading to bucket

* changelog

(cherry picked from commit 387c37e255)

* changelog format tweak
2018-06-07 17:09:58 -07:00
Brian Coca
394753b918 Docs fix: ansible_group_priority defaults to 1 (#41204)
The docs committed in #28777 were inconsistent.
This clarifies that the default `ansible_group_priority` is `1`.[1][2]

[1] https://github.com/ansible/ansible/blob/153c9bd/lib/ansible/inventory/group.py#L40
[2] https://github.com/ansible/ansible/blob/153c9bd/lib/ansible/cli/inventory.py#L236

(cherry picked from commit 4fa2fb9c89)
2018-06-07 17:09:04 -07:00
Nathaniel Case
79cedcbaa5 Do not gather mem facts if command invalid (#40820) (#41141)
* Do not gather mem facts if command invalid (#40820)

* Do not gather mem facts if command invalid

In some firmwares, 'show memory statistics' fail, thus
do not populate mem if we got a failure after running that command.

* Fix pep8

* Warn if got error when running 'sh memory statistics'

* Fix pep8

(cherry picked from commit 669949e6a3)

* Update ios_facts.py (#40928)

Account for upper/lower case match occurrences of "[Nn]umber" and "[Ss]erial"

Model Number                       : WS-C3850-12X48U
System Serial Number          :  <removed>

(cherry picked from commit 12d221152b)

* Expand ios password prompt regex (#41131)


(cherry picked from commit 49fddb6f28)
2018-06-07 17:06:17 -07:00
Nilashish Chakraborty
72ad0dd4ec Fix ios_logging idempotence CP into 2.5 (#41120)
* Fixes to ios_logging (#41029)

* Logging size may not show up in config

* This is much simpler

* Avoid repetition in tests

* Both options of buffered are optional

(cherry picked from commit 92a95368fe)

* Added changelog
2018-06-07 17:05:47 -07:00
Sloane Hertel
43cfb89c2a 2.5 backport #40720 - fix cache timeout behavior (#41018)
* Fix cache timeout behavior

(cherry picked from commit c1400ce909)

* changelog
2018-06-07 17:01:50 -07:00
Gaudenz Steinlin
515a625e13 dictionary changed size during iteration error (#37454) (#41000)
Iterating an object and changing it at the same time is unsecure and no longer permitted in Python >= 3.6

Provisioning an instance fail with the Python error: "RuntimeError: dictionary changed size during iteration"
2018-06-07 17:01:21 -07:00
Jesse Pretorius
7e04385baf os_server_action: Document the python-novaclient requirement (#40841)
Without also installing the python-novaclient library, this module
simply does not work.

Fixes: #35484
2018-06-07 16:54:36 -07:00
Jesse Pretorius
be9de94eea Correct the OpenStack plugin example config (#40766)
The current example configuration is not
quite right, so this patch implements a
fix which corrects it

The 'inventory_hostname' argument is removed
as it's the same value as the default.

(cherry picked from commit 12218f33a5c429676da8f3db0f91553c63a0314f)
2018-06-07 16:48:49 -07:00
Jesse Pretorius
c142e2f1a3 os_project_access: clean up some things (#40763)
* os_project_access: correct example tasks

The example task does not work. Fix it so that it does.

(cherry picked from commit 028b5965b66656ffe7810cea3bcc0e505339ebc2)

* os_project_access: Remove unused function

The _get_allowed_projects function is not used anywhere,
so we can remove it and be free of nova_client for this
module.

(cherry picked from commit c190a2826d6935848278867c67f36f2b56728f94)
2018-06-07 16:48:04 -07:00