Commit graph

40478 commits

Author SHA1 Message Date
Paul Belanger
e844bfe1d4 Force PEM SSH keys for paramiko
Trying to get ansible-test working on my fedora-28 system, I noticed I
was getting invalid keys from paramiko. It looks like this is because
ssh-keygen is now defaulting to RFC4716 format for private / public
keys.

For now, we can still use PEM based SSH keys, but the long term fix here
is to report a bug to paramiko and support RFC4716 for rsa keys.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2018-10-18 21:25:55 -07:00
Jordan Borean
c0546b4133
win httptester: add wait for endpoint in case it is still coming up (#47326) 2018-10-19 13:43:54 +10:00
Dag Wieers
e758f69ce3 win_domain: Add missing functionality (#46552)
* win_domain: Add missing functionality

* Fix typo: Treshold -> Threshold

* Improvements based on feedback

* moved mode checks to after pre-reqs are installed
2018-10-19 13:18:52 +10:00
Abhijeet Kasurde
bfc3ca1da1 Remove extra parameter in format_exc (#46251)
`traceback.format_exc()` does not take any argument, this fix remove
such occurances.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-10-18 21:50:58 -04:00
Claude Dioudonnat
1a51b08875 Fix increase fake disk size for filesytem's tests 2018-10-19 01:20:33 +02:00
Pierre-Louis Bonicoli
e016af3cc6 filesystem tests: enable LVM
Co-authored-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>
2018-10-19 01:20:33 +02:00
Claude Dioudonnat
42730cffc4 Fix get_fs_size for LVM filesystem 2018-10-19 01:20:33 +02:00
Baptiste Mille-Mathias
3f8a0f6657 Use syntax loop instead of with_items in example (#47241) 2018-10-18 17:55:19 -05:00
Baptiste Mille-Mathias
bac43eebe0 Use loop instead of obsolete with_items in example (#47246) 2018-10-18 17:54:07 -05:00
Martin Krizek
541255a2d8
Do not strip new lines in native jinja (#46751)
* Do not strip new lines in native jinja

* Add changelog/fragment
2018-10-19 00:14:43 +02:00
Toshio Kuratomi
4d9504e775 Remove runtime usage of pkg_resources.
This should provide a startup time speed boost at the expense of making
it harder to get ansible to use newer versions of packages than are
provided by the platform.
2018-10-18 15:09:38 -07:00
Baptiste Mille-Mathias
65bb6a5af3 Use loop instead of with_items in examples (#47318) 2018-10-18 17:14:50 -04:00
Baptiste Mille-Mathias
0b9c033abe Use loop instead of with_items in examples (#47319)
with_items is deprecated
2018-10-18 17:14:35 -04:00
Matt Clay
37b013aca3
Enable additional pylint rules and resolve issues found. (#47221)
* Resolve unneeded-not.
* Resolve global-at-module-level.
* Resolve useless-import-alias.
* Resolve bad-whitespace.
* Resolve global-variable-not-assigned.
* Resolve logging-not-lazy.
* Resolve comparison-with-itself.
2018-10-18 13:38:08 -07:00
Matt Martz
77d32b8f57
Don't use the task for a cache, return a special cache var (#47243)
* Don't use task to cache loop results, use hostvars. Fixes #47207

* Avoid a race condition, supply _ansible_loop_cache through get_vars directly

* Add tests

* Add changelog fragment

* Remove unnecessary copy

* Remove unnecessary host from _get_delegated_vars signature
2018-10-18 15:25:43 -05:00
Adam Miller
9e2c02455a add note about named tasks in blocks (#46984)
* add note about named tasks in blocks

Signed-off-by: Adam Miller <admiller@redhat.com>

* adds names to tasks within example block, removes 2nd example

* removes traces of bad rebase
2018-10-18 16:24:52 -04:00
Sean Cavanaugh
81d22dc304 adding additional example and clarification (#47224)
The kind: paramter is missing from the original example (which won't actually work).  The organization needs to be listed as required (if you don't list it, you will get an error).  Also adding additional example using the tower_username and tower_password method.
2018-10-18 16:21:35 -04:00
John Imison
c809560385 Minor documentation fix. (#47276) 2018-10-18 16:19:45 -04:00
Bianca Henderson
e52761fbd3 Making minor changes (#47311)
<!--- Your description here -->

+label: docsite_pr
2018-10-18 16:18:29 -04:00
Matt Clay
f74f7b0373
Add constraint for requests on python 2.6. (#47306)
* Add constraint for requests on python 2.6.
* Use constraints in lookup_hashi_vault test.
2018-10-18 13:05:29 -07:00
Matt Martz
19416a1343 Fix versions in module.deprecate call to align with module deprecation. Fixes #45035 #45034 (#47211) 2018-10-18 15:30:22 -04:00
Nathaniel Case
7844a40046
Update some cliconf plugins (#47141)
* Add `check_all` to many community cliconf plugins
2018-10-18 15:26:20 -04:00
Martin Krizek
096717edc5 ansible-galaxy: fix searching with unicode 2018-10-18 14:59:03 -04:00
Dag Wieers
06eabc9783 reboot: Add timeout in error to help troubleshooting (#47216)
* reboot: Add timeout in error to help troubleshooting

So we've been hit by 'Timed out waiting for boot_time check' and it was
unclear what timeout was used for the boot_time check. By adding the
timeout value it is easier to understand the used value, and verify if a
change to the timeout is reflected in the output.

* Add changelog fragment
2018-10-18 14:42:39 -04:00
Matt Clay
14da4d66f2 Add constraints to pip install in setup_docker. 2018-10-18 10:25:48 -07:00
Nathaniel Case
3feb6c9e0f
Try to be more verbose with JSON decode errors (#47066)
* Try to be more verbose with JSON decode errors
2018-10-18 12:09:00 -04:00
Toshio Kuratomi
bcd6dbcd65 Remove get_exception from the remainder of the modules 2018-10-18 08:37:04 -07:00
Ryan Brown
18a088c64e
GCP MagicModules bug fixes (#47285)
Closes: #46930 #46929 #46928 #46927 #46926 #46925 #46924 #46923 #46922 #46921 #46920 #46919 #46918 #46917 #46916 #46915 #46914 #46913 #46912 #46911 #46910 #46909 #46908 #46907 #46906 #46905 #46903 #46902 #46901 #46900 #46899 #46898 #46897 #46896 #46895 #46894 #46893 #46892 #46891 #46890 #46889 #46888 #46887 #46886 #46885 #46884 #46883 #46882 #46881 #46880 #46879 #46878 #46877 #46876 #46875 #46874 #46873 #46872 #46871 #46870 #46869 #46868 #46867 #46866 #46865 #46864 #46863 #46862 #46861 #46860 #46859 #46858 #46857 #46856 #46855 #46854 #46853 #46852
2018-10-18 10:55:42 -04:00
Nate Borener
3b5471a734 get_url: Updates documentation for proper use of headers (#47242)
* Fixes the example for headers in documentation

* remove whitespace

* missed a whitespace
2018-10-18 09:47:27 -05:00
flowerysong
0fc639e755 ec2_tag: Fix removing tags without specifying a value (#47228) 2018-10-18 10:13:08 -04:00
Alex Stephen
3f629c426c New GCP Module: gcp_compute_region_disk (#46886) 2018-10-18 10:08:14 -04:00
Alex Stephen
bd62da4e64 New GCP Module: gcp_compute_region_disk_facts (#46887) 2018-10-18 10:06:45 -04:00
Alex Stephen
437f8622d4 New GCP Module: gcp_dns_managed_zone_facts (#46917) 2018-10-18 10:06:14 -04:00
Alex Stephen
b6c99619e4 New GCP Module: gcp_dns_resource_record_set_facts (#46919) 2018-10-18 10:04:01 -04:00
Alex Stephen
aba8ebbbf8 New GCP Module: gcp_pubsub_subscription_facts (#46921) 2018-10-18 10:03:28 -04:00
Alex Stephen
f47cfd2204 New GCP Module: gcp_pubsub_topic_facts (#46923) 2018-10-18 10:01:31 -04:00
Felix Fontein
89f239f187 Fixup of #47046. (#47274) 2018-10-18 14:50:26 +01:00
Ondra Machacek
03bccdda92 ovirt_vm: Check next_run configuration update if exist (#47280)
This PR fixes the update check method so it now check also the next_run
configuration of the virtual machine if it exists.

So if previously the VM was updated with new parameters, and then reset
back, the module didn't set the parameters to be set back in next_run.
This PR fixes it so the next run configuration is set back with proper
parameters.

Signed-off-by: Ondra Machacek <omachace@redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1639894
Signed-off-by: Ondra Machacek <omachace@redhat.com>
2018-10-18 08:41:54 -04:00
bverschueren
8a671f54dd ovirt_host_network: check for empty user_opts (#46695) 2018-10-18 08:25:54 -04:00
John R Barker
ad3579b4ab
restore ptux for Copy maintainer (#47266) 2018-10-18 11:08:26 +01:00
Felix Fontein
32e8251f86 docker_* modules: unify docker module version checks (#47046)
* Unify docker module version checks.

* Improve messages depending on required docker-py versions.

* Linting.
2018-10-18 10:51:58 +01:00
John R Barker
4991ef30c2 ROADMAP_2_8.rst link to GH project (#47265) 2018-10-18 05:49:17 -04:00
jerrejkw
44044f969d VMware: Add timeout parameter for vmware module vsphere_copy (#46762)
* Enhancement: add timeout parameter for vmware module vsphere_copy
2018-10-18 15:07:39 +05:30
Pierre-Louis Bonicoli
92103bf5d0 test-module: define ansible_version attribute
Executed command:

    ./hacking/test-module -m lib/ansible/modules/cloud/scaleway/scaleway_security_group.py -a ...

Fix this exception found while testing scaleway_security_group module:

    Traceback (most recent call last):
      File "~/debug_dir/__main__.py", line 240, in <module>
        main()
      File "~/debug_dir/__main__.py", line 236, in main
        core(module)
      File "~/debug_dir/__main__.py", line 209, in core
        api = Scaleway(module=module)
      File "~/debug_dir/ansible/module_utils/scaleway.py", line 58, in __init__
        'User-Agent': self.get_user_agent_string(module),
      File "~/debug_dir/ansible/module_utils/scaleway.py", line 99, in get_user_agent_string
        return "ansible %s Python %s" % (module.ansible_version, sys.version.split(' ')[0])
    AttributeError: 'AnsibleModule' object has no attribute 'ansible_version'
2018-10-18 09:45:56 +02:00
Pierre-Louis Bonicoli
7231f7da84 test-module: check availability of special attrs 2018-10-18 09:45:56 +02:00
Jordan Borean
5d2927c9a0
test: filesystem update note on test comment (#47260) 2018-10-18 17:10:16 +10:00
Nicolas Bock
b3dd36bef8 Fix documentation (#47218)
The result variable is `openstack_image` and not `openstack` as incorrectly stated in the description.

+label: docsite_pr
2018-10-18 17:00:08 +10:00
Matt Martz
90d2620939 Remove deprecated os_server_actions alias (#47208)
* Remove deprecated os_server_actions alias. Fixes #44991

* Skip os_server_actions
2018-10-18 16:44:44 +10:00
Jonathan Davila
d3be4f75ca pamd: use module.tmpdir for NamedTemporaryFile() (#47133) 2018-10-18 16:09:07 +10:00
Shuang Wang
0c6513e9b1 add module aws_codecommit to represent AWS CodeCommit (#46161)
* kick off

* done for the day

* beta code and test

* fix a typo

* boto3_conn and boto_exception aren't used in this code, ec2_argument_spec is used but unneeded.

* Returning when find a match avoids doing extra work, especially when pagination is involved

* add new permissions for test

* (output is changed) is preferred over accessing the attribute directly.

* pass the result through camel_dict_to_snake_dict() before returning it.

* AnsibleAWSModule automatically merges the argument_spec.

* deletes the created resources even if a test fails.

* AnsibleAWSModule automatically merges the argument_spec.

* fix typo

* fix pep8

* paginate list_repositories

* specify permissions for test

* cut the unnecessary code.

* add return doc string

* add missed ':'

* fix syntax error: mapping values are not allowed here

* add description for return

* fix syntax error

* rename module name and turn off automated integration test.
2018-10-18 14:32:06 +10:00