Commit graph

535 commits

Author SHA1 Message Date
Adam Chainz
3497582581 Fix grammar and value errors in cron documentation 2014-05-09 15:19:42 +01:00
Luca Berruti
a3d1f06cb2 Make alternatives module python 5 compatible 2014-05-08 14:46:49 +02:00
Jean-Francois Chevrette
83d79f6257 this should return 0 to indicate a non-failure when check_mode is True 2014-05-07 10:20:51 -04:00
Antti Salminen
fa607f36b5 Switch to mapper device name if pvs returns the wrong one. 2014-05-03 10:36:22 +03:00
Michael Scherer
28c373da0c Do not fail if we try to generate a ssh key for a user without being root
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.

So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
2014-04-28 12:29:57 +02:00
Chris Lamb
446765ace0 Correct/update debconf examples - need to specify vtype.
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
2014-04-23 21:51:01 +01:00
Michael Scherer
43d0fbd342 Add a better error message for service
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.

So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
2014-04-22 09:13:57 +02:00
Hernandes B. de Sousa
202fc57253 Add missing info for the append option
Both 'default' and 'choices' options were missing at the documentation.
2014-04-16 01:22:12 -03:00
James Cammarata
f547733b1f Check to make sure the firewalld client is connected before proceeding
Fixes #6911
2014-04-15 15:03:52 -05:00
Jonathan Davila
6a6ade830e Added example demonstrating other functionality 2014-04-11 11:14:40 -04:00
James Tanner
899ba4c9bb Fixes syntax error in cron module caused by #6870 2014-04-08 12:53:56 -04:00
Eric Lake
e84291d717 Adding bold to service doc to call up state and enabled. 2014-04-07 09:37:15 -05:00
MorrisA
4dc46e9061 Modified Cron to add AIX Crontab support, changed according to suggestions
from mpdehaan and redone entirely.
2014-04-05 18:10:45 -07:00
Serge van Ginderachter
2dfee9d0a7 lvg module bugfix on vg_options patch
When no vg_options are passed to the module, 'vg_options' still exists
in the module.params dict with a value of None, so the default empty string in
the get method is never used. None cannot be "splitted", which backtraced.
2014-04-04 15:32:35 +02:00
Michael DeHaan
621fcbb9de Name is not required, update docs. 2014-04-03 18:03:13 -04:00
Michael DeHaan
2fd6d16f99 Merge pull request #6831 from aresch/patch-1
Fix _parse_value always returning 0 when not true, false or None.
2014-04-02 20:09:41 -04:00
Andrew Resch
cd12d8a917 Fix _parse_value always returning 0 when not true, false or None. 2014-04-02 15:59:05 -07:00
Joshua Lund
79c245f31f Update cron module documentation. The 'name' parameter is required. 2014-04-02 16:41:09 -06:00
Michael DeHaan
90c137dea3 Slightly revise wording. 2014-04-02 17:43:40 -04:00
Michael DeHaan
dff5368e43 Merge branch 'authorized_key-manage_dir' of git://github.com/tyll/ansible into devel 2014-04-02 17:42:24 -04:00
Michael DeHaan
0981e405d6 Merge pull request #6810 from bob-smith/debconf-text
debconf detail requirements and fix typos
2014-04-02 17:25:22 -04:00
James Cammarata
eb15d2f6fe Fix issue with sysctl parameter parsing introduced by 0e8c7b1
Fixes #6806
2014-04-02 15:26:02 -05:00
Michael DeHaan
71061479a0 Merge pull request #6826 from bob-smith/debconf-parsing
debconf correctly quote strings
2014-04-02 16:14:17 -04:00
James Cammarata
684d46b170 Fixing some parsing issues in authorized_key module
Also adds an integration test for authorized_key for future validation.

Fixes #6700
2014-04-02 15:02:54 -05:00
John Barker
b8efbb1cb3 debconf correctly quote strings 2014-04-02 20:43:12 +01:00
John Barker
f89262c74f debconf detail requirements and fix typos 2014-04-01 21:51:12 +01:00
Tim G
dbf412b77c Bugfix, fix crontab commands on HP-UX 2014-04-01 21:09:08 +10:00
Michael Scherer
2dc3153330 fix typo in the capabilities module description 2014-03-30 22:33:24 +02:00
Adam Nielsen
1a9c5947ed More descriptive error message if init system is unknown 2014-03-30 11:46:13 +10:00
Ahti Kitsik
e0f3105ef9 Bugfix for ufw to support "logging" properly:
It's a separate parameter so updated docs and set it as mutually exclusive param.
Also due to an array construction typo it was not working in any situation (ufw LOGLEVEL was passed to cmd instead of ufw logging LOGLEVEL).

Also fixed doc and parameters parsing typo ("choises" should be "choices")
2014-03-29 11:06:51 +02:00
Michael DeHaan
7f7297f9ca Rename vgoptions to vg_options. 2014-03-28 12:53:36 -04:00
Michael DeHaan
b4bbdb2438 Merge branch 'devel' of git://github.com/chamill/ansible into devel
Conflicts:
	library/system/lvg
2014-03-28 12:53:00 -04:00
Michael DeHaan
0e8c7b1c03 Scrub choices=BOOLEANS from remaining core module references. Correct form in argument_spec is type='dict'. 2014-03-28 11:41:35 -04:00
Michael DeHaan
0bec29a626 Merge pull request #6524 from tyll/update_rc_d_disable
service module: Properly disable Debian services
2014-03-28 11:10:46 -04:00
Michael DeHaan
df3bb70797 Merge pull request #6630 from bigl0af/devel
Modified library/system/user so that password change date is set on Sola...
2014-03-28 10:57:59 -04:00
Michael DeHaan
3b285d736c Merge pull request #6296 from jdauphant/devel
Add linux module parameters for the modprobe module
2014-03-27 17:12:21 -04:00
Cristian Ciupitu
96ff1444f0 Micro-optimization: replace s.find(x)==0 with s.startswith(x)
timeit shows a speedup of ~1.4x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-27 20:35:20 +02:00
Ahti Kitsik
4d55f86f95 Fixed ufw module doc tags, it's reset everywhere, not reseted. 2014-03-27 17:22:39 +02:00
Seth Woodworth
c28d3545fb adds missing ' to debconf examples 2014-03-23 18:52:08 -04:00
Pierre-Louis Bonicoli
1bb5b0f6bd Fix ValueError when selection contains a colon 2014-03-23 03:35:10 +01:00
David Fox
6b0ef5f10e Modified library/system/user so that password change date is set on Solaris when updating password 2014-03-22 15:12:56 -04:00
Till Maas
c21fa8ebee service module: Properly disable Debian services
Services on Debian need to be disabled with 'disable' instead of 'remove'
to avoid them being enabled again when 'update-rc.d $service defaults' is run,
e.g. as part of a postinst script.
2014-03-20 09:19:42 +01:00
Till Maas
65deb7f50f authorized_key: Be more specific about manage_dir
- Explain which properties are managed when manage_dir is True.
2014-03-20 09:15:59 +01:00
Michael DeHaan
a8514dacc3 Add capabilities module. 2014-03-19 17:48:17 -04:00
nate@bx.psu.edu
97db1676e0 Bugfix for xattrless files and the capabilities module. 2014-03-19 17:48:17 -04:00
nate@bx.psu.edu
f26ebff438 Create a capabilities module for managing Linux kernel capabilities(7) with setcap(8). 2014-03-19 17:48:17 -04:00
James Cammarata
bc38bfe61b Merge branch 'issues/6341' of https://github.com/threatgrid/ansible into threatgrid-issues/6341 2014-03-18 10:46:39 -05:00
James Tanner
cf0a0ca3d2 Fixes #6519 Properly handle state=absent in sysctl module 2014-03-18 09:30:21 -04:00
Michael DeHaan
b471d84e52 Version bump for alternatives module, changelog. 2014-03-16 16:54:57 -04:00
Gabe Mulley
1cae0a6801 add a module for update-alternatives 2014-03-16 16:54:57 -04:00
Michael DeHaan
b0dbc61d63 Move facts to 'module_utils' so they can be referenced by other modules. Note unlike other module_utils/ dirs this keeps the original
license -- so usage of facts code in modules will be limited to GPLv3 modules.
2014-03-16 16:12:02 -04:00
Michael DeHaan
eef5a8a847 Update setup module signature from merge commit. 2014-03-16 14:11:43 -04:00
Michael DeHaan
92f9f50f1a Merge pull request #6339 from threatgrid/systemd-template-svc-fix
systemd template services must not discard template part
2014-03-16 12:40:44 -05:00
Michael DeHaan
2b2b174fd3 Merge conflict. 2014-03-16 13:36:52 -04:00
Michael DeHaan
8a07d98f4b Merge pull request #6175 from AdmiralNemo/fix-filesystem
filesystem: Ignore blkid cache
2014-03-16 12:31:53 -05:00
Michael DeHaan
8920990d63 Merge pull request #6097 from mattjeffery/bug/modprobe_normalise_name
Normalise the module name when comparing against the module names in /proc/modules
2014-03-16 12:31:17 -05:00
Michael DeHaan
5aef2f0687 Merge pull request #6005 from pgehres/chkconfig
Adding better failure output for chkconfig failures
2014-03-16 12:27:46 -05:00
Cristian Ciupitu
138b45e32f hostname module: don't filter hostnamectl with awk
There's no need to filter hostnamectl's output with awk because its man
page says:

    hostnamectl [OPTIONS...] {COMMAND}

       --static, --transient, --pretty
	   If status is used (or no explicit command is given) and one
	   of those fields is given, hostnamectl will print out just
           this selected hostname.

E.g. hostnamectl --static status => ansible.example.org
2014-03-16 13:10:28 -04:00
Cristian Ciupitu
0749112286 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-16 13:10:28 -04:00
James Tanner
9d6518de5a Fixes #6482 Check sysctl file path and catch read exceptions 2014-03-14 11:16:45 -04:00
Michael DeHaan
4e8b97ddeb More shell updates 2014-03-12 17:31:00 -04:00
Richard C Isaacson
154f123b7f setup module: Mark unsafe commands as use_unsafe_shell=True. 2014-03-12 11:13:20 -05:00
Ryan
e4805fe411 add module param to Network & sub-classes
add module param to Network and sub-classes of Network, so that ansible 1.5.1 changes to LinuxNetwork apply to all Network classes.
2014-03-12 09:37:12 -04:00
Michael DeHaan
c8db3c2db9 Revert "Fix issue#6430 by instantiating Network() with expected arguments"
This reverts commit 2a723e908e.
2014-03-12 09:23:13 -04:00
James Laska
2a723e908e Fix issue#6430 by instantiating Network() with expected arguments 2014-03-12 09:04:42 -04:00
Richard C Isaacson
a1c87e6deb Fix docstring issue. 2014-03-11 16:23:18 -05:00
Richard Isaacson
6e13c1ebe0 Merge pull request #6406 from risaacson/at_module2
This fixes what was merged in 1.5.0.
2014-03-11 15:27:51 -05:00
James Tanner
c73cb77689 Fix name in locale_gen docstring 2014-03-11 16:13:55 -04:00
James Tanner
41b7badb13 Fix snippet imports and version_added in ufw module 2014-03-11 16:07:08 -04:00
James Cammarata
1d6750afec Merge pull request #5518 from pyykkis/ufw
UFW module (another take)
2014-03-11 15:03:33 -05:00
James Tanner
8ffb964f45 Set version_added for locale_gen 2014-03-11 15:56:30 -04:00
James Tanner
da95310d86 Rename locale module to locale_gen 2014-03-11 15:55:26 -04:00
James Cammarata
74335b6e59 Merge pull request #5411 from AugustusKling/locale
locale module
2014-03-11 14:54:36 -05:00
Michael DeHaan
fd9df5f429 Merge pull request #6372 from mriedelumab/devel
Returning 'NA' when no virtualization found
2014-03-11 10:17:22 -05:00
James Tanner
ba0fec4f42 Force command action to not be executed by the shell unless specifically enabled 2014-03-10 16:13:30 -05:00
Matthew Riedel
5875d19f4d Returning 'NA' when no virtualization found 2014-03-10 11:58:04 -04:00
Richard C Isaacson
c6fbb0059b Some cleanup. 2014-03-10 10:31:08 -05:00
Charles Duffy
18f53d9219 #6341: use shared function for parsing systemd status; check rc code 2014-03-10 01:05:48 -05:00
Charles Duffy
d59973295d #6341: check systemd service status with show subcommand 2014-03-10 00:09:29 -05:00
Jarno Keskikangas
37ef39d0fa Recognize rule changes even if ufw is in disabled state.
See http://askubuntu.com/questions/30781/see-configured-rules-even-when-inactive
for the details.
2014-03-09 12:56:52 +02:00
Jarno Keskikangas
4d5340587e Insert rule to a specific num. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
0247708199 Fix typo: 'reseted' -> 'reset'. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
2613e6fb14 Add protocol options 'esp' and 'ah'. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
f4e8a86c87 Add functionality and reduce complexity.
* Separate 'state', 'policy' and 'rule' commands
* Support for 'logging' command
* Support for 'direction' and 'interface' attributes
* Reliable change notifications based on 'ufw status verbose' diff
* Update documentation
* Cleanup
2014-03-09 12:56:51 +02:00
Aleksey Ovcharenko
651c04a3ec New module [ufw]: this module handles Ubuntu UFW operations
* Updated documentation related to IPv6 usage.

BugFixes:
* Solved the default_policy and state mutual exclusive status.
* Fixed changed status for IPv6 addresses.

Added @otnateos patch.
2014-03-09 12:56:51 +02:00
Richard C Isaacson
aba86e3657 Cleaning up pep8 alerts. 2014-03-07 23:06:19 -06:00
Richard C Isaacson
f3c1177265 Documentation cleanup. 2014-03-07 23:04:56 -06:00
Richard C Isaacson
7686204b43 Refactored a few things to be more inline with the Ansible way. Passing testing. 2014-03-07 23:04:07 -06:00
Charles Duffy
44ebd3f4f3 systemd template services must not discard template part 2014-03-07 18:53:15 -06:00
jctanner
6a615f18c5 Merge pull request #5872 from tomdymond/add-ignoreerror-to-sysctl
Add option to enable the sysctl -e option
2014-03-05 12:58:05 -05:00
Julien DAUPHANT
16bb6c88f5 Add version_added 1.6 for the params modprobe option 2014-03-05 16:45:20 +01:00
Julien DAUPHANT
daa7416323 Add linux module parameters for the modprobe module 2014-03-05 16:42:52 +01:00
anatoly techtonik
a48f0da9d8 setup: Fix KeyError: 'ipv4_secondaries' (issue #6274) 2014-03-04 20:00:18 +02:00
James Tanner
39e368b713 Fix debconf docstring indentation 2014-03-03 13:48:44 -05:00
James Tanner
ff1ae57fbf Merge branch 'debconf' of git://github.com/bcoca/ansible into bcoca-debconf 2014-03-03 13:46:11 -05:00
Brian Coca
400a1aa49a didnt make 1.5 ... lets see 2014-03-01 22:28:51 -05:00
Brian Coca
68510ecda8 added better gentoo/funtoo support 2014-03-01 21:56:02 -05:00
Michael DeHaan
9d3a344c06 Merge pull request #6223 from lvh/patch-2
Support ssh-ed25519 keys
2014-02-28 12:59:05 -05:00
Laurens Van Houtven
80e2c597a8 Support ssh-ed25519 keys
The newest version of OpenSSH supports a new, wonderful key type. authorized_key incorrectly discards pubkeys of this type as busted because it doesn't recognize type signature.
2014-02-28 18:46:54 +01:00
James Cammarata
57486b268a Use the no-user-groups option (-N) for useradd in the user module
If no group was specified, but a group by the same name as the user
exists, an error was raised in the situation where USERGROUPS_ENAB is
enabled in /etc/login.defs (which is the case for almost every major
linux distro). In this case, the user will be put in group 100 (which
is usually the "users" group on those same distros). This is currently
only done in the base class, as the issue may not exist on other
platforms like AIX or the BSDs.

Fixes #6210
2014-02-28 11:46:27 -06:00