c9b212c5bd
When a task result has an empty results list, the
list should be ignored when determining the results
of `_check_key`. Here the empty list is treated the
same as a non-existent list.
This fixes a bug that manifests itself with squashed
items - namely the task result contains the correct
value for the key, but an empty results list. The
empty results list was treated as zero failures
when deciding which handler to call - so the task
show as a success in the output, but is deemed to
have failed when deciding whether to continue.
This also demonstrates a mismatch between task
result processing and play iteration.
A test is also added for this case, but it would not
have caught the bug - because the bug is really in
the display, and not the success/failure of the
task (visually the test is more accurate).
Fixes ansible/ansible-modules-core#4214
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| group_vars | ||
| host_vars | ||
| lookup_paths | ||
| roles | ||
| test_blocks | ||
| vars | ||
| all.yml | ||
| amazon.yml | ||
| azure.yml | ||
| bad_parsing.yml | ||
| check_mode.yml | ||
| cleanup_azure.py | ||
| cleanup_ec2.py | ||
| cleanup_gce.py | ||
| cleanup_rax.py | ||
| cloudflare.yml | ||
| cloudstack.yml | ||
| consul.yml | ||
| consul_inventory.yml | ||
| consul_running.py | ||
| credentials.template | ||
| destructive.yml | ||
| galaxy_playbook.yml | ||
| galaxy_playbook_git.yml | ||
| galaxy_roles.yml | ||
| galaxy_rolesfile | ||
| gce.yml | ||
| gce_credentials.py | ||
| good_parsing.yml | ||
| integration_config.yml | ||
| inventory | ||
| inventory.group_by | ||
| inventory.handlers | ||
| inventory.local | ||
| inventory.winrm.template | ||
| lookup.ini | ||
| lookup.properties | ||
| Makefile | ||
| no_log_local.yml | ||
| non_destructive.yml | ||
| rackspace.yml | ||
| README.md | ||
| setup_gce.py | ||
| test_async.yml | ||
| test_connection.inventory | ||
| test_connection.yml | ||
| test_connection_winrm.yml | ||
| test_delegate_to.yml | ||
| test_environment.yml | ||
| test_filters.yml | ||
| test_force_handlers.yml | ||
| test_gathering_facts.yml | ||
| test_group_by.yml | ||
| test_handlers.yml | ||
| test_hash.yml | ||
| test_includes.yml | ||
| test_includes2.yml | ||
| test_lookup_properties.yml | ||
| test_setup.yml | ||
| test_tags.yml | ||
| test_templating_settings.yml | ||
| test_test_infra.yml | ||
| test_var_precedence.yml | ||
| test_vault.yml | ||
| test_winrm.yml | ||
| unicode-test-script | ||
| unicode.yml | ||
| vars_file.yml | ||
| vault-password | ||
| vault-secret.txt | ||
Integration tests
The ansible integration system.
Tests for playbooks, by playbooks.
Some tests may require credentials. Credentials may be specified with credentials.yml.
Tests should be run as root.
Configuration
Making your own version of integration_config.yml can allow for setting some
tunable parameters to help run the tests better in your environment. Some
tests (e.g. cloud) will only run when access credentials are provided. For
more information about supported credentials, refer to credentials.template.
Prerequisites
The tests will assume things like hg, svn, and git are installed and in path.
(Complete list pending)
Non-destructive Tests
These tests will modify files in subdirectories, but will not do things that install or remove packages or things outside of those test subdirectories. They will also not reconfigure or bounce system services.
Run as follows:
make non_destructive
You can select specific tests with the --tags parameter.
TEST_FLAGS="--tags test_vars_blending" make
Destructive Tests
These tests are allowed to install and remove some trivial packages. You will likely want to devote these to a virtual environment. They won't reformat your filesystem, however :)
make destructive
Cloud Tests
Cloud tests exercise capabilities of cloud modules (e.g. ec2_key). These are not 'tests run in the cloud' so much as tests that leverage the cloud modules and are organized by cloud provider.
In order to run cloud tests, you must provide access credentials in a file
named credentials.yml. A sample credentials file named
credentials.template is available for syntax help.
Provide cloud credentials: cp credentials.template credentials.yml ${EDITOR:-vi} credentials.yml
Run the tests: make cloud
WARNING running cloud integration tests will create and destroy cloud resources. Running these tests may result in additional fees associated with your cloud account. Care is taken to ensure that created resources are removed. However, it is advisable to inspect your AWS console to ensure no unexpected resources are running.
Windows Tests
These tests exercise the winrm connection plugin and Windows modules. You'll need to define an inventory with a remote Windows 2008 or 2012 Server to use for testing, and enable PowerShell Remoting to continue.
Running these tests may result in changes to your Windows host, so don't run them against a production/critical Windows environment.
Enable PowerShell Remoting (run on the Windows host via Remote Desktop): Enable-PSRemoting -Force
Define Windows inventory: cp inventory.winrm.template inventory.winrm ${EDITOR:-vi} inventory.winrm
Run the tests: make test_winrm