ansible/test
Trishna Guha 30aba1a7fd nxos_vlan purge fix 2.8 (#57442)
* nxos_vlan: fix broken purge behavior (issue #57101) (#57229)

* nxos_vlan: fix broken purge behavior (issue #57101)

Symptoms/Analysis:
- `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1.
- `nxos` devices do not allow removing vlan 1 and raise a cli exception error
- Previous fix #55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g.
 - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true`
 - results in proper purging but vlan 4 is not created

Solutions:
- ignore vlan 1 when purging
- remove the `not purge` check from state present logic

Added additional unit tests and integration tests.
Tested against all regression platforms.

* PEP fixes

* Add agg_show_vlan_brief.txt fixture

* Add warning for removing vlan 1

* change method name check

(cherry picked from commit 6bb13bbb84)

* changelog

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-06-11 19:50:35 -07:00
..
cache
env Add env command to ansible-test and run in CI. (#50176) 2018-12-20 22:08:57 -08:00
integration nxos_vlan purge fix 2.8 (#57442) 2019-06-11 19:50:35 -07:00
legacy Migrate Scaleway tests to integration tests 2019-04-09 15:41:30 -07:00
results
runner [stable-2.8] Limit tests to paramiko < 2.5.0. 2019-06-10 16:13:20 -07:00
sanity [stable-2.8] Validate types before asserting lengths (#56882) 2019-05-24 11:33:24 -07:00
units nxos_vlan purge fix 2.8 (#57442) 2019-06-11 19:50:35 -07:00
utils Add Hetzner Cloud to CI integration tests. 2019-04-09 15:41:50 -07:00