ca13e678ae
* Fix unit test parametrize order on Python 3.5. (cherry picked from commit53b230ca74
) * Fix ansible-test unit test execution. (#45772) * Fix ansible-test units requirements install. * Run unit tests as unprivileged user under Docker. (cherry picked from commit379a7f4f5a
) * Run unit tests in parallel. (#45812) (cherry picked from commitabe8e4c9e8
) * Minor fixes for unit test delegation. (cherry picked from commitbe199cfe90
) * add support for opening shell on remote Windows host (#43919) * add support for opening shell on remote Windows host * added arg completion and fix sanity check * remove uneeded arg (cherry picked from commit6ca4ea0c1f
) * Block network access for unit tests in docker. (cherry picked from commit99cac99cbc
) * Make ansible-test available in the bin directory. (#45876) (cherry picked from commitf3d1f9544b
) * Support comments in ansible-test flat files. (cherry picked from commit5a3000af19
) * Fix incorrect use of subprocess.CalledProcessError (#45890) (cherry picked from commit24dd87bd0a
) * Improve ansible-test match error handling. (cherry picked from commit2056c981ae
) * Improve error handling for docs-build test. (cherry picked from commit2148999048
) * Bug fixes and cleanup for ansible-test. (#45991) * Remove unused imports. * Clean up ConfigParser usage in ansible-test. * Fix bare except statements in ansible-test. * Miscellaneous cleanup from PyCharm inspections. * Enable pylint no-self-use for ansible-test. * Remove obsolete pylint ignores for Python 3.7. * Fix shellcheck issuers under newer shellcheck. * Use newer path for ansible-test. * Fix issues in code-smell tests. (cherry picked from commitac492476e5
) * Fix integration test library search path. This prevents tests from loading modules outside the source tree, which could result in testing the wrong module if a system-wide install is present, or custom modules exist. (cherry picked from commitd603cd41fe
) * Update default container to version 1.2.0. (cherry picked from commitd478a4c3f6
) (cherry picked from commit21c4eb8db5
) * Fix ansible-test docker python version handling. This removes the old name based version detection behavior and uses versions defined in the docker completion file instead, as the new containers do not follow the old naming scheme. (cherry picked from commit54937ba784
) * Reduce noise in docs-build test failures. (cherry picked from commit4085d01617
) * Fix ansible-test encoding issues for exceptions. (cherry picked from commit0d7a156319
) * Fix ansible-test multi-group smoke test handling. (#46363) * Fix ansible-test smoke tests across groups. * Fix ansible-test list arg defaults. * Fix ansible-test require and exclude delegation. * Fix detection of Windows specific changes. * Add minimal Windows testing for Python 3.7. (cherry picked from commite53390b3b1
) * Use default-test-container version 1.3.0. (cherry picked from commit6d9be66418
) * Add file exists check in integration-aliases test. (cherry picked from commit33a8be9109
) * Improve ansible-test environment checking between tests. (#46459) * Add unified diff output to environment validation. This makes it easier to see where the environment changed. * Compare Python interpreters by version to pip shebangs. This helps expose cases where pip executables use a different Python interpreter than is expected. * Query `pip.__version__` instead of using `pip --version`. This is a much faster way to query the pip version. It also more closely matches how we invoke pip within ansible-test. * Remove redundant environment scan between tests. This reuses the environment scan from the end of the previous test as the basis for comparison during the next test. (cherry picked from commit0dc7f38787
) * Add symlinks sanity test. (#46467) * Add symlinks sanity test. * Replace legacy test symlinks with actual content. * Remove dir symlink from template_jinja2_latest. * Update import test to use generated library dir. * Fix copy test symlink setup. (cherry picked from commite2b6047514
) * Fix parametrize warning in unit tests. (cherry picked from commit1a28898a00
) * Update MANIFEST.in (#46502) * Update MANIFEST.in: - Remove unnecessary prune. - Include files needed by tests. - Exclude botmeta sanity test. These changes permit sanity tests to pass on sdist output. (cherry picked from commitcbb49f66ec
) * Fix unit tests which modify the source tree. (#45763) * Fix CNOS unit test log usage. * Use temp dir for Galaxy unit tests. * Write to temp files in interfaces_file unit test. * Fix log placement in netapp_e_ldap unit test. (cherry picked from commit0686450cae
) * Fix ansible-test custom docker image traceback. (cherry picked from commit712ad9ed64
) * ansible-test: Create public key creating Windows targets (#43760) * ansible-test: Create public key creating Windows targets * Changed to always set SSH Key for Windows hosts (cherry picked from commitadc0efe10c
) * Fix and re-enable sts_assume_role integration tests (#46026) * Fix the STS assume role error message assertion when the role to assume does not exist. (cherry picked from commit18dc928e28
) * Fix ACI unit test on Python 3.7.0. The previous logic was only needed for pre-release versions of 3.7. (cherry picked from commitc0bf9815c9
) * Remove placeboify from unit tests that are not calling AWS (i.e. creating a recording) (#45754) (cherry picked from commit2167ce6cb6
) * Update sanity test ignore entries.
100 lines
4.3 KiB
Python
100 lines
4.3 KiB
Python
import pytest
|
|
|
|
from ansible.module_utils.database import (
|
|
pg_quote_identifier,
|
|
SQLParseError,
|
|
)
|
|
|
|
# These are all valid strings
|
|
# The results are based on interpreting the identifier as a table name
|
|
VALID = {
|
|
# User quoted
|
|
'"public.table"': '"public.table"',
|
|
'"public"."table"': '"public"."table"',
|
|
'"schema test"."table test"': '"schema test"."table test"',
|
|
|
|
# We quote part
|
|
'public.table': '"public"."table"',
|
|
'"public".table': '"public"."table"',
|
|
'public."table"': '"public"."table"',
|
|
'schema test.table test': '"schema test"."table test"',
|
|
'"schema test".table test': '"schema test"."table test"',
|
|
'schema test."table test"': '"schema test"."table test"',
|
|
|
|
# Embedded double quotes
|
|
'table "test"': '"table ""test"""',
|
|
'public."table ""test"""': '"public"."table ""test"""',
|
|
'public.table "test"': '"public"."table ""test"""',
|
|
'schema "test".table': '"schema ""test"""."table"',
|
|
'"schema ""test""".table': '"schema ""test"""."table"',
|
|
'"""wat"""."""test"""': '"""wat"""."""test"""',
|
|
# Sigh, handle these as well:
|
|
'"no end quote': '"""no end quote"',
|
|
'schema."table': '"schema"."""table"',
|
|
'"schema.table': '"""schema"."table"',
|
|
'schema."table.something': '"schema"."""table"."something"',
|
|
|
|
# Embedded dots
|
|
'"schema.test"."table.test"': '"schema.test"."table.test"',
|
|
'"schema.".table': '"schema."."table"',
|
|
'"schema."."table"': '"schema."."table"',
|
|
'schema.".table"': '"schema".".table"',
|
|
'"schema".".table"': '"schema".".table"',
|
|
'"schema.".".table"': '"schema.".".table"',
|
|
# These are valid but maybe not what the user intended
|
|
'."table"': '".""table"""',
|
|
'table.': '"table."',
|
|
}
|
|
|
|
INVALID = {
|
|
('test.too.many.dots', 'table'): 'PostgreSQL does not support table with more than 3 dots',
|
|
('"test.too".many.dots', 'database'): 'PostgreSQL does not support database with more than 1 dots',
|
|
('test.too."many.dots"', 'database'): 'PostgreSQL does not support database with more than 1 dots',
|
|
('"test"."too"."many"."dots"', 'database'): "PostgreSQL does not support database with more than 1 dots",
|
|
('"test"."too"."many"."dots"', 'schema'): "PostgreSQL does not support schema with more than 2 dots",
|
|
('"test"."too"."many"."dots"', 'table'): "PostgreSQL does not support table with more than 3 dots",
|
|
('"test"."too"."many"."dots"."for"."column"', 'column'): "PostgreSQL does not support column with more than 4 dots",
|
|
('"table "invalid" double quote"', 'table'): 'User escaped identifiers must escape extra quotes',
|
|
('"schema "invalid"""."table "invalid"', 'table'): 'User escaped identifiers must escape extra quotes',
|
|
('"schema."table"', 'table'): 'User escaped identifiers must escape extra quotes',
|
|
('"schema".', 'table'): 'Identifier name unspecified or unquoted trailing dot',
|
|
}
|
|
|
|
HOW_MANY_DOTS = (
|
|
('role', 'role', '"role"',
|
|
'PostgreSQL does not support role with more than 1 dots'),
|
|
('db', 'database', '"db"',
|
|
'PostgreSQL does not support database with more than 1 dots'),
|
|
('db.schema', 'schema', '"db"."schema"',
|
|
'PostgreSQL does not support schema with more than 2 dots'),
|
|
('db.schema.table', 'table', '"db"."schema"."table"',
|
|
'PostgreSQL does not support table with more than 3 dots'),
|
|
('db.schema.table.column', 'column', '"db"."schema"."table"."column"',
|
|
'PostgreSQL does not support column with more than 4 dots'),
|
|
)
|
|
|
|
VALID_QUOTES = ((test, VALID[test]) for test in sorted(VALID))
|
|
INVALID_QUOTES = ((test[0], test[1], INVALID[test]) for test in sorted(INVALID))
|
|
|
|
|
|
@pytest.mark.parametrize("identifier, quoted_identifier", VALID_QUOTES)
|
|
def test_valid_quotes(identifier, quoted_identifier):
|
|
assert pg_quote_identifier(identifier, 'table') == quoted_identifier
|
|
|
|
|
|
@pytest.mark.parametrize("identifier, id_type, msg", INVALID_QUOTES)
|
|
def test_invalid_quotes(identifier, id_type, msg):
|
|
with pytest.raises(SQLParseError) as ex:
|
|
pg_quote_identifier(identifier, id_type)
|
|
|
|
ex.match(msg)
|
|
|
|
|
|
@pytest.mark.parametrize("identifier, id_type, quoted_identifier, msg", HOW_MANY_DOTS)
|
|
def test_how_many_dots(identifier, id_type, quoted_identifier, msg):
|
|
assert pg_quote_identifier(identifier, id_type) == quoted_identifier
|
|
|
|
with pytest.raises(SQLParseError) as ex:
|
|
pg_quote_identifier('%s.more' % identifier, id_type)
|
|
|
|
ex.match(msg)
|