ansible/changelogs/fragments/no-template-conn-err.yaml at 63566334f67923df94e8340d61e1e09c42325bab - wbrawner/ansible - Forgejo: Beyond coding. We forge.

wbrawner/ansible

Toshio Kuratomi c264061272 Bkprt conn err msg no template (#37381 )

*  Connection error messages are unsafe: wrap them (#37329)

* Check that connection error msg are not unsafe

* Connection error messages are unsafe: wrap them

For example, in case of error, docker connection plugin returns exception
message containing Go template. These messages weren't tagged as unsafe
and were consequently rendered:

The conditional check 'result is failed' failed. The error was:
{
  'msg': u'Docker version check ([\'/usr/bin/docker\', \'version\', \'--format\', "\'{{.Server.Version}}\'"]) failed: Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get http://%2Fvar%2Frun%2Fdocker.sock/v1.35/version: dial unix /var/run/docker.sock: connect: permission denied\n',
  'failed': True
}:
template error while templating string: unexpected '.'.
String: Docker version check (['/usr/bin/docker', 'version', '--format', "'{{.Server.Version}}'"]) failed: Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get http://%2Fvar%2Frun%2Fdocker.sock/v1.35/version: dial unix /var/run/docker.sock: connect: permission denied

(cherry picked from commit 4378542ac7)

* Add a changelog for the no-template error message fix

2018-03-15 13:52:33 -07:00

4 lines

208 B

YAML

Raw Blame History

 bugfixes:
   - Connection error messages may contain characters that jinja2 would
     interpret as a template.  Wrap the error string so this doesn't happen
     (https://github.com/ansible/ansible/pull/37329)