d64a352a40
* Fix redundant yaml error blurbs on ModArgs parse errors
Some of the AnsibleParserErrors from parsing.mod_args
are created with the obj=some_yaml_ds options but
some are not.
If they were, we don't want to add another yaml_ds to
it, because that will result in double yaml error blurbs.
And since we dont need to add info, we can just re raise it.
But if there is no ._obj, add it here so we get the extra
detail in the error message (see issue #14790) and raise
a new AnsibleParserError instance.
Fixes #36848
* cleanup existing test_tasks pep8/sanity issues
(cherry picked from commit e166946a0a)
114 lines
3.5 KiB
Python
114 lines
3.5 KiB
Python
# (c) 2012-2014, Michael DeHaan <michael.dehaan@gmail.com>
|
|
#
|
|
# This file is part of Ansible
|
|
#
|
|
# Ansible is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Ansible is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Make coding more python3-ish
|
|
from __future__ import (absolute_import, division, print_function)
|
|
__metaclass__ = type
|
|
|
|
from ansible.compat.tests import unittest
|
|
from ansible.compat.tests.mock import patch
|
|
from ansible.playbook.task import Task
|
|
from ansible.parsing.yaml import objects
|
|
from ansible import errors
|
|
|
|
|
|
basic_command_task = dict(
|
|
name='Test Task',
|
|
command='echo hi'
|
|
)
|
|
|
|
kv_command_task = dict(
|
|
action='command echo hi'
|
|
)
|
|
|
|
# See #36848
|
|
kv_bad_args_str = '- apk: sdfs sf sdf 37'
|
|
kv_bad_args_ds = {'apk': 'sdfs sf sdf 37'}
|
|
|
|
|
|
class TestTask(unittest.TestCase):
|
|
|
|
def setUp(self):
|
|
pass
|
|
|
|
def tearDown(self):
|
|
pass
|
|
|
|
def test_construct_empty_task(self):
|
|
Task()
|
|
|
|
def test_construct_task_with_role(self):
|
|
pass
|
|
|
|
def test_construct_task_with_block(self):
|
|
pass
|
|
|
|
def test_construct_task_with_role_and_block(self):
|
|
pass
|
|
|
|
def test_load_task_simple(self):
|
|
t = Task.load(basic_command_task)
|
|
assert t is not None
|
|
self.assertEqual(t.name, basic_command_task['name'])
|
|
self.assertEqual(t.action, 'command')
|
|
self.assertEqual(t.args, dict(_raw_params='echo hi'))
|
|
|
|
def test_load_task_kv_form(self):
|
|
t = Task.load(kv_command_task)
|
|
self.assertEqual(t.action, 'command')
|
|
self.assertEqual(t.args, dict(_raw_params='echo hi'))
|
|
|
|
@patch.object(errors.AnsibleError, '_get_error_lines_from_file')
|
|
def test_load_task_kv_form_error_36848(self, mock_get_err_lines):
|
|
ds = objects.AnsibleMapping(kv_bad_args_ds)
|
|
ds.ansible_pos = ('test_task_faux_playbook.yml', 1, 1)
|
|
mock_get_err_lines.return_value = (kv_bad_args_str, '')
|
|
|
|
with self.assertRaises(errors.AnsibleParserError) as cm:
|
|
Task.load(ds)
|
|
|
|
self.assertIsInstance(cm.exception, errors.AnsibleParserError)
|
|
self.assertEqual(cm.exception._obj, ds)
|
|
self.assertEqual(cm.exception._obj, kv_bad_args_ds)
|
|
self.assertIn("The error appears to have been in 'test_task_faux_playbook.yml", cm.exception.message)
|
|
self.assertIn(kv_bad_args_str, cm.exception.message)
|
|
self.assertIn('apk', cm.exception.message)
|
|
self.assertEquals(cm.exception.message.count('The offending line'), 1)
|
|
self.assertEquals(cm.exception.message.count('The error appears to have been in'), 1)
|
|
|
|
def test_task_auto_name(self):
|
|
assert 'name' not in kv_command_task
|
|
Task.load(kv_command_task)
|
|
# self.assertEqual(t.name, 'shell echo hi')
|
|
|
|
def test_task_auto_name_with_role(self):
|
|
pass
|
|
|
|
def test_load_task_complex_form(self):
|
|
pass
|
|
|
|
def test_can_load_module_complex_form(self):
|
|
pass
|
|
|
|
def test_local_action_implies_delegate(self):
|
|
pass
|
|
|
|
def test_local_action_conflicts_with_delegate(self):
|
|
pass
|
|
|
|
def test_delegate_to_parses(self):
|
|
pass
|