ansible/test
Jordan Borean 69a36a3fa7 Fix remote_tmp when become with non admin user (#42396)
* Fix tmpdir on non root become

 - also avoid exception if tmpdir and remote_tmp are None
 - give 'None' on deescalation so tempfile will fallback to it's default behaviour
   and use system dirs
 - fix issue with bad tempdir (not existing/not createable/not writeable)
   i.e nobody and ~/.ansible/tmp
 - added tests for blockfile case

* Revert "Temporarily revert c119d54"

This reverts commit 5c614a59a6.

* changes based on PR feedback and changelog fragment

* changes based on the review

* Fix tmpdir when makedirs failed so we just use the system tmp

* Let missing remote_tmp fail

If remote_tmp is missing then there's something more basic wrong in the
communication from the controller to the module-side.  It's better to
be alerted in this case than to silently ignore it.

jborean and I have independently checked what happens if the user sets
ansible_remote_tmp to empty string and !!null and both cases work fine.
(null is turned into a default value controller-side.  empty string
triggers the warning because it is probably not a directory that the
become user is able to use).

(cherry picked from commit 8bdd04c147)
2018-07-16 17:53:06 -07:00
..
cache
integration Fix remote_tmp when become with non admin user (#42396) 2018-07-16 17:53:06 -07:00
legacy Fix some broken links (#42079) 2018-06-29 15:30:49 -07:00
results
runner Temporarily switch RHEL and Windows tests to AWS. 2018-07-10 15:17:04 -07:00
sanity nxos and eos bugfix pick2.6 (#42291) 2018-07-09 11:31:57 -07:00
units Fix remote_tmp when become with non admin user (#42396) 2018-07-16 17:53:06 -07:00
utils Remove unwanted containers at CI job start. 2018-07-09 21:50:04 -07:00