wbrawner/hoedown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

allow the HOEDOWN_EXT_UNDERLINE to work

Browse source 
When the `HOEDOWN_EXT_UNDERLINE` extension was enabled, underlined spans
would actually be passed verbatim to the output buffer. This was because
the active_char was _only_ set when the emphasis, double_emphasis, or
triple_emphasis handlers were registered. As a result, no active char
was found in the input buffer, so everything was passed through
verbatim.

This patch fixes this by also registering the `active_char` if the
underline handler is registered. I also added a simple regression test.

I personally don't use this extension, but I encountered this bug over
the course of writing bindings for Rust.
This commit is contained in:
Jorge Israel Peña 2015-01-30 19:02:37 -08:00
parent fd09d02ca6
commit 9b789d24a5
4 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/document.c
View file

@ -2751,7 +2751,7 @@ hoedown_document_new(
memset(doc->active_char, 0x0, 256);
if (doc->md.emphasis || doc->md.double_emphasis || doc->md.triple_emphasis) {
if (doc->md.emphasis || doc->md.double_emphasis || doc->md.triple_emphasis || doc->md.underline) {
doc->active_char['*'] = MD_CHAR_EMPHASIS;
doc->active_char['_'] = MD_CHAR_EMPHASIS;
if (extensions & HOEDOWN_EXT_STRIKETHROUGH)

1
test/Tests/Underline.html Normal file
View file

@ -0,0 +1 @@
<p>This <u>underline</u> will work.</p>

1
test/Tests/Underline.text Normal file
View file

@ -0,0 +1 @@
This _underline_ will work.

5
test/config.json
View file

@ -101,6 +101,11 @@
"input": "Tests/Math.text",
"output": "Tests/Math.html",
"flags": ["--math"]
},
{
"input": "Tests/Underline.text",
"output": "Tests/Underline.html",
"flags": ["--underline"]
}
]
}