From 3859b3c69e2acfbb86a58e146e664652bd9ff22d Mon Sep 17 00:00:00 2001 From: Dominyk Tiller Date: Mon, 6 Apr 2015 17:08:28 +0100 Subject: [PATCH] fontforge: remove redundant post-install The install-name error was rectified by the latest release and the whole post-install block can be killed. Yay! Note to self: When merged close https://github.com/fontforge/fontforge/issues/2022. Closes Homebrew/homebrew#38410. Signed-off-by: Tim D. Smith --- Formula/fontforge.rb | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/Formula/fontforge.rb b/Formula/fontforge.rb index 5004708907..95f27acf24 100644 --- a/Formula/fontforge.rb +++ b/Formula/fontforge.rb @@ -85,21 +85,8 @@ class Fontforge < Formula system "./configure", *args system "make" system "make", "install" - end - - def post_install - # Link this to enable symlinking into /Applications with brew linkapps. - # The name is case-sensitive. It breaks without both F's capitalised. - # If you build with x11 now, it automatically creates an dynamic link from bin/fontforge - # to @executable_path/../Frameworks/Breakpad.framework/Versions/A/Breakpad which - # obviously doesn't exist given fontforge and FontForge.app are in different places. - # If this isn't fixed within a couple releases, consider dumping everything in libexec. - # https://github.com/fontforge/fontforge/issues/2022 - if build.with? "x11" - ln_s "#{share}/fontforge/osx/FontForge.app", prefix - system "install_name_tool", "-change", "@executable_path/../Frameworks/Breakpad.framework/Versions/A/Breakpad", - "#{bin}/fontforge", "#{share}/fontforge/osx/FontForge.app/Contents/Frameworks/Breakpad.framework/Versions/A/Breakpad" - end + # The name is case-sensitive. Don't downcase it when linking. + ln_s "#{share}/fontforge/osx/FontForge.app", prefix if build.with? "x11" end test do