From ecc7bdd8435ec3965ac7095efdead3bb49f378ed Mon Sep 17 00:00:00 2001 From: Zhiming Wang Date: Sat, 20 Aug 2016 22:18:51 +0800 Subject: [PATCH] emacs: disable --with-file-notification=gfile unless stable (#4067) --with-file-notification=gfile support on OS X has been removed in Emacs 25 (supplanted by kqueue(2) support), and even leads to a configure error since https://github.com/emacs-mirror/emacs/commit/21ad7279e47f0bc33acf36f0ac27f92808232dbd. Fixes #4048. --- Formula/emacs.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Formula/emacs.rb b/Formula/emacs.rb index 81e812e2ec..3914e0e6a7 100644 --- a/Formula/emacs.rb +++ b/Formula/emacs.rb @@ -42,6 +42,8 @@ class Emacs < Formula depends_on "librsvg" => :recommended depends_on "imagemagick" => :optional depends_on "mailutils" => :optional + # Remove this option and the --with-file-notification=gfile line below once + # Emacs 25 is stable (#4048) depends_on "glib" => :optional def install @@ -54,7 +56,7 @@ class Emacs < Formula --without-x ] - args << "--with-file-notification=gfile" if build.with? "glib" + args << "--with-file-notification=gfile" if build.stable? && build.with?("glib") if build.with? "libxml2" args << "--with-xml2"