When interpolating in strings passed to Formula#system, it should be
done in such a way that if any interpolated variables contain spaces,
they are either (a) passed as part of a list or (b) protected by quotes
if they are part of a long string (which is subject to shell expansion).
Otherwise, they will be split on the space when expanded by the shell
and passed as multiple arguments to whatever process is being executed.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
When `--with-glib` is passed to the Poppler formula, then glib should be added
to the dependency list.
This patch also changes the way dependencies are specified to `configure` so
that it will fail if something this derpy happens again.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Adding paths to `/usr/X11` through ENV.x11 allows Poppler's configure script to
find Fontconfig without resorting to patching `Makefile.in`.
Tested on OS X 10.5.x and 10.6.x
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Consolidate `pkg-config` query into one command. Add Homebrew lib directory to
LDFLAGS so that Qt Frameworks can be found on 10.5.0 where
`libtool` strips the `-F` flag unless it is preceded by `-Wl`.
Move patch explanation into the patch.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
* Use new "url" features
* Use keg_only DSL
* Use "skip_clean :all" DSL
* Whitespace and style cleanups
* Make bash invocations less silly
* Use new man2-man8 helpers
* Remove "FileUtils." since it is included in Formula
* Use real names for deps instead of aliases
* ENV.x11 now updates path, so remove that from individual brews
Updated the poppler formula to address the following issues:
- Poppler font data is now downloaded and installed to
#{prefix}/share/poppler using an internal brew.
- Added an install option, --with-qt4, that sets flags for linking to Qt
frameworks installed by the qt formula.
Using the qt4 option will also desginate the qt formula as a dependency
which will significantly increase compile times if Qt has not allready
been installed.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
