Commit graph

9 commits

Author SHA1 Message Date
Jack Nagel
8c29982153 Revert "Rename readline to gnu-readline"
This reverts commit adee5315265cc46aa6a3057071527abb16e1cd94.

Turns out one of the "other things" is a dealbreaker.

We only create kegs using a formula's canonical name. However, we do not
check that this is the case when mapping existing kegs back to formula
objects, and thus a keg with a name that happens to be an alias can fool
Homebrew into thinking the canonically-named keg exists.

So anything that enumerates kegs and then tries to do stuff with the
resulting formula objects will just break. This is obviously worse than
the debugger being broken, so reverting this for the time being.
2012-11-10 21:12:26 -06:00
Jack Nagel
e2f9856882 Rename readline to gnu-readline
The Readline class clashes with the Readline module from the Ruby
stdlib. This has mostly worked, but with the recent debugging support's
integration of IRB, it is no longer possible for them to coexist. So we
need to rename it.

The implications of this are:

 - Anything that depends on readline will reinstall it as
   "gnu-readline". Anything already installed will continue to function.

 - "brew upgrade readline" will say "gnu-readline not installed", as
   "readline" is now an alias.

 - Probably other things.

So there are some downsides, but we will just have to deal with them.

Fixes Homebrew/homebrew#15776.
2012-11-10 20:07:32 -06:00
Adam Vandenberg
18170f42ca ldapvi: style nits 2012-09-04 11:37:55 -07:00
Mark Harrison
413a6bad7a ldapvi: fix compile error with clang
Closes Homebrew/homebrew#14208.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2012-09-04 11:37:55 -07:00
Mike McQuaid
88779ade49 Batch convert MD5 formula to SHA1.
Closes Homebrew/homebrew#14653.
2012-09-03 11:36:42 -07:00
Jack Nagel
7c4fb0817c ldapvi: remove unnecessary configure switch
This was actually preventing Homebrew's CFLAGS from being recognized.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2011-09-05 17:07:23 -05:00
Zsolt Tripolszky
c7077f6dbf ldapvi: fix namespace clash with Lion's getline()
The patch is in the upstream git repository, so it should be in the next
version. Fixes Homebrew/homebrew#6606.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2011-09-05 17:04:58 -05:00
Adam Vandenberg
4147b05c57 Use ruby style for inheritance. 2011-03-12 11:55:09 -08:00
Maxim Filatov
7117e8fc65 ldapvi 1.7
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2010-03-15 10:02:52 -07:00