We have been explicitly passing "--without-included-glib", etc. to the
but this doesn't make sense: the flag does not mean "don't use glib at
all", it means "don't use the bundled glib", which means "use an
external copy of glib if one exists, but otherwise fall back to the
included version anyway".
This can lead to subtle breakage: if a user has installed glib, and then
gettext is built from source, gettext will link to the external glib.
When the user goes to upgrade glib the next time around, the build will
fail when it tries to use the now broken gettext binaries.
So in most cases, our gettext formula has been using these bundled
libraries anyway. The most obvious case is the bottles, which do not
have external linkage to glib, libunistring, etc.
In order to cover all cases, _always_ build with the included libraries.
There is no need to rebuild the bottles for these changes, as they are
correct already.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
The bottle was linked against libunistring, which is not a hard
dependency but gets picked up by the build if its present; this results
in breakage on systems where libunistring is not installed.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Way back in the day, Homebrew defaulted to LLVM/-O3. A lot of stuff
failed to compile, and a lot of stuff just took forever with -O4.
We don't default this way anymore, and in fact use -Os per Apple
guidelines.
So remove these old "fixes" since they are no longer needed.
It seems that the main GNU download site has issues in some places
outside the U.S., so we'll use the provided "ftpmirror.gnu.org" to pick
a nearby mirror.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
* Use new "url" features
* Use keg_only DSL
* Use "skip_clean :all" DSL
* Whitespace and style cleanups
* Make bash invocations less silly
* Use new man2-man8 helpers
* Remove "FileUtils." since it is included in Formula
* Use real names for deps instead of aliases
* ENV.x11 now updates path, so remove that from individual brews
brewkit.rb changes ENV destructively, so lets not do that everytime a formula
is required. Now it's possible for other tools to require a formula
description without worrying about side-effects.
GNU GetText breaks eg. Ruby 1.9 builds, and some other formula I have been building too. But it is required by eg. glib. So to solve this we are going to by default not symlink gettext into the Homebrew prefix.
Formula that depend on GetText will have the gettext paths added to the brewing environment automatically. Neat.
All Gettext binaries fail at runtime with linking problems related to the
environ variable. According to <http://www.mail-archive.com/bug-gnulib@gnu.org/msg09272.html>
the environ variable is missing from some platforms (between them MacOS X),
and autoconf test for it, and sets HAVE_ENVIRON_DECL accordingly. A common
workaround was declaring "extern char** environ" in the code if the OS didn't
provide the environ variable, but that doesn't work since 10.5. Since then you
have to use _NSGetEnviron() function declared in crt_externs.h. This
workaround works at least since 10.3. t
Signed-off-by: Max Howell <max@methylblue.com>
ClosesHomebrew/homebrew#11
