This issue was identified by Sharpie on github. I pulled the fix
from the svn trunk of mplayer. It was fixed in revision 32840.
https://gist.github.com/mxcl/homebrew/issues/6408
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
The patch required to build from SVN head may not apply cleanly depending on
changes to the codebase.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Also clean up the formula a bit and edit the comments
ENV.gcc_4_2 sets LD and CC as needed, but the formula was subsequently
clearing LD and CC. This breaks the build with Xcode 4.
Passing --enable-largefiles, --enable-apple-remote, and
--target=x86_64-Darwin to configure is unnecessary. These settings are
detected by the configure script and (properly) enabled automatically.
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
snow_leopard_64? (defined in Hardware) is a short-cut for:
MACOS_VERSION >= 10.6 and Hardware.is_64_bit?
Signed-off-by: Adam Vandenberg <flangy@gmail.com>
* Use new "url" features
* Use keg_only DSL
* Use "skip_clean :all" DSL
* Whitespace and style cleanups
* Make bash invocations less silly
* Use new man2-man8 helpers
* Remove "FileUtils." since it is included in Formula
* Use real names for deps instead of aliases
* ENV.x11 now updates path, so remove that from individual brews
Homebrew will now use the svn binary pointed to by HOMEBREW_SVN if set,
use a Homebrew-installed svn if present, finally falling back to the
system-provided svn binary.
If a formula (mplayer) requires a newer version of Subversion than what
Leopard provides, it can use the "StrictSubversionDownloadStrategy"
download strategy to warn the user.
These changes also fix an issue with forcing exports not working on a
stock Leopard subversion, but letting the user either specify a specific
binary or install Subversion via Homebrew and pick that up instead.
This is horrible in that I had to disable all optimisations and mplayer is the kind of tool that really gets a boost out of them!
I hope they release another tarball soon.
brewkit.rb changes ENV destructively, so lets not do that everytime a formula
is required. Now it's possible for other tools to require a formula
description without worrying about side-effects.
Some day I hope to make it utilize the ffmpeg-mt and speed patches, as well as
providing optimization info in the notes, but I can’t currently get that to
work on Snow Leopard. Maybe later.
