4a96076ad2
This patch fixes a memory leak in Emacs 24.3 on Mavericks. Mostly from an upstream patch r114945 in trunk, to be released as 24.4. https://gist.github.com/anonymous/8553178 Even though the patch is applied to files which are also modified by existing patches in the original Formula, it is confirmed that the patch can applied without errors (Hunk successfully). Closes Homebrew/homebrew#26516. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
161 lines
5.2 KiB
Ruby
161 lines
5.2 KiB
Ruby
require 'formula'
|
|
|
|
class Emacs < Formula
|
|
homepage 'http://www.gnu.org/software/emacs/'
|
|
url 'http://ftpmirror.gnu.org/emacs/emacs-24.3.tar.gz'
|
|
mirror 'http://ftp.gnu.org/pub/gnu/emacs/emacs-24.3.tar.gz'
|
|
sha256 '0098ca3204813d69cd8412045ba33e8701fa2062f4bff56bedafc064979eef41'
|
|
|
|
skip_clean 'share/info' # Keep the docs
|
|
|
|
option "cocoa", "Build a Cocoa version of emacs"
|
|
option "srgb", "Enable sRGB colors in the Cocoa version of emacs"
|
|
option "with-x", "Include X11 support"
|
|
option "use-git-head", "Use Savannah (faster) git mirror for HEAD builds"
|
|
option "keep-ctags", "Don't remove the ctags executable that emacs provides"
|
|
option "japanese", "Patch for Japanese input methods"
|
|
|
|
if build.include? "use-git-head"
|
|
head 'http://git.sv.gnu.org/r/emacs.git'
|
|
else
|
|
head 'bzr://http://bzr.savannah.gnu.org/r/emacs/trunk'
|
|
end
|
|
|
|
if build.head? or build.include? "cocoa"
|
|
depends_on :autoconf
|
|
depends_on :automake
|
|
end
|
|
|
|
depends_on 'pkg-config' => :build
|
|
depends_on :x11 if build.include? "with-x"
|
|
depends_on 'gnutls' => :optional
|
|
|
|
fails_with :llvm do
|
|
build 2334
|
|
cause "Duplicate symbol errors while linking."
|
|
end
|
|
|
|
def patches
|
|
p = {
|
|
# Fix default-directory on Cocoa and Mavericks.
|
|
# Fixed upstream in r114730 and r114882.
|
|
:p0 => [ DATA ],
|
|
:p1 => [
|
|
# Make native fullscreen mode optional, mostly from upstream r111679
|
|
'https://gist.github.com/scotchi/7209145/raw/a571acda1c85e13ed8fe8ab7429dcb6cab52344f/ns-use-native-fullscreen-and-toggle-frame-fullscreen.patch',
|
|
# Fix memory leaks in NS version from upstream r114945
|
|
'https://gist.github.com/anonymous/8553178/raw/c0ddb67b6e92da35a815d3465c633e036df1a105/emacs.memory.leak.aka.distnoted.patch.diff',
|
|
]
|
|
}
|
|
# "--japanese" option:
|
|
# to apply a patch from MacEmacsJP for Japanese input methods
|
|
if build.include? "cocoa" and build.include? "japanese"
|
|
p[:p0].push("http://sourceforge.jp/projects/macemacsjp/svn/view/inline_patch/trunk/emacs-inline.patch?view=co&revision=583&root=macemacsjp&pathrev=583")
|
|
end
|
|
p
|
|
end unless build.head?
|
|
|
|
# Follow MacPorts and don't install ctags from Emacs. This allows Vim
|
|
# and Emacs and ctags to play together without violence.
|
|
def do_not_install_ctags
|
|
unless build.include? "keep-ctags"
|
|
(bin/"ctags").unlink
|
|
(share/man/man1/"ctags.1.gz").unlink
|
|
end
|
|
end
|
|
|
|
def install
|
|
# HEAD builds blow up when built in parallel as of April 20 2012
|
|
ENV.j1 if build.head?
|
|
|
|
args = ["--prefix=#{prefix}",
|
|
"--without-dbus",
|
|
"--enable-locallisppath=#{HOMEBREW_PREFIX}/share/emacs/site-lisp",
|
|
"--infodir=#{info}/emacs"]
|
|
if build.with? 'gnutls'
|
|
args << '--with-gnutls'
|
|
else
|
|
args << '--without-gnutls'
|
|
end
|
|
|
|
system "./autogen.sh" if build.head?
|
|
|
|
if build.include? "cocoa"
|
|
# Patch for color issues described here:
|
|
# http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8402
|
|
if build.include? "srgb" and not build.head?
|
|
inreplace "src/nsterm.m",
|
|
"*col = [NSColor colorWithCalibratedRed: r green: g blue: b alpha: 1.0];",
|
|
"*col = [NSColor colorWithDeviceRed: r green: g blue: b alpha: 1.0];"
|
|
end
|
|
|
|
args << "--with-ns" << "--disable-ns-self-contained"
|
|
system "./configure", *args
|
|
system "make"
|
|
system "make install"
|
|
prefix.install "nextstep/Emacs.app"
|
|
|
|
# Don't cause ctags clash.
|
|
do_not_install_ctags
|
|
|
|
# Replace the symlink with one that avoids starting Cocoa.
|
|
(bin/"emacs").unlink # Kill the existing symlink
|
|
(bin/"emacs").write <<-EOS.undent
|
|
#!/bin/bash
|
|
#{prefix}/Emacs.app/Contents/MacOS/Emacs -nw "$@"
|
|
EOS
|
|
else
|
|
if build.include? "with-x"
|
|
# These libs are not specified in xft's .pc. See:
|
|
# https://trac.macports.org/browser/trunk/dports/editors/emacs/Portfile#L74
|
|
# https://github.com/Homebrew/homebrew/issues/8156
|
|
ENV.append 'LDFLAGS', '-lfreetype -lfontconfig'
|
|
args << "--with-x"
|
|
args << "--with-gif=no" << "--with-tiff=no" << "--with-jpeg=no"
|
|
else
|
|
args << "--without-x"
|
|
end
|
|
|
|
system "./configure", *args
|
|
system "make"
|
|
system "make install"
|
|
|
|
# Don't cause ctags clash.
|
|
do_not_install_ctags
|
|
end
|
|
end
|
|
|
|
def caveats
|
|
s = ""
|
|
if build.include? "cocoa"
|
|
s += <<-EOS.undent
|
|
A command line wrapper for the cocoa app was installed to:
|
|
#{bin}/emacs
|
|
EOS
|
|
if build.include? "srgb" and build.head?
|
|
s << "\nTo enable sRGB, use (setq ns-use-srgb-colorspace t)"
|
|
end
|
|
end
|
|
return s
|
|
end
|
|
end
|
|
|
|
__END__
|
|
--- src/emacs.c.orig 2013-02-06 13:33:36.000000000 +0900
|
|
+++ src/emacs.c 2013-11-02 22:38:45.000000000 +0900
|
|
@@ -1158,10 +1158,13 @@
|
|
if (!noninteractive)
|
|
{
|
|
#ifdef NS_IMPL_COCOA
|
|
+ /* Started from GUI? */
|
|
+ /* FIXME: Do the right thing if getenv returns NULL, or if
|
|
+ chdir fails. */
|
|
+ if (! inhibit_window_system && ! isatty (0))
|
|
+ chdir (getenv ("HOME"));
|
|
if (skip_args < argc)
|
|
{
|
|
- /* FIXME: Do the right thing if getenv returns NULL, or if
|
|
- chdir fails. */
|
|
if (!strncmp (argv[skip_args], "-psn", 4))
|
|
{
|
|
skip_args += 1;
|