Merge pull request #754 from square/z/kotlinTypesFollowup

Use faster isAnnotationPresent check
This commit is contained in:
Zac Sweers 2018-11-20 17:51:59 -08:00 committed by GitHub
commit 1f2a9373b7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -73,13 +73,18 @@ final class ClassJsonAdapter<T> extends JsonAdapter<T> {
if (Modifier.isAbstract(rawType.getModifiers())) {
throw new IllegalArgumentException("Cannot serialize abstract class " + rawType.getName());
}
for (Annotation annotation : rawType.getDeclaredAnnotations()) {
if ("kotlin.Metadata".equals(annotation.annotationType().getName())) {
try {
//noinspection unchecked if the Class.forName works, the cast will work.
Class<? extends Annotation> metadataClass =
(Class<? extends Annotation>) Class.forName("kotlin.Metadata");
if (rawType.isAnnotationPresent(metadataClass)) {
throw new IllegalArgumentException("Cannot serialize Kotlin type " + rawType.getName()
+ ". Reflective serialization of Kotlin classes without using kotlin-reflect has "
+ "undefined and unexpected behavior. Please use KotlinJsonAdapter from the "
+ "moshi-kotlin artifact or use code gen from the moshi-kotlin-codegen artifact.");
}
} catch (ClassNotFoundException ignored) {
}
ClassFactory<Object> classFactory = ClassFactory.get(rawType);