Commit graph

696 commits

Author SHA1 Message Date
Jesse Wilson
2cb81857ac [maven-release-plugin] prepare for next development iteration 2018-09-24 22:55:49 -04:00
Jesse Wilson
9a652f8788 [maven-release-plugin] prepare release moshi-parent-1.7.0 2018-09-24 22:55:35 -04:00
Jesse Wilson
662386cc03
Merge pull request #685 from square/jwilson.0924.internal_dopcs
Don't include the 'internal' package in Javadocs
2018-09-24 22:50:43 -04:00
Jesse Wilson
026d16ba68 Don't include the 'internal' package in Javadocs 2018-09-24 22:35:29 -04:00
Jesse Wilson
efd324b82f Update changelog for 1.7.0. 2018-09-24 22:26:55 -04:00
Jesse Wilson
73ca7765c0
Merge pull request #684 from square/jwilson.0924.upgrayedd
Upgrade Kotlin, AssertJ, compile-testing, and kotlin-metadata depende…
2018-09-24 22:13:43 -04:00
Jesse Wilson
6e6e533869
Merge pull request #683 from square/jwilson.0924.change_visibility
Hide RuntimeJsonAdapterFactory for the forthcoming release.
2018-09-24 21:49:25 -04:00
Jesse Wilson
735f0c39f7 Upgrade Kotlin, AssertJ, compile-testing, and kotlin-metadata dependencies 2018-09-24 21:48:25 -04:00
Jesse Wilson
11241a2b02 Hide RuntimeJsonAdapterFactory for the forthcoming release.
We don't yet have the behavior we want for looking ahead at the type label.
2018-09-24 21:03:20 -04:00
Jesse Wilson
f873bd93b7
Merge pull request #682 from sullis/maven-compiler-plugin-3.8.0
maven-compiler-plugin 3.8.0
2018-09-24 10:31:31 -04:00
Sean Sullivan
4392642f03 maven-compiler-plugin 3.8.0 2018-09-23 21:12:54 -07:00
Jesse Wilson
f466909967
Merge pull request #674 from square/eric.2018-09-18.codegen-adapter-lookup-error-hint
Use the adapter lookup hint API in Kotlin codegen adapters.
2018-09-23 21:16:52 -04:00
Eric Cochran
5a46cd6bd5
Use BufferedSource.indexOf instead of loops. (#677)
Cleanup of a rare code path for block comments in lenient readers.
2018-09-20 21:20:11 -07:00
Eric Cochran
242b7b1055 Use the adapter lookup hint API in Kotlin codegen adapters. 2018-09-20 21:00:18 -07:00
Jesse Wilson
1ba25ef3f9
Merge pull request #660 from square/eric.fix-preemptive-null-check
Allow user adapters to convert null to non-null in codegen.
2018-09-20 23:36:40 -04:00
Jesse Wilson
a813cd1352
Merge pull request #665 from square/eric.runtime-adapter-object-base
Fix RuntimeJsonAdapterFactory breaking with Object as the base type.
2018-09-20 23:34:30 -04:00
Jesse Wilson
226c0c14f2
Merge pull request #673 from square/eric.property-name-hint
Use the adapter lookup hint API in the Kotlin reflection adapter.
2018-09-20 23:32:21 -04:00
Eric Cochran
05cfb77430
Use the adapter lookup hint API in the Kotlin reflection adapter. 2018-09-18 18:00:22 -07:00
Eric Cochran
810199a442 Disallow Object for RuntimeJsonAdapterFactory's base type. 2018-09-18 17:57:11 -07:00
Benoît Quenaudon
e0cdcd4ff8
Merge pull request #668 from square/bquenaudon/2018-09-13/fix-jsonadapter-test
Fix JsonQualifiers test
2018-09-14 09:00:13 -04:00
Benoit Quenaudon
df730cafb9
Fix JsonQualifiers test 2018-09-13 15:02:06 -04:00
Eric Cochran
895c3ddb49 Track field names in the adapter lookup stack. (#616)
* Track field names in the adapter lookup stack.

This allows for an error message that includes field names to track down the cause of adapter creation failure for deeply nested structures.

* Use a single stack in Moshi client.

* Make optional fieldName parameter public API.

* Simplify error message.
2018-09-12 22:27:58 -04:00
Jesse Wilson
83b6b26e63
Merge pull request #659 from square/eric.exception-cause
Add exception cause for method adapter creation.
2018-09-12 22:24:22 -04:00
Jesse Wilson
62c14b872d
Merge pull request #658 from square/eric.okio15
Update to Okio 1.15.0.
2018-09-12 22:23:56 -04:00
Zac Sweers
d6ad1b8bad
Merge pull request #667 from oldergod/bquenaudon/2018-09-12/androidx
Don't reflect on androidX
2018-09-12 15:08:01 -07:00
Benoit Quenaudon
c606f43a3d
Don't reflect on androidX 2018-09-12 15:11:42 -04:00
Eric Cochran
8e151b1df3 Allow user adapters to convert null to non-null in codegen.
Delegate to installed adapters instead of checking for null.
2018-09-11 22:25:42 -07:00
Eric Cochran
46a42bc7ed Add exception cause for method adapter creation. 2018-09-11 22:25:09 -07:00
Eric Cochran
3fa09dd110 Update to Okio 1.15.0. 2018-09-11 22:24:38 -07:00
Jesse Wilson
9050e42038
Merge pull request #656 from square/jwilson.0910.nicer_exceptions
Generate nicer stacktraces when creating a generated adapter fails.
2018-09-11 22:08:18 -04:00
Jesse Wilson
76cd590ca3 Generate nicer stacktraces when creating a generated adapter fails.
Otherwise we end up with many InvocationTargetExceptions layered in, which makes
it difficult to identify what actually failed.
2018-09-11 22:02:54 -04:00
Jesse Wilson
5bd9632756
Merge pull request #663 from square/jwilson.0911.fix_nonkotlin_test_
Don't do Kotlin reflection on a non-Kotlin class.
2018-09-11 22:02:27 -04:00
Jesse Wilson
c04f1bafde Don't do Kotlin reflection on a non-Kotlin class.
Closes: https://github.com/square/moshi/issues/662
2018-09-11 21:50:02 -04:00
Jesse Wilson
9f2ed487b2
Merge pull request #653 from square/eric.copyrightheader
Add copyright header to EnumJsonAdapterTest.
2018-09-10 20:26:18 -04:00
Jesse Wilson
484fdfe4b6
Merge pull request #655 from square/eric.2018-08-17.nullSafe-generated-adapters
Make generated adapters null-safe.
2018-09-10 19:44:26 -04:00
Eric Cochran
e7c745aac8 Make generated adapters null-safe.
This is in alignment with the lookup for Java and Kotlin reflective adapters.
2018-09-10 16:31:24 -07:00
Eric Cochran
67d07eb450
Add copyright header to EnumJsonAdapterTest. 2018-09-10 15:33:39 -07:00
Jesse Wilson
d1c2cf9c6c
Merge pull request #649 from square/jwilson.0909.uppercase_property
Test support for uppercase property names
2018-09-09 23:32:10 -04:00
Jesse Wilson
c008e0e2b6 Test support for uppercase property names
I couldn't reproduce the reported issue.

Closes: https://github.com/square/moshi/issues/574
2018-09-09 23:25:56 -04:00
Jesse Wilson
29d08353ec
Merge pull request #650 from square/jwilson.0909.private_transient
Test that @Transient private properties are ignored
2018-09-09 23:24:53 -04:00
Jesse Wilson
1ba07d4b7d Test that @Transient private properties are ignored
Closes: https://github.com/square/moshi/issues/643
2018-09-09 23:17:50 -04:00
Jesse Wilson
cb86194f8f
Merge pull request #651 from square/jwilson.0909.enclosed_parameterized
Call Types.newParameterizedTypeWithOwner when necessary.
2018-09-09 23:16:38 -04:00
Jesse Wilson
f980521c8e
Merge pull request #652 from square/jwilson.0909.include_labels
Include labels when encoding with RuntimeJsonAdapterFactory.
2018-09-09 23:12:44 -04:00
Jesse Wilson
e7cae30bd8
Merge pull request #648 from square/jwilson.0909.delegate_key
Change DelegateKey to use AnnotationSpec instead of AnnotationMirror
2018-09-09 23:12:26 -04:00
Jesse Wilson
29bb93bc29 Include labels when encoding with RuntimeJsonAdapterFactory.
Otherwise the adapter is not symmetric.
2018-09-09 17:43:42 -04:00
Jesse Wilson
306664fb6a Call Types.newParameterizedTypeWithOwner when necessary.
Otherwise we crash with an exception attempting to create an adapter
for an enclosed type that has a type parameter.

I ran into this looking for a test case for issue 615.
https://github.com/square/moshi/issues/615
2018-09-09 17:05:33 -04:00
Jesse Wilson
7382145318 Change DelegateKey to use AnnotationSpec instead of AnnotationMirror
AnnotationSpec implements equals() in the way we need, but
AnnotationMirror doesn't. As a consequence this fixes a problem
where we were generating redundant adapters.

Closes: https://github.com/square/moshi/issues/563
2018-09-09 15:27:21 -04:00
Jesse Wilson
4f3c418202
Merge pull request #647 from square/jwilson.0909.confirm_one_way_code_gen
Confirm you can use codegen with adapter methods
2018-09-09 14:00:04 -04:00
Jesse Wilson
f5fe86dd78 Confirm you can use codegen with adapter methods
We had a bug report that said using just @ToJson wasn't working.
This test attempts to show it should work just fine.

https://github.com/square/moshi/issues/545
2018-09-09 12:16:18 -04:00
Jesse Wilson
2a593da06c
Merge pull request #628 from gabrielittner/master
Embed ProGuard rules in the jar
2018-09-08 14:58:44 -04:00