wbrawner/news-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update NewsReaderDetailFragment instead of creating new ones

Browse source 
Specify the fragment in the activity layout, and then only update the
recyclerView adapter when a different folder or feed is selected from
the menu. Should use less resources and gives nice recyclerview
animations.
This commit is contained in:
Daniel Schaal 2015-07-10 18:03:44 +02:00
parent b1b0aa8a94
commit 120fe02a3c
4 changed files with 31 additions and 73 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderDetailFragment.java
View file

@ -28,6 +28,7 @@ import android.os.Bundle;
import android.preference.PreferenceManager;
import android.support.v4.app.Fragment;
import android.support.v4.widget.SwipeRefreshLayout;
import android.support.v7.app.ActionBar;
import android.support.v7.app.AppCompatActivity;
import android.support.v7.widget.DefaultItemAnimator;
import android.support.v7.widget.LinearLayoutManager;
@ -134,6 +135,15 @@ public class NewsReaderDetailFragment extends Fragment {
}
}
public void setData(Long idFeed, Long idFolder, String titel, boolean updateListView) {
this.idFeed = idFeed;
this.idFolder = idFolder;
this.titel = titel;
setUpdateListViewOnStartUp(updateListView);
((AppCompatActivity)getActivity()).getSupportActionBar().setTitle(titel);
UpdateCurrentRssView(getActivity(),true);
}
@Override
public void onResume() {
EventBus.getDefault().register(this);
@ -197,17 +207,6 @@ public class NewsReaderDetailFragment extends Fragment {
}
}
/* (non-Javadoc)
* @see android.support.v4.app.ListFragment#onViewCreated(android.view.View, android.os.Bundle)
*/
@Override
public void onViewCreated(View view, Bundle savedInstanceState) {
super.onViewCreated(view, savedInstanceState);
((AppCompatActivity)getActivity()).getSupportActionBar().setTitle(titel);
}
public void onEventMainThread(PodcastDownloadService.DownloadProgressUpdate downloadProgress) {
NewsListRecyclerAdapter nca = (NewsListRecyclerAdapter) recyclerView.getAdapter();
if(nca != null) {

76
News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderListActivity.java
View file

@ -51,6 +51,7 @@ import butterknife.InjectView;
import de.greenrobot.event.EventBus;
import de.luhmer.owncloudnewsreader.ListView.SubscriptionExpandableListAdapter;
import de.luhmer.owncloudnewsreader.LoginDialogFragment.LoginSuccessfullListener;
import de.luhmer.owncloudnewsreader.adapter.NewsListRecyclerAdapter;
import de.luhmer.owncloudnewsreader.adapter.RecyclerItemClickListener;
import de.luhmer.owncloudnewsreader.adapter.ViewHolder;
import de.luhmer.owncloudnewsreader.authentication.AccountGeneral;
@ -135,7 +136,6 @@ public class NewsReaderListActivity extends PodcastFragmentActivity implements
super.onDrawerClosed(drawerView);
togglePodcastVideoViewAnimation();
StartDetailFragmentNow();
syncState();
EventBus.getDefault().post(new FeedPanelSlideEvent(false));
}
@ -157,8 +157,7 @@ public class NewsReaderListActivity extends PodcastFragmentActivity implements
if(savedInstanceState == null)//When the app starts (no orientation change)
{
startDetailFHolder = new StartDetailFragmentHolder(SubscriptionExpandableListAdapter.SPECIAL_FOLDERS.ALL_UNREAD_ITEMS.getValue(), true, null, true);
StartDetailFragmentNow();
StartDetailFragment(SubscriptionExpandableListAdapter.SPECIAL_FOLDERS.ALL_UNREAD_ITEMS.getValue(), true, null, true);
}
ImageHandler.createNoMediaFile(this);
@ -226,7 +225,7 @@ public class NewsReaderListActivity extends PodcastFragmentActivity implements
savedInstanceState.containsKey(OPTIONAL_FOLDER_ID)) {
startDetailFHolder = new StartDetailFragmentHolder(savedInstanceState.getLong(OPTIONAL_FOLDER_ID),
StartDetailFragment(savedInstanceState.getLong(OPTIONAL_FOLDER_ID),
savedInstanceState.getBoolean(IS_FOLDER_BOOLEAN),
savedInstanceState.getLong(ID_FEED_STRING),
false);
@ -256,15 +255,6 @@ public class NewsReaderListActivity extends PodcastFragmentActivity implements
drawerToggle.onConfigurationChanged(newConfig);
}
private NewsReaderDetailFragment StartDetailFragmentNow() {
NewsReaderDetailFragment nrdf = null;
if(startDetailFHolder != null) {
nrdf = startDetailFHolder.StartDetailFragment();
startDetailFHolder = null;
}
return nrdf;
}
public void reloadCountNumbersOfSlidingPaneAdapter() {
NewsReaderListFragment nlf = getSlidingListFragment();
if(nlf != null) {
@ -289,31 +279,11 @@ public class NewsReaderListActivity extends PodcastFragmentActivity implements
return getResources().getBoolean(R.bool.two_pane);
}
private StartDetailFragmentHolder startDetailFHolder = null;
@Override
public void onRefresh() {
startSync();
}
private class StartDetailFragmentHolder {
long idFeed;
boolean isFolder;
Long optional_folder_id;
boolean updateListView;
public StartDetailFragmentHolder(long idFeed, boolean isFolder, Long optional_folder_id, boolean updateListView) {
this.idFeed = idFeed;
this.isFolder = isFolder;
this.optional_folder_id = optional_folder_id;
this.updateListView = updateListView;
}
public NewsReaderDetailFragment StartDetailFragment() {
return NewsReaderListActivity.this.StartDetailFragment(idFeed, isFolder, optional_folder_id, updateListView);
}
}
/**
* Callback method from {@link NewsReaderListFragment.Callbacks} indicating
* that the item with the given ID was selected.
@ -323,10 +293,7 @@ public class NewsReaderListActivity extends PodcastFragmentActivity implements
if(!shouldDrawerStayOpen())
drawerLayout.closeDrawer(GravityCompat.START);
startDetailFHolder = new StartDetailFragmentHolder(idFeed, isFolder, optional_folder_id, true);
if(shouldDrawerStayOpen())
StartDetailFragmentNow();
StartDetailFragment(idFeed, isFolder, optional_folder_id, true);
}
@Override
@ -335,9 +302,7 @@ public class NewsReaderListActivity extends PodcastFragmentActivity implements
drawerLayout.closeDrawer(GravityCompat.START);
//StartDetailFragment(idSubscription, false, optional_folder_id);
startDetailFHolder = new StartDetailFragmentHolder(idFeed, false, optional_folder_id, true);
if(shouldDrawerStayOpen())
StartDetailFragmentNow();
StartDetailFragment(idFeed, false, optional_folder_id, true);
}
private NewsReaderDetailFragment StartDetailFragment(long id, Boolean folder, Long optional_folder_id, boolean updateListView)
@ -348,37 +313,30 @@ public class NewsReaderListActivity extends PodcastFragmentActivity implements
DatabaseConnectionOrm dbConn = new DatabaseConnectionOrm(getApplicationContext());
Intent intent = new Intent();
Long feedId = null;
Long folderId;
String titel = null;
if(!folder)
{
intent.putExtra(FEED_ID, id);
intent.putExtra(FOLDER_ID, optional_folder_id);
intent.putExtra(TITEL, dbConn.getFeedById(id).getFeedTitle());
feedId = id;
folderId = optional_folder_id;
titel = dbConn.getFeedById(id).getFeedTitle();
}
else
{
intent.putExtra(FOLDER_ID, id);
folderId = id;
int idFolder = (int) id;
if(idFolder >= 0)
intent.putExtra(TITEL, dbConn.getFolderById(id).getLabel());
titel = dbConn.getFolderById(id).getLabel();
else if(idFolder == -10)
intent.putExtra(TITEL, getString(R.string.allUnreadFeeds));
titel = getString(R.string.allUnreadFeeds);
else if(idFolder == -11)
intent.putExtra(TITEL, getString(R.string.starredFeeds));
titel = getString(R.string.starredFeeds);
}
Bundle arguments = intent.getExtras();
NewsReaderDetailFragment fragment = new NewsReaderDetailFragment();
fragment.setUpdateListViewOnStartUp(updateListView);
fragment.setArguments(arguments);
getSupportFragmentManager().beginTransaction()
.replace(R.id.content_frame, fragment)
.commit();
NewsReaderDetailFragment fragment = (NewsReaderDetailFragment) getSupportFragmentManager().findFragmentById(R.id.content_frame);
fragment.setData(feedId,folderId,titel,updateListView);
return fragment;
}

6
News-Android-App/src/main/res/layout/activity_newsreader.xml
View file

@ -19,12 +19,14 @@
android:layout_width="match_parent"
android:layout_height="match_parent">
<FrameLayout
<fragment
class="de.luhmer.owncloudnewsreader.NewsReaderDetailFragment"
android:id="@+id/content_frame"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_marginTop="?attr/actionBarSize"
app:layout_behavior="@string/appbar_scrolling_view_behavior" />
app:layout_behavior="@string/appbar_scrolling_view_behavior"
app:layout="@layout/fragment_newsreader_detail" />
<include
android:id="@+id/toolbar_layout"

1
News-Android-App/src/main/res/layout/fragment_newsreader_detail.xml
View file

@ -13,7 +13,6 @@
style="?android:attr/textAppearanceLarge"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:visibility="gone"
android:scrollbars="vertical" />
</android.support.v4.widget.SwipeRefreshLayout>