wbrawner/news-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor

Browse source
This commit is contained in:
David Luhmer 2019-04-10 00:10:36 -03:00
parent cb67e17b53
commit 1af8cc1ae0
2 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/async_tasks/RssItemToHtmlTask.java
View file

@ -84,14 +84,12 @@ public class RssItemToHtmlTask extends AsyncTask<Void, Void, String> {
* @return given RSS item as full HTML page
*/
public static String getHtmlPage(RssItem rssItem, boolean showHeader, SharedPreferences mPrefs, boolean isRightToLeft) {
String feedTitle = "Undefined";
String favIconUrl = null;
Feed feed = rssItem.getFeed();
//int feedColor = colors[0];
if (feed != null) {
feedTitle = Html.escapeHtml(feed.getFeedTitle());
favIconUrl = feed.getFaviconUrl();
}
@ -119,7 +117,7 @@ public class RssItemToHtmlTask extends AsyncTask<Void, Void, String> {
if (showHeader) {
builder.append(
buildHeader(rssItem, body_id, feedTitle, favIconUrl)
buildHeader(rssItem, body_id, favIconUrl)
);
}
@ -155,14 +153,14 @@ public class RssItemToHtmlTask extends AsyncTask<Void, Void, String> {
}
}
private static String buildHeader(RssItem rssItem, String body_id, String feedTitle, String favIconUrl) {
private static String buildHeader(RssItem rssItem, String body_id, String favIconUrl) {
StringBuilder builder = new StringBuilder();
builder.append("<div id=\"top_section\">");
builder.append(String.format("<div id=\"header\" class=\"%s\">", body_id));
String title = Html.escapeHtml(rssItem.getTitle());
String feedTitle = Html.escapeHtml(rssItem.getTitle());
String linkToFeed = Html.escapeHtml(rssItem.getLink());
builder.append(String.format("<a href=\"%s\">%s</a>", linkToFeed, title));
builder.append(String.format("<a href=\"%s\">%s</a>", linkToFeed, feedTitle));
builder.append("</div>");
String authorOfArticle = Html.escapeHtml(rssItem.getAuthor());

2
News-Android-App/src/main/res/layout/activity_new_feed.xml
View file

@ -77,7 +77,6 @@
android:layout_height="wrap_content"
android:layout_marginTop="16dp"
android:layout_marginEnd="8dp"
android:text="Import OPML"
android:text="@string/import_opml"
android:textStyle="bold" />
@ -89,7 +88,6 @@
android:layout_height="wrap_content"
android:layout_marginTop="16dp"
android:layout_marginStart="8dp"
android:text="Export OPML"
android:text="@string/export_opml"
android:textStyle="bold" />
</LinearLayout>