wbrawner/news-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix #392 - Performance improvement

Browse source
This commit is contained in:
David-Development 2015-08-22 16:34:24 +02:00
parent eae327e01c
commit 8eab232dfd
2 changed files with 10 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsDetailActivity.java
View file

@ -145,7 +145,7 @@ public class NewsDetailActivity extends PodcastFragmentActivity {
// databaseItemIds = intent.getIntegerArrayListExtra(DATABASE_IDS_OF_ITEMS);
rssItems = dbConn.getCurrentRssItemView(-1, getSortDirectionFromSettings(this));
rssItems = dbConn.getCurrentRssItemView(-1);
//If the Activity gets started from the Widget, read the item id and get the selected index in the cursor.
if(intent.hasExtra(WidgetProvider.RSS_ITEM_ID)) {

28
News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/database/DatabaseConnectionOrm.java
View file

@ -362,32 +362,22 @@ public class DatabaseConnectionOrm {
public final static int PageSize = 100;
public List<RssItem> getCurrentRssItemView(int page, SORT_DIRECTION... sortDirection) {
WhereCondition whereCondition = new WhereCondition.PropertyCondition(RssItemDao.Properties.Id, " IN " +
"(SELECT " + CurrentRssItemViewDao.Properties.RssItemId.columnName + " FROM " + CurrentRssItemViewDao.TABLENAME + ")");
public List<RssItem> getCurrentRssItemView(int page) {
if(page != -1) {
String where_clause = ", " + CurrentRssItemViewDao.TABLENAME + " C "
+ " WHERE C." + CurrentRssItemViewDao.Properties.RssItemId.columnName + " = T."
+ RssItemDao.Properties.Id.columnName
+ " AND C._id > " + page * PageSize + " AND c._id <= " + ((page+1) * PageSize);
+ " AND C._id > " + page * PageSize + " AND c._id <= " + ((page+1) * PageSize)
+ " ORDER BY C." + CurrentRssItemViewDao.Properties.Id.columnName;
//Log.v(TAG, where_clause);
//+ " LIMIT " + PageSize + " OFFSET " + (page * PageSize);
return daoSession.getRssItemDao().queryRaw(where_clause);
/*
if (sortDirection.equals(SORT_DIRECTION.asc))
return daoSession.getRssItemDao().queryBuilder().where(whereCondition).orderAsc(RssItemDao.Properties.PubDate).offset(page * PageSize).limit(PageSize).list();
else
return daoSession.getRssItemDao().queryBuilder().where(whereCondition).orderDesc(RssItemDao.Properties.PubDate).offset(page * PageSize).limit(PageSize).list();
*/
} else {
if(sortDirection.equals(SORT_DIRECTION.asc))
return daoSession.getRssItemDao().queryBuilder().where(whereCondition).orderAsc(RssItemDao.Properties.PubDate).listLazy();
else
return daoSession.getRssItemDao().queryBuilder().where(whereCondition).orderDesc(RssItemDao.Properties.PubDate).listLazy();
//return daoSession.getRssItemDao().queryBuilder().where(whereCondition).listLazy();
String where_clause = ", " + CurrentRssItemViewDao.TABLENAME + " C "
+ " WHERE C." + CurrentRssItemViewDao.Properties.RssItemId.columnName + " = T."
+ RssItemDao.Properties.Id.columnName
+ " ORDER BY C." + CurrentRssItemViewDao.Properties.Id.columnName;
return daoSession.getRssItemDao().queryRawCreate(where_clause).listLazy();
}
}