wbrawner/openssl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix spurious bntest failures.

Browse source 
BN_bntest_rand generates a single-word zero BIGNUM with quite a large probability.

A zero BIGNUM in turn will end up having a NULL |d|-buffer, which we shouldn't dereference without checking.

Reviewed-by: Richard Levitte <levitte@openssl.org>
This commit is contained in:
Emilia Kasper 2015-08-31 13:57:44 +02:00
parent 9db0c91c39
commit 4d04226c2e
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
test/bntest.c
View file

@ -526,9 +526,9 @@ int test_div_word(BIO *bp)
do { do {
BN_bntest_rand(a, 512, -1, 0); BN_bntest_rand(a, 512, -1, 0);
BN_bntest_rand(b, BN_BITS2, -1, 0); BN_bntest_rand(b, BN_BITS2, -1, 0);
s = b->d[0]; } while (BN_is_zero(b));
} while (!s);
s = b->d[0];
BN_copy(b, a); BN_copy(b, a);
r = BN_div_word(b, s); r = BN_div_word(b, s);