wbrawner/openssl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not use redirection on binary files

Browse source 
On some platforms, the shell will determine what attributes a file
will have, so while the program might think it's safely outputting
binary data, it's not always true.

For the sake of the tests, it's therefore safer to use -out than to
use redirection.

Reviewed-by: Rich Salz <rsalz@openssl.org>
This commit is contained in:
Richard Levitte 2016-01-14 13:15:45 +01:00
parent 67949615d2
commit 9b56815d5f
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
test/recipes/20-test_enc.t
View file

@ -51,10 +51,8 @@ if (!$init) {
@d = ( "enc", @{$variant{$t}}, "-d" ); @d = ( "enc", @{$variant{$t}}, "-d" );
} }
ok(run(app([$cmd, @e], ok(run(app([$cmd, @e, "-in", $test, "-out", $cipherfile]))
stdin => $test, stdout => $cipherfile)) && run(app([$cmd, @d, "-in", $cipherfile, "-out", $clearfile]))
&& run(app([$cmd, @d],
stdin => $cipherfile, stdout => $clearfile))
&& compare_text($test,$clearfile) == 0, $t); && compare_text($test,$clearfile) == 0, $t);
unlink $cipherfile, $clearfile; unlink $cipherfile, $clearfile;
} }

10
test/recipes/tconversion.pl
View file

@ -53,8 +53,9 @@ sub tconversion {
ok(run(app([@cmd, ok(run(app([@cmd,
"-in", "$testtype-fff.p", "-in", "$testtype-fff.p",
"-inform", "p", "-inform", "p",
"-outform", $to], "-out", "$testtype-f.$to",
stdout => "$testtype-f.$to")), "p -> $to"); "-outform", $to])),
"p -> $to");
} }
foreach my $to (@conversionforms) { foreach my $to (@conversionforms) {
@ -62,8 +63,9 @@ sub tconversion {
ok(run(app([@cmd, ok(run(app([@cmd,
"-in", "$testtype-f.$from", "-in", "$testtype-f.$from",
"-inform", $from, "-inform", $from,
"-outform", $to], "-out", "$testtype-ff.$from$to",
stdout => "$testtype-ff.$from$to")), "$from -> $to"); "-outform", $to])),
"$from -> $to");
} }
} }