wbrawner/openssl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix error found by coverity: check if ctx is != NULL before calling BN_CTX_end()

Browse source
This commit is contained in:
Nils Larsch 2006-03-13 23:12:08 +00:00
parent 5586a71a6e
commit b7a80146f4
5 changed files with 16 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
crypto/dh/dh_key.c
View file

@ -217,8 +217,11 @@ static int compute_key(unsigned char *key, const BIGNUM *pub_key, DH *dh)
ret=BN_bn2bin(tmp,key); ret=BN_bn2bin(tmp,key);
err: err:
BN_CTX_end(ctx); if (ctx != NULL)
BN_CTX_free(ctx); {
BN_CTX_end(ctx);
BN_CTX_free(ctx);
}
return(ret); return(ret);
} }

3
crypto/ec/ec2_smpl.c
View file

@ -281,7 +281,8 @@ int ec_GF2m_simple_group_check_discriminant(const EC_GROUP *group, BN_CTX *ctx)
ret = 1; ret = 1;
err: err:
BN_CTX_end(ctx); if (ctx != NULL)
BN_CTX_end(ctx);
if (new_ctx != NULL) if (new_ctx != NULL)
BN_CTX_free(new_ctx); BN_CTX_free(new_ctx);
return ret; return ret;

3
crypto/ec/ec_check.c
View file

@ -113,7 +113,8 @@ int EC_GROUP_check(const EC_GROUP *group, BN_CTX *ctx)
ret = 1; ret = 1;
err: err:
BN_CTX_end(ctx); if (ctx != NULL)
BN_CTX_end(ctx);
if (new_ctx != NULL) if (new_ctx != NULL)
BN_CTX_free(new_ctx); BN_CTX_free(new_ctx);
if (point) if (point)

3
crypto/ec/ecp_smpl.c
View file

@ -336,7 +336,8 @@ int ec_GFp_simple_group_check_discriminant(const EC_GROUP *group, BN_CTX *ctx)
ret = 1; ret = 1;
err: err:
BN_CTX_end(ctx); if (ctx != NULL)
BN_CTX_end(ctx);
if (new_ctx != NULL) if (new_ctx != NULL)
BN_CTX_free(new_ctx); BN_CTX_free(new_ctx);
return ret; return ret;

7
crypto/rsa/rsa_gen.c
View file

@ -183,8 +183,11 @@ err:
RSAerr(RSA_F_RSA_BUILTIN_KEYGEN,ERR_LIB_BN); RSAerr(RSA_F_RSA_BUILTIN_KEYGEN,ERR_LIB_BN);
ok=0; ok=0;
} }
BN_CTX_end(ctx); if (ctx != NULL)
BN_CTX_free(ctx); {
BN_CTX_end(ctx);
BN_CTX_free(ctx);
}
return ok; return ok;
} }