wbrawner/openssl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix BN_kronecker so that it works correctly if 'a' is negative

Browse source 
(we need the two's complement of BN_lsw then).
This commit is contained in:
Bodo Möller 2000-11-29 19:26:33 +00:00
parent a9376dbff9
commit eb1f1b0a34
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crypto/bn/bn_kron.c
View file

@ -65,7 +65,7 @@
int BN_kronecker(const BIGNUM *a, const BIGNUM *b, BN_CTX *ctx)
{
int i;
int ret;
int ret = -2; /* avoid 'uninitialized' warning */
int err = 0;
BIGNUM *A, *B, *tmp;
/* In 'tab', only odd-indexed entries are relevant:
@ -165,7 +165,7 @@ int BN_kronecker(const BIGNUM *a, const BIGNUM *b, BN_CTX *ctx)
/* Cohen's step 4: */
/* multiply 'ret' by $(-1)^{(A-1)(B-1)/4}$ */
if (BN_lsw(A) & BN_lsw(B) & 2)
if ((A->neg ? ~BN_lsw(A) : BN_lsw(A)) & BN_lsw(B) & 2)
ret = -ret;
/* (A, B) := (B mod |A|, |A|) */

4
crypto/bn/bntest.c
View file

@ -949,8 +949,8 @@ int test_kron(BIO *bp, BN_CTX *ctx)
for (i = 0; i < num0; i++)
{
if (!BN_rand(a, 512, 0, 0)) goto err;
if (!BN_nnmod(a, a, b, ctx)) goto err;
a->neg = rand_neg();
/* r := (b-1)/2 (note that b is odd) */
if (!BN_copy(r, b)) goto err;
if (!BN_sub_word(r, 1)) goto err;