wbrawner/openssl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
13311 commits 20 branches 302 tags 153 MiB
Commit graph

18 commits

Author SHA1 Message Date
Emilia Kasper
5956b110e3 NISTZ256: owur'ize. 
__owur'ize static methods to catch calling errors within the module.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2015-04-28 12:49:40 +02:00
Emilia Kasper
6038354cf8 NISTZ256: use EC_POINT API and check errors. 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2015-04-27 19:44:43 +02:00
Emilia Kasper
a4d5269e6d NISTZ256: don't swallow malloc errors 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2015-04-27 18:03:38 +02:00
Emilia Kasper
4446044a79 NISTZ256: set Z_is_one to boolean 0/1 as is customary. 
Cosmetic, no real effect.

Reviewed-by: Richard Levitte <levitte@openssl.org>
 2015-04-27 16:49:25 +02:00
Emilia Kasper
e22d2199e2 Error checking and memory leak fixes in NISTZ256. 
Reviewed-by: Richard Levitte <levitte@openssl.org>
 2015-04-27 16:21:48 +02:00
Emilia Kasper
53dd4ddf71 Fix error checking and memory leaks in NISTZ256 precomputation. 
Thanks to Brian Smith for reporting these issues.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2015-04-24 17:45:13 +02:00
Emilia Kasper
c028254b12 Correctly set Z_is_one on the return value in the NISTZ256 implementation. 
Also add a few comments about constant-timeness.

Thanks to Brian Smith for reporting this issue.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2015-04-24 17:33:21 +02:00
Rich Salz
e0e920b1a0 free NULL cleanup 9 
Ongoing work to skip NULL check before calling free routine.  This gets:
    ecp_nistz256_pre_comp_free nistp224_pre_comp_free nistp256_pre_comp_free
    nistp521_pre_comp_free PKCS7_free PKCS7_RECIP_INFO_free
    PKCS7_SIGNER_INFO_free sk_PKCS7_pop_free PKCS8_PRIV_KEY_INFO_free
    PKCS12_free PKCS12_SAFEBAG_free PKCS12_free sk_PKCS12_SAFEBAG_pop_free
    SSL_CONF_CTX_free SSL_CTX_free SSL_SESSION_free SSL_free ssl_cert_free
    ssl_sess_cert_free

Reviewed-by: Kurt Roeckx <kurt@openssl.org>
 2015-04-11 16:32:54 -04:00
Rich Salz
8fdc3734c0 free NULL cleanup. 
This gets EC_GROUP_clear_free EC_GROUP_free, EC_KEY_free,
EC_POINT_clear_free, EC_POINT_free

Reviewed-by: Kurt Roeckx <kurt@openssl.org>
 2015-03-25 18:35:24 -04:00
Andy Polyakov
5afc296aa6 ec/ecp_nistz256.c: fix compiler warnings. 
Reviewed-by: Matt Caswell <matt@openssl.org>
 2015-02-10 22:04:28 +01:00
Rich Salz
49b05c7d50 Rename index to idx to avoid symbol conflicts. 
Picky compilers with old index() string functions.
Reviewed-by: Matt Caswell <matt@openssl.org>
 2015-01-28 12:23:01 -05:00
Andy Polyakov
20728adc8f ec/ecp_nistz256.c: further harmonization with latest rules. 
Reviewed-by: Tim Hudson <tjh@openssl.org>
 2015-01-22 09:20:09 +00:00
Andy Polyakov
58d47cf004 ec/ecp_nistz256.c: harmonize with latest indent script. 
Reviewed-by: Tim Hudson <tjh@openssl.org>
 2015-01-22 09:20:08 +00:00
Matt Caswell
5784a52145 Implement internally opaque bn access from ec 
Reviewed-by: Tim Hudson <tjh@openssl.org>
 2014-12-08 21:40:47 +00:00
Andy Polyakov
3ff08e1dde ecp_nistz256 update. 
Facilitate switch to custom scatter-gather routines. This modification
does not change algorithms, only makes it possible to implement
alternative. This is achieved by a) moving precompute table to assembly
(perlasm parses ecp_nistz256_table.c and is free to rearrange data to
match gathering algorithm); b) adhering to explicit scatter subroutine
(which for now is simply a memcpy). First implementations that will use
this option are 32-bit assembly implementations, ARMv4 and x86, where
equivalent of current read-whole-table-select-single-value algorithm
is too time-consuming. [On side note, switching to scatter-gather on
x86_64 would allow to improve server-side ECDSA performance by ~5%].

Reviewed-by: Bodo Moeller <bodo@openssl.org>
 2014-10-23 16:08:44 +02:00
Andy Polyakov
be07ae9b10 crypto/ecp_nistz256.c: harmonize error codes. 
Reviewed-by: Dr. Stephen Henson <steve@openssl.org>
 2014-09-21 15:56:02 +02:00
Dr. Stephen Henson
16e5b45f72 Fix warning. 
Reviewed-by: Tim Hudson <tjh@openssl.org>
 2014-09-20 00:08:56 +01:00
Andy Polyakov
4d3fa06fce Add ECP_NISTZ256 by Shay Gueron, Intel Corp. 
RT: 3149

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2014-09-12 00:37:41 +02:00