wbrawner/openssl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
20128 commits 20 branches 302 tags 153 MiB
Commit graph

36 commits

Author SHA1 Message Date
Matt Caswell
cc06906707 Fix an uninitialised read on an error path 
Found by Coverity.

Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-08-25 10:11:35 +01:00
FdaSilvaYY
a026fbf977 Constify some inputs buffers 
remove useless cast to call ASN1_STRING_set

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-08-23 11:47:22 +02:00
Matt Caswell
b197257d71 Check for error return from ASN1_object_size 
Otherwise we try to malloc a -1 size.

Reviewed-by: Tim Hudson <tjh@openssl.org>
 2016-08-23 00:19:15 +01:00
FdaSilvaYY
c47ba4e96c Constify some ASN1_OBJECT *obj input parameters 
Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-08-04 17:02:48 +02:00
Rich Salz
b1322259d9 Copyright consolidation 09/10 
Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-05-17 14:53:16 -04:00
Matt Caswell
a4e584a610 Don't leak resource on error in OCSP_url_svcloc_new 
On error we could leak a ACCESS_DESCRIPTION and an ASN1_IA5STRING. Both
should be freed in the error path.

Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-04-28 13:13:09 +01:00
FdaSilvaYY
0d4fb84390 GH601: Various spelling fixes. 
Signed-off-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
 2016-02-05 15:25:50 -05:00
Rich Salz
349807608f Remove /* foo.c */ comments 
This was done by the following
        find . -name '*.[ch]' | /tmp/pl
where /tmp/pl is the following three-line script:
        print unless $. == 1 && m@/\* .*\.[ch] \*/@;
        close ARGV if eof; # Close file to reset $.

And then some hand-editing of other files.

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
 2016-01-26 16:40:43 -05:00
Dr. Stephen Henson
a332635ea0 Embed various OCSP fields. 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2015-10-11 20:33:57 +01:00
Richard Levitte
b39fc56061 Identify and move common internal libcrypto header files 
There are header files in crypto/ that are used by a number of crypto/
submodules.  Move those to crypto/include/internal and adapt the
affected source code and Makefiles.

The header files that got moved are:

crypto/cryptolib.h
crypto/md32_common.h

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2015-05-14 17:21:40 +02:00
Rich Salz
75ebbd9aa4 Use p==NULL not !p (in if statements, mainly) 
Reviewed-by: Tim Hudson <tjh@openssl.org>
 2015-05-11 10:06:38 -04:00
Rich Salz
25aaa98aa2 free NULL cleanup -- coda 
After the finale, the "real" final part. :)  Do a recursive grep with
"-B1 -w [a-zA-Z0-9_]*_free" to see if any of the preceeding lines are
an "if NULL" check that can be removed.

Reviewed-by: Tim Hudson <tjh@openssl.org>
 2015-05-01 14:37:16 -04:00
Rich Salz
b548a1f11c free null cleanup finale 
Don't check for NULL before calling OPENSSL_free

Reviewed-by: Richard Levitte <levitte@openssl.org>
 2015-05-01 10:02:07 -04:00
Rich Salz
2ace745022 free NULL cleanup 8 
Do not check for NULL before calling a free routine.  This addresses:
    ASN1_BIT_STRING_free ASN1_GENERALIZEDTIME_free ASN1_INTEGER_free
    ASN1_OBJECT_free ASN1_OCTET_STRING_free ASN1_PCTX_free ASN1_SCTX_free
    ASN1_STRING_clear_free ASN1_STRING_free ASN1_TYPE_free
    ASN1_UTCTIME_free M_ASN1_free_of

Reviewed-by: Richard Levitte <levitte@openssl.org>
 2015-04-30 11:31:07 -04:00
Matt Caswell
266483d2f5 RAND_bytes updates 
Ensure RAND_bytes return value is checked correctly, and that we no longer
use RAND_pseudo_bytes.

Reviewed-by: Richard Levitte <levitte@openssl.org>
 2015-03-25 12:38:07 +00:00
Dr. Stephen Henson
4903abd50a make X509_EXTENSION opaque 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2015-03-23 18:27:04 +00:00
Dr. Stephen Henson
6ef869d7d0 Make OCSP structures opaque. 
Reviewed-by: Matt Caswell <matt@openssl.org>
 2015-03-05 14:47:48 +00:00
Rich Salz
06cf881a3a Final (for me, for now) dead code cleanup 
This is a final pass looking for '#if 0'/'#if 1' controls and
removing the appropriate pieces.

Reviewed-by: Andy Polyakov <appro@openssl.org>
 2015-02-08 18:48:09 -05:00
Matt Caswell
0f113f3ee4 Run util/openssl-format-source -v -c . 
Reviewed-by: Tim Hudson <tjh@openssl.org>
 2015-01-22 09:20:09 +00:00
Matt Caswell
3a83462dfe Further comment amendments to preserve formatting prior to source reformat 
Reviewed-by: Tim Hudson <tjh@openssl.org>
 2015-01-06 15:45:25 +00:00
Dr. Stephen Henson
3c07d3a3d3 Finish gcc 4.2 changes. 2007-06-07 13:14:42 +00:00
Dr. Stephen Henson
fb596f3bb7 OCSP library tidy. Use extension to encode OCSP extensions instead of doing 
it manually. Make OCSP_CERTID_dup() a real function instead of a macro.
 2006-11-13 13:18:28 +00:00
Ben Laurie
8bb826ee53 Consistency. 2005-03-31 13:57:54 +00:00
Ben Laurie
41a15c4f0f Give everything prototypes (well, everything that's actually used). 2005-03-31 09:26:39 +00:00
Dr. Stephen Henson
dc90f64d56 Use an OCTET STRING for the encoding of an OCSP nonce value. 
The old raw format can't be handled by some implementations
and updates to RFC2560 will make this mandatory.
 2004-02-19 18:16:38 +00:00
Richard Levitte
e28e42a549 Use sk_*_new_null() instead of sk_*_new(NULL). That avoids getting 
lots of silly warnings from the compiler.
 2001-02-20 13:06:10 +00:00
Dr. Stephen Henson
46a58ab946 Modify OCSP nonce behaviour. 2001-02-12 23:28:45 +00:00
Richard Levitte
c2bf70a27c The check for request including a nonce and response not having it was 
inversed.  Corrected.  Hopefully, this will make it work without
dumping core.
 2001-02-08 19:28:10 +00:00
Dr. Stephen Henson
26e083ccb7 New function to copy nonce values from OCSP 
request to response.
 2001-02-05 00:35:06 +00:00
Dr. Stephen Henson
0b33bc65cd Add set of OCSP client functions. All experimental 
and subject to addition, modifcation or deletion.

Add two OCSP nonce utility functions.

Fix typo in status code name.
 2001-01-08 01:21:55 +00:00
Dr. Stephen Henson
ec558b6548 New OCSP extension functions. 2000-12-28 01:05:05 +00:00
Dr. Stephen Henson
1f47ec53a2 Redo OCSP response printing. Remove duplicate or 
obsolete code. Delete some redundant files.
 2000-12-17 14:09:43 +00:00
Richard Levitte
820aaa5fc5 Typo, was "time" instead of "tim". 
Caught by Jeffrey Altman <jaltman@columbia.edu>
 2000-11-14 10:52:16 +00:00
Ben Laurie
2f9f0c72de Make this stuff compile. 2000-11-12 02:11:13 +00:00
Richard Levitte
2f13ee21ea Instead of just STACK, use STACK_OF(ASN1_OBJECT). 2000-11-03 00:59:49 +00:00
Richard Levitte
eb64730b9c The majority of the OCSP code from CertCo. 2000-10-27 11:05:35 +00:00