wbrawner/openssl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
18350 commits 20 branches 302 tags 153 MiB
Commit graph

18350 commits

This branch
This branch
All branches
Author SHA1 Message Date
Emilia Kasper
308b876da9 Don't create fixtures for simple tests 
The test fixtures are (meant to be) useful for sharing common
setup. Don't bother when we don't have any setup/teardown.

This only addresses simple tests. Parameterized tests (ADD_ALL_TESTS)
will be made more user-friendly in a follow-up.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 15:05:37 +01:00
Emilia Kasper
6ec327eed6 testutil: always print errors on failure 
Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-11-04 15:05:29 +01:00
Richard Levitte
7b19543841 Travis: add a strict build 
Clang on Linux seems to catch things that we might miss otherwise.
Also, throw in 'no-deprecated' to make sure we test that as well.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1839)
 2016-11-04 14:12:06 +01:00
Matt Caswell
c42a78cb57 Fix a missed size_t variable declaration 
pqueue_size() now returns a size_t, but the variable that gets returned
was still declared as an int.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
ff04799d90 Fix some style issues from libssl size_tify review 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
ed9fa2c74b Tweak the SSL_read()/SSL_write() text based on feedback received. 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
54105ddd23 Rename all "read" variables with "readbytes" 
Travis is reporting one file at a time shadowed variable warnings where
"read" has been used. This attempts to go through all of libssl and replace
"read" with "readbytes" to fix all the problems in one go.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
740bfebaf6 Clarify the return values for SSL_read_ex()/SSL_write_ex() 
Give more detail on what constitutes success/failure.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
02ba18a63e Fix a shadowed variable declaration warning picked up by Travis 
Rename "read" to "readbytes"

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
8d2b1819ef Document the HMAC_size() function 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
be2ef0e2e3 Test the size_t constant time functions 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
2b7363ecf1 Ensure SSL_DEBUG works following size_t changes 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
3cdc2f8fb5 Clarify the return values for the peek functions 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
6782e5fdd8 Updates various man pages based on review feedback received. 
Improvements to style, grammar etc.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
d0ee717c93 Fix style issues in HMAC_size() 
Based on review feedback.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
f0ca8f89f8 Fix some bogus warnings about uninitialised variables 
Travis was failing in some builds due to a bogus complaint
about uninit variables.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
d02ef3d0be Fix some clashing symbol numbers due to merge conflict 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
7714dc5ea1 Document the newly added SSL functions 
Also document SSL_peek() which was missing from the docs.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
699ae85915 Remove a stray TODO that has already been fixed 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
2688e7a0be Provide some constant time functions for dealing with size_t values 
Also implement the using of them

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
708e06c55d Ensure HMAC_size() handles errors correctly 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
56a26ce360 Now that we can use size_t in PACKET lets use it 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
348240c676 Fix misc size_t issues causing Windows warnings in 64 bit 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
a14aa99be8 Convert the mac functions to just return 1 for success and 0 for failure 
Previously they return -1 for failure or the size of the mac. But the size
was never used anywhere.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
c08d12ca40 Fix some ssl3_record code witch converstion to/from size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
153703dfde Add some PACKET functions for size_t 
And use them in the DTLS code

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:46 +00:00
Matt Caswell
8051ab2b6f Convert SSL BIO to use SSL_write_ex(). 
We also modify the SSL_get_error() function to handle the fact that with
SSL_write_ex() the error return is 0 not -1, and fix some bugs in the
SSL BIO reading.

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
8b0e934afb Fix some missed size_t updates 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
e3c9727fec Resolve some outstanding size_t related TODOs 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
d736bc1a7d Update misc function params in libssl for size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
6db6bc5a8f Convert some libssl local functions to size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
cb150cbcac Update cookie_len for size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
12472b4561 Update numerous misc libssl fields to be size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
ec60ccc1c1 Convert session_id_length and sid_ctx_len to size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
8c1a534305 Convert master_secret_size code to size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
b43d1cbb9a Convert various mac_secret_size usage to size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
d0e7c31db0 Convert ssl3_cbc_digest_record for size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
72716e79bf Convert some misc record layer functions for size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
5607b2759a Convert SSL3_RECORD_clear() and SSL3_RECORD_release() to size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
7ee8627f6e Convert libssl writing for size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
eda757514e Further libssl size_t-ify of reading 
Writing still to be done

Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
8e6d03cac4 Convert record layer to use size_t 
Reviewed-by: Rich Salz <rsalz@openssl.org>
 2016-11-04 12:09:45 +00:00
Matt Caswell
a1ca39c02c Remove an unused field in ossl_shim 
Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-11-04 10:38:54 +00:00
Matt Caswell
e8585479a1 Add a wildcard exception for TLS13 tests 
Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-11-04 10:38:54 +00:00
Matt Caswell
92ab7db6f8 Swap header copyrights to standard OpenSSL 
As per permission from Google (Emilia).

Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-11-04 10:38:54 +00:00
Matt Caswell
bc708af4b0 Add missing bn.h include 
Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-11-04 10:38:54 +00:00
Matt Caswell
b289bff830 Update the BoringSSL suppressions file based on the latest shim 
The updated shim has the ability to skip tests using unimplemented flags.
This should reduce the number of test failures.

Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-11-04 10:38:54 +00:00
Matt Caswell
1669b7b587 Rename BoringSSL style OPENSSL_WINDOWS to OPENSSL_SYS_WINDOWS 
Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-11-04 10:38:54 +00:00
Matt Caswell
1c8235c9b3 Fix a code inconsistency 
Move from two ifs to a single one with an &&

Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-11-04 10:38:54 +00:00
Matt Caswell
fc237de7ff Remove some #if 0'd out code 
It was only a sanity check anyway, so isn't needed

Reviewed-by: Richard Levitte <levitte@openssl.org>
 2016-11-04 10:38:54 +00:00