wbrawner/openssl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
7089 commits 20 branches 302 tags 153 MiB
Commit graph

7089 commits

This branch
This branch
All branches
Author SHA1 Message Date
Richard Levitte
90dd4d34bb Correct documentation typos. 
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>
 2003-12-27 15:05:26 +00:00
Richard Levitte
112341031b Correct documentation typos. 
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>
 2003-12-27 15:04:54 +00:00
Richard Levitte
7cf803230b OpenBSD-internal changes. 
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>
 2003-12-27 15:02:56 +00:00
Richard Levitte
2d6452cdf9 OpenBSD-internal changes. 
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>
 2003-12-27 15:02:54 +00:00
Richard Levitte
cc056d6395 Use sh explicitely to run point.sh 
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>
 2003-12-27 15:00:24 +00:00
Richard Levitte
79b42e7654 Use sh explicitely to run point.sh 
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>
 2003-12-27 14:59:07 +00:00
Richard Levitte
f0c5db92f7 Include strings.h so strcasecmp() and strncasecmp() get properly declared. 2003-12-27 14:54:48 +00:00
Richard Levitte
394178c94c Use BUF_strlcpy() instead of strcpy(). 
Use BUF_strlcat() instead of strcat().
Use BIO_snprintf() instead of sprintf().
In some cases, keep better track of buffer lengths.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>
 2003-12-27 14:40:57 +00:00
Richard Levitte
d420ac2c7d Use BUF_strlcpy() instead of strcpy(). 
Use BUF_strlcat() instead of strcat().
Use BIO_snprintf() instead of sprintf().
In some cases, keep better track of buffer lengths.
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>
 2003-12-27 14:40:17 +00:00
Richard Levitte
61590d8945 Add a newline at the end of the last line. 
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>
 2003-12-27 14:26:15 +00:00
Richard Levitte
b79aa47a0c Add a newline at the end of the last line. 
This is part of a large change submitted by Markus Friedl <markus@openbsd.org>
 2003-12-27 14:26:14 +00:00
Richard Levitte
ec2a595627 Change 'exp' to something else, as 'exp' is predefined by GNU C. This 
was already done in HEAD, but not in this branch (I wonder why...).
 2003-12-27 14:24:20 +00:00
Dr. Stephen Henson
8f5c833f3c Typos. 2003-12-20 22:49:05 +00:00
Dr. Stephen Henson
e88c577738 Typos. 2003-12-20 22:48:21 +00:00
Richard Levitte
ffe966b0fa To figure out if we're going outside the buffer, use the size of the buffer, 
not the size of the integer used to index in said buffer.

PR: 794
Notified by: Rhett Garber <rhett_garber@hp.com>
 2003-12-11 18:01:06 +00:00
Richard Levitte
a2b0de98af To figure out if we're going outside the buffer, use the size of the buffer, 
not the size of the integer used to index in said buffer.

PR: 794
Notified by: Rhett Garber <rhett_garber@hp.com>
 2003-12-11 18:01:03 +00:00
Richard Levitte
bb3de147b3 Document that you need to include x509.h (to get [i2d|d2i]_RSA_PUBKEY()). 
Correct the typo PUKEY...
 2003-12-10 14:31:57 +00:00
Richard Levitte
4775944f81 Document that you need to include x509.h (to get [i2d|d2i]_RSA_PUBKEY()). 
Correct the typo PUKEY...
 2003-12-10 14:31:55 +00:00
Richard Levitte
95ec1a717b Document that you need to include x509.h (to get [i2d|d2i]_DSA_PUBKEY()). 
Correct the typo PUKEY...
 2003-12-10 13:57:52 +00:00
Richard Levitte
2abd5b7aa0 Document that you need to include x509.h (to get [i2d|d2i]_DSA_PUBKEY()). 
Correct the typo PUKEY...
 2003-12-10 13:57:51 +00:00
Ulf Möller
380e145daf Add "dif" variable to clean up the loop implementations. 
Submitted by: Nils Larsch
 2003-12-06 11:55:46 +00:00
Ulf Möller
a9f2330f43 Skip a curve with generator of non-prime order. 
Submitted by: Nils Larsch
 2003-12-06 11:41:22 +00:00
Ulf Möller
ce38bb1a8c Avoid segfault if ret==0. 
Submitted by: Nils Larsch
 2003-12-06 11:39:37 +00:00
Lutz Jänicke
919f8bcd21 Restructure make targets to allow parallel make. 
Submitted by: Witold Filipczyk <witekfl@poczta.gazeta.pl>

PR: #513
 2003-12-03 16:29:41 +00:00
Lutz Jänicke
325829a9bc Restructure make targets to allow parallel make. 
Submitted by: Witold Filipczyk <witekfl@poczta.gazeta.pl>

PR: #513
 2003-12-03 16:29:16 +00:00
Geoff Thorpe
2bfd2c74d2 Incremental cleanups to bn_lib.c. 
- Add missing bn_check_top() calls and relocate some others
- Use BN_is_zero() where appropriate
- Remove assert()s that bn_check_top() is already covering
- Simplify the code in places (esp. bn_expand2())
- Only keep ambiguous zero handling if BN_STRICT isn't defined
- Remove some white-space and make some other aesthetic tweaks
 2003-12-02 20:01:30 +00:00
Geoff Thorpe
82b2f57e30 Use the BN_is_odd() macro in place of code that (inconsistently) does much 
the same thing.

Also, I have some stuff on the back-burner related to some BN_CTX notes
from Peter Gutmann about his cryptlib hacks to the bignum code. The BN_CTX
comments are there to remind me of some relevant points in the code.
 2003-12-02 03:28:24 +00:00
Geoff Thorpe
2ae1ea3788 BN_FLG_FREE is of extremely dubious usefulness, and is only referred to 
once in the source (where it is set for the benefit of no other code
whatsoever). I've deprecated the declaration in the header and likewise
made the use of the flag conditional in bn_lib.c. Note, this change also
NULLs the 'd' pointer in a BIGNUM when it is reset but not deallocated.
 2003-12-02 03:16:56 +00:00
Geoff Thorpe
34066d741a Declare the static BIGNUM "BN_value_one()" more carefully. 2003-12-01 23:13:17 +00:00
Geoff Thorpe
b74cc0776b Add missing bn_check_top()s to bn_kron.c, remove some miscellaneous 
white-space, and include extra headers to satisfy debugging builds.
 2003-12-01 23:11:45 +00:00
Geoff Thorpe
e7e5fe4705 Add missing bn_check_top()s to bn_gf2m.c and remove some miscellaneous 
white-space.
 2003-12-01 23:10:21 +00:00
Geoff Thorpe
998ae048e7 The bn_set_max() macro is only "used" by the bn_set_[low|high]() macros 
which, in turn, are used nowhere at all. This is a good thing because
bn_set_max() would currently generate code that wouldn't compile (BIGNUM
has no 'max' element).

The only apparent use for bn_set_[low|high] would be for implementing
windowing algorithms, and all of openssl's seem to use bn_***_words()
helpers instead (including the BN_div() that Nils fixed recently, which had
been using independently-coded versions of what these unused macros are
intended for). I'm therefore consigning these macros to cvs oblivion in the
name of readability.
 2003-12-01 22:11:08 +00:00
Geoff Thorpe
e65c2b9872 bn_fix_top() exists for compatibility's sake and is mapped to 
bn_correct_top() or bn_check_top() depending on debug settings. For
internal source, all bn_fix_top()s should be converted one way or the other
depending on whether the use of bn_correct_top() is justified.

For BN_div_recp(), these cases should not require correction if the other
bignum functions are doing their jobs properly, so convert to
bn_check_top().
 2003-12-01 21:59:40 +00:00
Richard Levitte
b0ea8b160c It was pointed out to me that if the requested size is 0, we shouldn't 
ty to allocate anything at all.  This will allow eNULL to still work.

PR: 751
Notified by: Lutz Jaenicke
 2003-12-01 13:25:39 +00:00
Richard Levitte
2fe9ab8e20 It was pointed out to me that if the requested size is 0, we shouldn't 
ty to allocate anything at all.  This will allow eNULL to still work.

PR: 751
Notified by: Lutz Jaenicke
 2003-12-01 13:25:37 +00:00
Richard Levitte
bb569f97b9 Check that OPENSSL_malloc() really returned some memory. 
PR: 751
Notified by: meder@mcs.anl.gov
Reviewed by: Lutz Jaenicke, Richard Levitte
 2003-12-01 12:11:57 +00:00
Richard Levitte
1145e03870 Check that OPENSSL_malloc() really returned some memory. 
PR: 751
Notified by: meder@mcs.anl.gov
Reviewed by: Lutz Jaenicke, Richard Levitte
 2003-12-01 12:11:55 +00:00
Richard Levitte
31670c94bc CRYPTO_malloc(), CRYPTO_realloc() and variants of them should return NULL 
if the give size is 0.

This is a thought that came up in PR 751.
 2003-12-01 12:06:19 +00:00
Richard Levitte
6781efb92f CRYPTO_malloc(), CRYPTO_realloc() and variants of them should return NULL 
if the give size is 0.

This is a thought that came up in PR 751.
 2003-12-01 12:06:15 +00:00
Lutz Jänicke
0bf1c1d80d Some more ASFLAGS settings required 
PR: #735
Submitted by: Tim Rice <tim@multitalents.net>
 2003-12-01 08:12:47 +00:00
Lutz Jänicke
67e5d33dd7 Some more ASFLAGS settings required 
PR: #735
Submitted by: Tim Rice <tim@multitalents.net>
 2003-12-01 08:12:01 +00:00
Geoff Thorpe
6ed474ca66 Add more debugging to my Configure target, and "make update" to incorporate 
this and a few other changes.
 2003-11-30 23:29:27 +00:00
Geoff Thorpe
46cb8d3689 If BN_STRICT is defined, don't accept an ambiguous representation of zero 
(ie. where top may be zero, or it may be one if the corresponding word is
set to zero). Note, this only affects the macros in bn.h, there are probably
similar corrections required in some c files.

Also, clarify the audit-related macros at the top of the header. Mental
note: I must not forget to clean all this out before 0.9.8 is released ...
 2003-11-30 22:23:12 +00:00
Geoff Thorpe
23fc5ac646 Improve a couple of the bignum macros. Note, this doesn't eliminate 
tolerance of ambiguous zero-representation, it just improves
BN_abs_is_word() and simplifies other macros that depend on it.
 2003-11-30 22:02:10 +00:00
Geoff Thorpe
5734bebe05 Make BN_DEBUG_RAND less painfully slow by only consuming one byte of 
pseudo-random data for each bn_pollute().
 2003-11-30 21:21:30 +00:00
Geoff Thorpe
657a919598 This improves the placement of check_top() macros in a couple of bn_lib 
functions.
 2003-11-29 20:34:07 +00:00
Richard Levitte
da17495b65 Make sure the documentation matches reality. 
PR: 755
Notified by: Jakub Bogusz <qboosh@pld-linux.org>
 2003-11-29 10:33:28 +00:00
Richard Levitte
6859bb1a22 Make sure the documentation matches reality. 
PR: 755
Notified by: Jakub Bogusz <qboosh@pld-linux.org>
 2003-11-29 10:33:25 +00:00
Richard Levitte
b64614adfe We're getting a clash with C++ because it has a type called 'list'. 
Therefore, change all instances of the symbol 'list' to something else.

PR: 758
Submitted by: Frédéric Giudicelli <groups@newpki.org>
 2003-11-29 10:25:42 +00:00
Richard Levitte
3822740ce3 We're getting a clash with C++ because it has a type called 'list'. 
Therefore, change all instances of the symbol 'list' to something else.

PR: 758
Submitted by: Frédéric Giudicelli <groups@newpki.org>
 2003-11-29 10:25:37 +00:00