Matt Caswell
1159e24d56
Add dire warnings about the "reuse" capability of the d2i_* functions.
...
Reviewed-by: Emilia Käsper <emilia@openssl.org>
2015-02-25 17:46:20 +00:00
Matt Caswell
b91058d222
Provide documentation for i2d_ECPrivateKey and d2i_ECPrivateKey
...
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Conflicts:
doc/crypto/EC_KEY_new.pod
doc/crypto/EC_POINT_new.pod
2015-02-25 17:46:20 +00:00
Matt Caswell
89117535f1
Fix a failure to NULL a pointer freed on error.
...
Inspired by BoringSSL commit 517073cd4b by Eric Roman <eroman@chromium.org>
CVE-2015-0209
Reviewed-by: Emilia Käsper <emilia@openssl.org>
2015-02-25 17:46:20 +00:00
Matt Caswell
08a2df480d
Import evp_test.c from BoringSSL. Unfortunately we already have a file
...
called evp_test.c, so I have called this one evp_extra_test.c
Reviewed-by: Emilia Käsper <emilia@openssl.org>
Conflicts:
crypto/evp/Makefile
test/Makefile
Conflicts:
test/Makefile
crypto/evp/evp_extra_test.c
2015-02-25 17:40:41 +00:00
Dr. Stephen Henson
9cd061725b
Document -no_explicit
...
Reviewed-by: Rich Salz <rsalz@openssl.org>
(cherry picked from commit 384dee5124
)
2015-02-24 15:28:56 +00:00
Edgar Pek
e347d80287
Fix null-pointer dereference
...
Signed-off-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(cherry picked from commit bcfa19a8d1
)
2015-02-22 13:27:20 +01:00
Kurt Roeckx
9e7a5464d7
Fix memory leak
...
Reviewed-by: Matt Caswell <matt@openssl.org>
(cherry picked from commit edac5dc220
)
2015-02-22 13:27:19 +01:00
Doug Hogan
e224c45317
Avoid a double-free in an error path.
...
Signed-off-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Matt Caswell <matt@openssl.org>
(cherry picked from commit 1549a26520
)
2015-02-22 13:27:19 +01:00
Richard Levitte
e961fa4479
Restore -DTERMIO/-DTERMIOS on Windows platforms.
...
The previous defaulting to TERMIOS took away -DTERMIOS / -DTERMIO a
bit too enthusiastically. Windows/DOSish platforms of all sorts get
identified as OPENSSL_SYS_MSDOS, and they get a different treatment
altogether UNLESS -DTERMIO or -DTERMIOS is explicitely given with the
configuration. The answer is to restore those macro definitions for
the affected configuration targets.
Reviewed-by: Tim Hudson <tjh@openssl.org>
(cherry picked from commit ba4bdee718
)
Conflicts:
Configure
2015-02-22 09:42:08 +01:00
Richard Levitte
aafdbbc469
Assume TERMIOS is default, remove TERMIO on all Linux.
...
The rationale for this move is that TERMIOS is default, supported by
POSIX-1.2001, and most definitely on Linux. For a few other systems,
TERMIO may still be the termnial interface of preference, so we keep
-DTERMIO on those in Configure.
crypto/ui/ui_openssl.c is simplified in this regard, and will define
TERMIOS for all systems except a select few exceptions.
Reviewed-by: Matt Caswell <matt@openssl.org>
(cherry picked from commit 64e6bf64b3
)
Conflicts:
Configure
crypto/ui/ui_openssl.c
2015-02-22 09:15:11 +01:00
Rich Salz
a9ea906654
RT3684: rand_egd needs stddef.h
...
Reviewed-by: Andy Polyakov <appro@openssl.org>
(cherry picked from commit 872f91c403
)
2015-02-12 14:24:21 -05:00
Graeme Perrow
bb14c2c9ca
RT3670: Check return from BUF_MEM_grow_clean
...
Reviewed-by: Richard Levitte <levitte@openssl.org>
(cherry picked from commit b0333e697c
)
2015-02-12 13:01:42 -05:00
Eric Dequin
a1331af032
Missing OPENSSL_free on error path.
...
Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(cherry picked from commit 1d2932de4c
)
2015-02-12 11:15:39 -05:00
Andy Polyakov
e48e86232e
Bring objects.pl output even closer to new format.
...
Reviewed-by: Matt Caswell <matt@openssl.org>
(cherry picked from commit 849037169d
)
2015-02-09 16:02:44 +01:00
Dr. Stephen Henson
66aacf3872
Fix memory leak reporting.
...
Free up bio_err after memory leak data has been printed to it.
In int_free_ex_data if ex_data is NULL there is nothing to free up
so return immediately and don't reallocate it.
Reviewed-by: Tim Hudson <tjh@openssl.org>
(cherry picked from commit 9c7a780bbe
)
2015-02-09 13:01:28 +00:00
Andy Polyakov
97ac0d8564
Harmonize objects.pl output with new format.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
(cherry picked from commit 7ce3862319
)
2015-02-09 09:59:38 +01:00
Matt Caswell
f8e662e71c
Fix error handling in ssltest
...
Reviewed-by: Richard Levitte <levitte@openssl.org>
(cherry picked from commit ae632974f9
)
2015-02-06 10:10:49 +00:00
Rich Salz
468e04bf1f
Fixed bad formatting in crypto/des/spr.h
...
Reviewed-by: Andy Polyakov <appro@openssl.org>
(cherry picked from commit 7e35f06ea9
)
2015-02-05 09:45:48 -05:00
Dr. Stephen Henson
ac7d33deec
Make objxref.pl output in correct format
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
(cherry picked from commit 6922ddee1b
)
2015-02-04 13:35:49 +00:00
Dr. Stephen Henson
6b7c68e038
Check PKCS#8 pkey field is valid before cleansing.
...
PR:3683
Reviewed-by: Tim Hudson <tjh@openssl.org>
(cherry picked from commit 52e028b9de
)
2015-02-03 14:02:25 +00:00
Richard Levitte
81ce20e6ac
dso_vms needs to add the .EXE extension if there is none already
...
Reviewed-by: Rich Salz <rsalz@openssl.org>
(cherry picked from commit be7b1097e2
)
2015-01-30 05:03:14 +01:00
Viktor Dkhovni
324a977492
Replace exit() with error return.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-27 16:36:25 -05:00
Rich Salz
69aeb99f32
Revert "Remove engine_rsax and its asm file."
...
This reverts commit 5226c62b76
.
Reviewed-by: Andy Polyakov <appro@openssl.org>
2015-01-27 16:35:55 -05:00
Matt Caswell
53e652ae44
Provide documentation for all SSL(_CTX)?_(get|set)(_default)?_read_ahead
...
functions.
Reviewed-by: Andy Polyakov <appro@openssl.org>
(cherry picked from commit 8507474564
)
2015-01-27 14:35:13 +00:00
Matt Caswell
131d3fdfe2
Remove explicit setting of read_ahead for DTLS. It never makes sense not to
...
use read_ahead with DTLS because it doesn't work. Therefore read_ahead needs
to be the default.
Reviewed-by: Andy Polyakov <appro@openssl.org>
(cherry picked from commit f400241251
)
Conflicts:
apps/s_client.c
apps/s_server.c
2015-01-27 14:35:11 +00:00
Matt Caswell
1895583835
Make DTLS always act as if read_ahead is set. The actual value of read_ahead
...
is ignored for DTLS.
RT#3657
Reviewed-by: Andy Polyakov <appro@openssl.org>
(cherry picked from commit 8dd4ad0ff5
)
2015-01-27 14:33:32 +00:00
Rich Salz
5226c62b76
Remove engine_rsax and its asm file.
...
cherry-picked from db7cb7ab9a
This wasn't cleanly cherry-picked, since the build
process changed a bit for 1.0.2.
Reviewed-by: Andy Polyakov <appro@openssl.org>
2015-01-26 11:01:30 -05:00
Rich Salz
491f3e4e8e
Make OPENSSL_config truly ignore errors.
...
Per discussion: should not exit. Should not print to stderr.
Errors are ignored. Updated doc to reflect that, and the fact
that this function is to be avoided.
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
(cherry picked from commit abdd677125
)
2015-01-25 21:15:57 -05:00
Kurt Roeckx
184693f4af
Fix segfault with empty fields as last in the config.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-24 15:04:53 +01:00
Matt Caswell
925bfca5d3
Fix for reformat problems with e_padlock.c
...
Reviewed-by: Andy Polyakov <appro@openssl.org>
(cherry picked from commit d3b7cac41b
)
2015-01-22 14:22:19 +00:00
Matt Caswell
90a5adffc7
Fix formatting error in pem.h
...
Reviewed-by: Andy Polyakov <appro@openssl.org>
Conflicts:
crypto/pem/pem.h
2015-01-22 14:22:19 +00:00
Rob Stradling
73f8982017
Use inner algorithm when printing certificate.
...
Reviewed-by: Stephen Henson <steve@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(cherry picked from commit 004efdbb41
)
2015-01-22 14:10:02 +00:00
Matt Caswell
cda8845ded
Re-align some comments after running the reformat script.
...
This should be a one off operation (subsequent invokation of the
script should not move them)
This commit is for the 1.0.1 changes
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:39:01 +00:00
Matt Caswell
47050853f1
Rerun util/openssl-format-source -v -c .
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:38:49 +00:00
Matt Caswell
10621efd32
Run util/openssl-format-source -v -c .
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:38:39 +00:00
Matt Caswell
e498b83fed
More tweaks for comments due indent issues
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:38:30 +00:00
Matt Caswell
2e4d15fd04
Fix modes.h so that indent doesn't complain
...
Conflicts:
crypto/modes/modes.h
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:38:24 +00:00
Matt Caswell
3b0e0d1231
Backport hw_ibmca.c from master due to failed merge
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:38:18 +00:00
Matt Caswell
f7b36402d6
Tweaks for comments due to indent's inability to handle them
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:38:11 +00:00
Matt Caswell
0f6c965823
Move more comments that confuse indent
...
Conflicts:
crypto/dsa/dsa.h
demos/engines/ibmca/hw_ibmca.c
ssl/ssl_locl.h
Conflicts:
crypto/bn/rsaz_exp.c
crypto/evp/e_aes_cbc_hmac_sha1.c
crypto/evp/e_aes_cbc_hmac_sha256.c
ssl/ssl_locl.h
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:38:04 +00:00
Dr. Stephen Henson
4651718410
Delete trailing whitespace from output.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:37:59 +00:00
Dr. Stephen Henson
fbfad23f0c
Add -d debug option to save preprocessed files.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:37:54 +00:00
Dr. Stephen Henson
68085a73af
Test option -nc
...
Add option -nc which sets COMMENTS=true but disables all indent comment
reformatting options.
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:37:48 +00:00
Matt Caswell
bc974f8b36
Add ecp_nistz256.c to list of files skipped by openssl-format-source
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:37:43 +00:00
Matt Caswell
72d7ed66e2
Manually reformat aes_x86core.c and add it to the list of files skipped by
...
openssl-format-source
Conflicts:
crypto/aes/aes_x86core.c
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:37:36 +00:00
Andy Polyakov
2655f5644d
crypto/ofb128.c: make it indent-friendly.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:37:31 +00:00
Andy Polyakov
3af30a7b8b
modes/ctr128.c: make it indent-friendly.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:37:26 +00:00
Andy Polyakov
e060570e62
modes/cfb128.c: make it indent-friendly.
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:37:20 +00:00
Matt Caswell
1ac02e4b89
Fix indent comment corruption issue
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:37:15 +00:00
Matt Caswell
7116341e18
Amend openssl-format-source so that it give more repeatable output
...
Reviewed-by: Tim Hudson <tjh@openssl.org>
2015-01-22 09:37:10 +00:00