openssl/engines
Dr. Matthias St. Pierre 4a81b8b6e8 engines/dasync: add explaining comments about AES-128-CBC-HMAC-SHA1
Fixes #7950

It was reported that there might be a null pointer dereference in the
implementation of the dasync_aes_128_cbc_hmac_sha1() cipher, because
EVP_aes_128_cbc_hmac_sha1() can return a null pointer if AES-NI is
not available. It took some analysis to find out that this is not
an issue in practice, and these comments explain the reason to comfort
further NPD hunters.

Detected by GitHub user @wurongxin1987 using the Sourcebrella Pinpoint
static analyzer.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/8305)

(cherry picked from commit a4a0a1eb43)
2019-02-22 18:11:16 +01:00
..
asm Update copyright year 2018-03-20 13:08:46 +00:00
build.info Harmonize the make variables across all known platforms families 2018-02-14 17:13:53 +01:00
e_afalg.c Replace accidentally used C99 macro __func__ with __FILE__/__LINE__ 2018-06-23 19:18:30 +02:00
e_afalg.ec make error tables const and separate header file 2017-06-07 15:12:03 -04:00
e_afalg.h extending afalg with aes-cbc-192/256, afalgtest.c also updated accordingly. comments from matt, Stephen considered 2017-12-08 10:39:52 +00:00
e_afalg.txt Put message strings in state files 2017-06-12 15:03:40 -04:00
e_afalg_err.c make error tables const and separate header file 2017-06-07 15:12:03 -04:00
e_afalg_err.h make error tables const and separate header file 2017-06-07 15:12:03 -04:00
e_capi.c CAPI engine: add support for RSA_NO_PADDING 2018-09-11 10:27:46 +01:00
e_capi.ec make error tables const and separate header file 2017-06-07 15:12:03 -04:00
e_capi.txt Put message strings in state files 2017-06-12 15:03:40 -04:00
e_capi_err.c Put message strings in state files 2017-06-12 15:03:40 -04:00
e_capi_err.h make error tables const and separate header file 2017-06-07 15:12:03 -04:00
e_dasync.c engines/dasync: add explaining comments about AES-128-CBC-HMAC-SHA1 2019-02-22 18:11:16 +01:00
e_dasync.ec make error tables const and separate header file 2017-06-07 15:12:03 -04:00
e_dasync.txt Put message strings in state files 2017-06-12 15:03:40 -04:00
e_dasync_err.c Put message strings in state files 2017-06-12 15:03:40 -04:00
e_dasync_err.h make error tables const and separate header file 2017-06-07 15:12:03 -04:00
e_ossltest.c Use the TLSv1.3 record header as AAD 2018-03-14 09:51:20 +00:00
e_ossltest.ec make error tables const and separate header file 2017-06-07 15:12:03 -04:00
e_ossltest.txt Put message strings in state files 2017-06-12 15:03:40 -04:00
e_ossltest_err.c Put message strings in state files 2017-06-12 15:03:40 -04:00
e_ossltest_err.h make error tables const and separate header file 2017-06-07 15:12:03 -04:00
e_padlock.c Update copyright year 2018-09-11 13:45:17 +01:00