wbrawner/openssl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
openssl/ssl
History
Matt Caswell 64193c8218 Handle SSL_shutdown while in init more appropriately #2 
Previous commit f73c737c7 attempted to "fix" a problem with the way
SSL_shutdown() behaved whilst in mid-handshake. The original behaviour had
SSL_shutdown() return immediately having taken no action if called mid-
handshake with a return value of 1 (meaning everything was shutdown
successfully). In fact the shutdown has not been successful.

Commit f73c737c7 changed that to send a close_notify anyway and then
return. This seems to be causing some problems for some applications so
perhaps a better (much simpler) approach is revert to the previous
behaviour (no attempt at a shutdown), but return -1 (meaning the shutdown
was not successful).

This also fixes a bug where SSL_shutdown always returns 0 when shutdown
*very* early in the handshake (i.e. we are still using SSLv23_method).

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
2016-02-08 09:30:57 +00:00
..
bio_ssl.c Handle SSL_ERROR_WANT_X509_LOOKUP 2015-09-20 14:21:18 +01:00
clienthellotest.c GH354: Memory leak fixes 2015-08-28 11:59:23 -04:00
d1_both.c Ensure |rwstate| is set correctly on BIO_flush 2015-12-10 12:47:49 +00:00
d1_clnt.c Only call ssl3_init_finished_mac once for DTLS 2015-11-10 18:44:56 +00:00
d1_lib.c Fix Seg fault in DTLSv1_listen 2015-03-19 11:11:22 +00:00
d1_meth.c Ensure the dtls1_get_*_methods work with DTLS_ANY_VERSION 2015-11-04 14:46:03 +00:00
d1_pkt.c Lost alert in DTLS 2015-05-22 09:44:44 +01:00
d1_srtp.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
d1_srvr.c Stop DTLS servers asking for unsafe legacy renegotiation 2015-11-10 19:24:20 +00:00
dtls1.h Fix d2i_SSL_SESSION for DTLS1_BAD_VER 2015-02-27 20:31:28 +00:00
heartbeat_test.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
install-ssl.com Don't forget to install srtp.h as well 2012-05-10 15:01:26 +00:00
kssl.c Remove the "eay" c-file-style indicators 2015-12-18 13:39:34 +01:00
kssl.h Remove the "eay" c-file-style indicators 2015-12-18 13:39:34 +01:00
kssl_lcl.h Remove the "eay" c-file-style indicators 2015-12-18 13:39:34 +01:00
Makefile Add test for SSL_set_session_ticket_ext 2015-07-27 16:50:38 +01:00
s2_clnt.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
s2_enc.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
s2_lib.c Fix reachable assert in SSLv2 servers. 2015-03-19 12:58:35 +00:00
s2_meth.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
s2_pkt.c Add length sanity check in SSLv2 n_do_ssl_write() 2015-04-29 17:23:45 +01:00
s2_srvr.c Better SSLv2 cipher-suite enforcement 2016-01-28 13:48:24 +00:00
s3_both.c Fix DTLS1.2 buffers 2015-09-02 00:37:58 +01:00
s3_cbc.c Good hygiene with size_t output argument. 2015-11-21 05:23:20 -05:00
s3_clnt.c Change minimum DH size from 768 to 1024 2016-01-11 00:01:52 +01:00
s3_enc.c Ensure all EVP calls have their returns checked where appropriate 2015-11-20 15:47:44 +00:00
s3_lib.c Handle SSL_shutdown while in init more appropriately #2 2016-02-08 09:30:57 +00:00
s3_meth.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
s3_pkt.c Fix write failure handling in DTLS1.2 2015-07-30 10:18:43 +01:00
s3_srvr.c Always generate DH keys for ephemeral DH cipher suites 2016-01-28 13:49:56 +00:00
s23_clnt.c Fix session resumption 2015-09-02 00:29:00 +01:00
s23_lib.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
s23_meth.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
s23_pkt.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
s23_srvr.c Re-align some comments after running the reformat script. 2015-01-22 09:31:48 +00:00
srtp.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
ssl-lib.com VMS fixups for 1.0.2 2015-01-07 02:15:35 +01:00
ssl.h Handle SSL_shutdown while in init more appropriately #2 2016-02-08 09:30:57 +00:00
ssl2.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
ssl3.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
ssl23.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
ssl_algs.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
ssl_asn1.c Make no-psk compile without warnings. 2015-09-16 18:09:00 +01:00
ssl_cert.c Set reference count earlier 2015-11-24 21:54:38 +01:00
ssl_ciph.c Ensure all EVP calls have their returns checked where appropriate 2015-11-20 15:47:44 +00:00
ssl_conf.c Add support for ServerInfo SSL_CONF option. 2015-03-18 12:31:06 +00:00
ssl_err.c Handle SSL_shutdown while in init more appropriately #2 2016-02-08 09:30:57 +00:00
ssl_err2.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
ssl_lib.c Handle SSL_shutdown while in init more appropriately #2 2016-02-08 09:30:57 +00:00
ssl_locl.h Ensure all EVP calls have their returns checked where appropriate 2015-11-20 15:47:44 +00:00
ssl_rsa.c Ensure all EVP calls have their returns checked where appropriate 2015-11-20 15:47:44 +00:00
ssl_sess.c Validate ClientHello session_id field length and send alert on failure 2016-01-19 15:37:16 +00:00
ssl_stat.c Add Error state 2015-05-05 19:50:12 +01:00
ssl_task.c Re-align some comments after running the reformat script. 2015-01-22 09:31:48 +00:00
ssl_txt.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
ssl_utst.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
ssltest.c _BSD_SOURCE is deprecated, use _DEFAULT_SOURCE instead 2015-12-02 18:49:28 +01:00
t1_clnt.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
t1_enc.c Fix more URLs mangled by reformat 2015-12-19 14:44:03 +00:00
t1_ext.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
t1_lib.c Ensure we don't call the OCSP callback if resuming a session 2015-12-27 22:02:33 +00:00
t1_meth.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
t1_reneg.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
t1_srvr.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
t1_trce.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
tls1.h Fix references to various RFCs 2015-10-23 20:32:58 +02:00
tls_srp.c Code style: space after 'if' 2015-04-16 13:50:01 -04:00