TLS/SSL and crypto library
Find a file
Nicola Tuveri 0c5d725ebf Fix segfault in RSA_free() (and DSA/DH/EC_KEY)
`RSA_free()` and friends are called in case of error from
`RSA_new_method(ENGINE *e)` (or the respective equivalent functions).

For the rest of the description I'll talk about `RSA_*`, but the same
applies for the equivalent `DSA_free()`, `DH_free()`, `EC_KEY_free()`.

If `RSA_new_method()` fails because the engine does not implement the
required method, when `RSA_free(RSA *r)` is called,
`r->meth == NULL` and a segfault happens while checking if
`r->meth->finish` is defined.

This commit fixes this issue by ensuring that `r->meth` is not NULL
before dereferencing it to check for `r->meth->finish`.

Fixes #7102 .

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/7121)
2018-09-05 15:22:35 +03:00
.github Remind people to have 'Fixes #XXXX' in the commit message 2017-04-02 21:51:47 +02:00
apps New openssl subject parser hard to debug 2018-09-05 05:42:17 +10:00
boringssl@2070f8ad91 Update ossl_config.json for later BoringSSL commit 2017-03-14 12:12:13 +00:00
Configurations Configurations/unix-Makefile.tmpl: address find portability issue. 2018-08-24 18:56:24 +02:00
crypto Fix segfault in RSA_free() (and DSA/DH/EC_KEY) 2018-09-05 15:22:35 +03:00
demos demos/evp: add make clean 2018-09-04 08:07:22 +10:00
doc Clarify the return value of SSL_client_version() 2018-09-04 11:34:40 +01:00
engines Replace accidentally used C99 macro __func__ with __FILE__/__LINE__ 2018-06-23 19:18:30 +02:00
external/perl Existing transfer modules must have a package and a $VERSION 2018-07-10 16:32:20 +02:00
fuzz Update fuzz corpora 2018-08-23 22:08:08 +02:00
include Fixed a comment that referenced the wrong method 2018-09-04 09:46:19 +10:00
krb5@b9ad6c4950 [extended tests] Enable krb5 tests in Travis 2017-04-18 19:10:25 +02:00
ms Update copyright year 2018-05-01 13:34:30 +01:00
os-dep Move Haiku configuration to separate config file to denote 2016-05-19 22:39:52 +02:00
pyca-cryptography@58fd9c412a fix pyca/cryptography test suite failure 2018-06-23 18:29:32 +02:00
ssl key zeroization fix for a branch path of tls13_final_finish_mac 2018-09-05 05:06:00 +10:00
test Add a test for RSA key exchange with both RSA and RSA-PSS certs 2018-09-04 11:28:01 +01:00
tools Update copyright year 2018-03-20 13:08:46 +00:00
util Rename SSL[_CTX]_add1_CA_list -> SSL[_CTX]_add1_to_CA_list 2018-09-03 13:10:17 +02:00
VMS Simplify the handling of shared library version numbers 2017-07-26 22:53:03 +02:00
.gitattributes crypto/pkcs12: facilitate accessing data with non-interoperable password. 2016-08-22 13:52:59 +02:00
.gitignore Add test/versions to gitignore 2018-04-04 17:04:00 +01:00
.gitmodules [extended tests] Enable krb5 tests in Travis 2017-04-18 19:10:25 +02:00
.travis-apt-pin.preferences Fix travis clang-3.9 builds 2017-06-23 17:57:02 +01:00
.travis-create-release.sh Reduce travis-ci log output 2018-03-08 21:18:35 +01:00
.travis.yml Revert ".travis.yml: omit linux-ppc64le target." 2018-08-31 10:56:35 +02:00
ACKNOWLEDGEMENTS Refer to website for acknowledgements. 2015-12-08 16:07:09 -05:00
appveyor.yml CI config: no need to make both install and install_docs 2018-05-14 17:51:48 +02:00
AUTHORS Update AUTHORS list, add commentary 2018-07-08 20:32:04 -04:00
build.info Configurations/10-main.conf: replace -bexpall with explicit list on AIX. 2018-06-13 10:48:27 +02:00
CHANGES Fix a version error in CHANGES and NEWS 2018-08-21 13:12:44 +01:00
config Configure: move --noexecstack probe to Configure. 2018-05-05 20:44:56 +02:00
config.com Update copyright year 2018-02-13 13:59:25 +00:00
Configure Configure: don't probe for --noexecstack assembler option on Darwin. 2018-08-18 18:23:22 +02:00
CONTRIBUTING Add a note on CHANGES and NEWS in CONTRIBUTING 2018-05-17 13:51:11 +02:00
e_os.h Remove __cplusplus preamble from internal headers 2018-06-22 12:24:59 +02:00
FAQ Move FAQ to the web. 2015-08-16 19:02:29 -04:00
INSTALL Turn on TLSv1.3 downgrade protection by default 2018-08-15 12:33:30 +01:00
LICENSE Update the license end year 2018-01-20 10:02:23 +01:00
NEWS Fix a version error in CHANGES and NEWS 2018-08-21 13:12:44 +01:00
NOTES.ANDROID INSTALL,NOTES.ANDROID: minor updates. 2018-08-07 08:53:12 +02:00
NOTES.DJGPP Slight cleanup of the collection of READMEs, INSTALLs and NOTES 2016-05-23 16:02:53 +02:00
NOTES.PERL Tweaks to NOTES.PERL 2016-06-03 17:10:16 +01:00
NOTES.UNIX NOTES.UNIX: add "Linking your application" paragraph 2018-06-26 12:28:06 +02:00
NOTES.VMS More typo fixes 2017-03-29 07:14:29 +02:00
NOTES.WIN INSTALL,NOTES.WIN: classify no-asm as non-production option. 2018-07-25 15:47:12 +02:00
README Prepare for 1.1.1-pre10-dev 2018-08-21 13:15:56 +01:00
README.ENGINE Remove bsd_cryptodev engine 2017-06-19 09:31:45 -04:00
README.FIPS Remove more (rest?) of FIPS build stuff. 2016-01-06 12:07:26 -05:00

 OpenSSL 1.1.1-pre10-dev

 Copyright (c) 1998-2018 The OpenSSL Project
 Copyright (c) 1995-1998 Eric A. Young, Tim J. Hudson
 All rights reserved.

 DESCRIPTION
 -----------

 The OpenSSL Project is a collaborative effort to develop a robust,
 commercial-grade, fully featured, and Open Source toolkit implementing the
 Transport Layer Security (TLS) protocols (including SSLv3) as well as a
 full-strength general purpose cryptographic library.

 OpenSSL is descended from the SSLeay library developed by Eric A. Young
 and Tim J. Hudson.  The OpenSSL toolkit is licensed under a dual-license (the
 OpenSSL license plus the SSLeay license), which means that you are free to
 get and use it for commercial and non-commercial purposes as long as you
 fulfill the conditions of both licenses.

 OVERVIEW
 --------

 The OpenSSL toolkit includes:

 libssl (with platform specific naming):
     Provides the client and server-side implementations for SSLv3 and TLS.

 libcrypto (with platform specific naming):
     Provides general cryptographic and X.509 support needed by SSL/TLS but
     not logically part of it.

 openssl:
     A command line tool that can be used for:
        Creation of key parameters
        Creation of X.509 certificates, CSRs and CRLs
        Calculation of message digests
        Encryption and decryption
        SSL/TLS client and server tests
        Handling of S/MIME signed or encrypted mail
        And more...

 INSTALLATION
 ------------

 See the appropriate file:
        INSTALL         Linux, Unix, Windows, OpenVMS, ...
        NOTES.*         INSTALL addendums for different platforms

 SUPPORT
 -------

 See the OpenSSL website www.openssl.org for details on how to obtain
 commercial technical support. Free community support is available through the
 openssl-users email list (see
 https://www.openssl.org/community/mailinglists.html for further details).

 If you have any problems with OpenSSL then please take the following steps
 first:

    - Download the latest version from the repository
      to see if the problem has already been addressed
    - Configure with no-asm
    - Remove compiler optimization flags

 If you wish to report a bug then please include the following information
 and create an issue on GitHub:

    - OpenSSL version: output of 'openssl version -a'
    - Configuration data: output of 'perl configdata.pm --dump'
    - OS Name, Version, Hardware platform
    - Compiler Details (name, version)
    - Application Details (name, version)
    - Problem Description (steps that will reproduce the problem, if known)
    - Stack Traceback (if the application dumps core)

 Just because something doesn't work the way you expect does not mean it
 is necessarily a bug in OpenSSL. Use the openssl-users email list for this type
 of query.

 HOW TO CONTRIBUTE TO OpenSSL
 ----------------------------

 See CONTRIBUTING

 LEGALITIES
 ----------

 A number of nations restrict the use or export of cryptography. If you
 are potentially subject to such restrictions you should seek competent
 professional legal advice before attempting to develop or distribute
 cryptographic code.