openssl/ssl/statem
Matt Caswell 37857e9b52 Don't signal SSL_CB_HANDSHAKE_START for TLSv1.3 post-handshake messages
The original 1.1.1 design was to use SSL_CB_HANDSHAKE_START and
SSL_CB_HANDSHAKE_DONE to signal start/end of a post-handshake message
exchange in TLSv1.3. Unfortunately experience has shown that this confuses
some applications who mistake it for a TLSv1.2 renegotiation. This means
that KeyUpdate messages are not handled properly.

This commit removes the use of SSL_CB_HANDSHAKE_START and
SSL_CB_HANDSHAKE_DONE to signal the start/end of a post-handshake
message exchange. Individual post-handshake messages are still signalled in
the normal way.

This is a potentially breaking change if there are any applications already
written that expect to see these TLSv1.3 events. However, without it,
KeyUpdate is not currently usable for many applications.

Fixes #8069

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/8096)

(cherry picked from commit 4af5836b55)
2019-02-14 16:25:44 +00:00
..
extensions.c Don't complain if we receive the cryptopro extension in the ClientHello 2019-01-07 09:43:28 +00:00
extensions_clnt.c Ignore disabled ciphers when deciding if we are using ECC 2018-11-08 11:31:22 +00:00
extensions_cust.c Update copyright year 2018-02-13 13:59:25 +00:00
extensions_srvr.c Send a NewSessionTicket after using an external PSK 2018-09-04 11:22:26 +01:00
README
statem.c Don't signal SSL_CB_HANDSHAKE_START for TLSv1.3 post-handshake messages 2019-02-14 16:25:44 +00:00
statem.h Tolerate encrypted or plaintext alerts 2018-08-08 10:16:58 +01:00
statem_clnt.c Fix end-point shared secret for DTLS/SCTP 2019-02-01 12:03:43 +00:00
statem_dtls.c Don't memcpy the contents of an empty fragment 2018-05-12 09:59:02 +01:00
statem_lib.c Don't signal SSL_CB_HANDSHAKE_START for TLSv1.3 post-handshake messages 2019-02-14 16:25:44 +00:00
statem_locl.h Separate ca_names handling for client and server 2018-11-12 14:38:47 +00:00
statem_srvr.c Don't signal SSL_CB_HANDSHAKE_START for TLSv1.3 post-handshake messages 2019-02-14 16:25:44 +00:00

State Machine Design
====================

This file provides some guidance on the thinking behind the design of the
state machine code to aid future maintenance.

The state machine code replaces an older state machine present in OpenSSL
versions 1.0.2 and below. The new state machine has the following objectives:
    - Remove duplication of state code between client and server
    - Remove duplication of state code between TLS and DTLS
    - Simplify transitions and bring the logic together in a single location
      so that it is easier to validate
    - Remove duplication of code between each of the message handling functions
    - Receive a message first and then work out whether that is a valid
      transition - not the other way around (the other way causes lots of issues
      where we are expecting one type of message next but actually get something
      else)
    - Separate message flow state from handshake state (in order to better
      understand each)
      - message flow state = when to flush buffers; handling restarts in the
        event of NBIO events; handling the common flow of steps for reading a
        message and the common flow of steps for writing a message etc
      - handshake state = what handshake message are we working on now
    - Control complexity: only the state machine can change state: keep all
      the state changes local to the state machine component

The message flow state machine is divided into a reading sub-state machine and a
writing sub-state machine. See the source comments in statem.c for a more
detailed description of the various states and transitions possible.

Conceptually the state machine component is designed as follows:

                        libssl
                           |
---------------------------|-----statem.h--------------------------------------
                           |
                    _______V____________________
                   |                            |
                   |    statem.c                |
                   |                            |
                   |    Core state machine code |
                   |____________________________|
        statem_locl.h     ^          ^
                 _________|          |_______
                |                            |
   _____________|____________   _____________|____________
  |                          | |                          |
  | statem_clnt.c            | | statem_srvr.c            |
  |                          | |                          |
  | TLS/DTLS client specific | | TLS/DTLS server specific |
  | state machine code       | | state machine code       |
  |__________________________| |__________________________|
               |        |_______________|__       |
               |        ________________|  |      |
               |       |                   |      |
   ____________V_______V________   ________V______V_______________
  |                             | |                               |
  | statem_both.c               | | statem_dtls.c                 |
  |                             | |                               |
  | Non core functions common   | | Non core functions common to  |
  | to both servers and clients | | both DTLS servers and clients |
  |_____________________________| |_______________________________|