openssl/test
FdaSilvaYY 760e2d60e6 Fix CID 1434549: Unchecked return value in test/evp_test.c
5. check_return: Calling EVP_EncodeUpdate without checking return value
(as is done elsewhere 4 out of 5 times).

Fix CID 1371695, 1371698: Resource leak in test/evp_test.c

- leaked_storage: Variable edata going out of scope leaks the storage it
points to.

- leaked_storage: Variable encode_ctx going out of scope leaks the
storage it points to

Fix CID 1430437, 1430426, 1430429 : Dereference before null check in test/drbg_cavs_test.c

check_after_deref: Null-checking drbg suggests that it
may be null, but it has already been dereferenced on all paths leading
to the check

Fix CID 1440765: Dereference before null check in test/ssltestlib.c

check_after_deref: Null-checking ctx suggests that it may be null, but
it has already been dereferenced on all paths leading to the check.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/7993)
2019-01-08 16:27:27 +10:00
..
certs Fix cert with rsa instead of rsaEncryption as public key algorithm 2018-12-31 09:47:12 +01:00
ct
d2i-tests
ocsp-tests
ossl_shim Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
recipes Add a test for correct handling of the cryptopro bug extension 2019-01-07 09:39:10 +00:00
smime-certs Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ssl-tests Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
testutil Add a format attribute to the format functions and fix the broken format 2018-12-09 22:02:50 -05:00
aborttest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
afalgtest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
asn1_decode_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
asn1_encode_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
asn1_internal_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
asn1_string_table_test.c typo ANS1 -> ASN1 2018-12-11 20:57:31 +10:00
asn1_time_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
asynciotest.c Use (D)TLS_MAX_VERSION_INTERNAL internally 2018-12-15 12:52:02 +01:00
asynctest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
bad_dtls_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
bftest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
bio_callback_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
bio_enc_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
bioprinttest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
bntest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
bntests.pl Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
build.info Don't link shlibloadtest against libcrypto 2019-01-04 13:19:39 +00:00
CAss.cnf
CAssdh.cnf
CAssdsa.cnf
CAssrsa.cnf
casttest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
CAtsa.cnf
chacha_internal_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
cipher_overhead_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
cipherbytes_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
cipherlist_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ciphername_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
clienthellotest.c Use (D)TLS_MAX_VERSION_INTERNAL internally 2018-12-15 12:52:02 +01:00
cms-examples.pl Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
cmsapitest.c Add a CMS API test 2018-05-08 08:43:39 +01:00
conf_include_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
constant_time_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
crltest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ct_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ctype_internal_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
curve448_internal_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
d2i_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
danetest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
danetest.in Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
danetest.pem
destest.c add missing const 2018-12-09 22:02:48 -05:00
dhtest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
drbg_cavs_data.h Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
drbg_cavs_data_ctr.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
drbg_cavs_data_hash.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
drbg_cavs_data_hmac.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
drbg_cavs_test.c Fix CID 1434549: Unchecked return value in test/evp_test.c 2019-01-08 16:27:27 +10:00
drbgtest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
drbgtest.h Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
dsa_no_digest_size_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
dsatest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
dtls_mtu_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
dtlstest.c Use (D)TLS_MAX_VERSION_INTERNAL internally 2018-12-15 12:52:02 +01:00
dtlsv1listentest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ecdsatest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ecstresstest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ectest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
enginetest.c Cleaner disposal of ephemeral engine ids and names 2018-12-09 22:02:48 -05:00
errtest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
evp_extra_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
evp_test.c Fix CID 1434549: Unchecked return value in test/evp_test.c 2019-01-08 16:27:27 +10:00
evp_test.h Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
exdatatest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
exptest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
fatalerrtest.c Use (D)TLS_MAX_VERSION_INTERNAL internally 2018-12-15 12:52:02 +01:00
generate_buildtest.pl Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
generate_ssl_tests.pl Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
gmdifftest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
gosttest.c Use (D)TLS_MAX_VERSION_INTERNAL internally 2018-12-15 12:52:02 +01:00
handshake_helper.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
handshake_helper.h Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
hmactest.c Cleaner disposal of ephemeral engine ids and names 2018-12-09 22:02:48 -05:00
ideatest.c add missing const in cast 2018-12-09 22:02:49 -05:00
igetest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
lhash_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
md2test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
mdc2_internal_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
mdc2test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
memleaktest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
modes_internal_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ocspapitest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
P1ss.cnf
P2ss.cnf
packettest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
pbelutest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
pemtest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
pkcs7-1.pem
pkcs7.pem
pkey_meth_kdf_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
pkey_meth_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
pkits-test.pl Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
poly1305_internal_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
rc2test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
rc4test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
rc5test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
rdrand_sanitytest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
README
README.external
README.ssltest.md
recordlentest.c Use (D)TLS_MAX_VERSION_INTERNAL internally 2018-12-15 12:52:02 +01:00
rsa_complex.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
rsa_mp_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
rsa_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
run_tests.pl Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
sanitytest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
secmemtest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
serverinfo.pem
serverinfo2.pem
servername_test.c Use (D)TLS_MAX_VERSION_INTERNAL internally 2018-12-15 12:52:02 +01:00
session.pem Don't store the ticket nonce in the session 2018-06-07 10:58:35 +01:00
shibboleth.pfx
shlibloadtest.c Introduce a no-pinshared option 2019-01-04 13:19:39 +00:00
siphash_internal_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
sm2_internal_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
sm4_internal_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
smcont.txt
srptest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ssl_cert_table_internal_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ssl_test.c Use (D)TLS_MAX_VERSION_INTERNAL internally 2018-12-15 12:52:02 +01:00
ssl_test.tmpl
ssl_test_ctx.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ssl_test_ctx.h Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ssl_test_ctx_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
ssl_test_ctx_test.conf
sslapitest.c Fix no-sock 2019-01-06 10:06:43 +00:00
sslbuffertest.c Use (D)TLS_MAX_VERSION_INTERNAL internally 2018-12-15 12:52:02 +01:00
sslcorrupttest.c Use (D)TLS_MAX_VERSION_INTERNAL internally 2018-12-15 12:52:02 +01:00
ssltest_old.c Use (D)TLS_MAX_VERSION_INTERNAL internally 2018-12-15 12:52:02 +01:00
ssltestlib.c Fix CID 1434549: Unchecked return value in test/evp_test.c 2019-01-08 16:27:27 +10:00
ssltestlib.h sslapitest: add test ktls 2018-12-07 11:25:45 +00:00
Sssdsa.cnf
Sssrsa.cnf
stack_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
sysdefault.cnf Apply system_default configuration on SSL_CTX_new(). 2018-03-19 10:22:49 -04:00
sysdefaulttest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
test.cnf
test_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
testcrl.pem
testdsa.pem
testdsapub.pem
testec-p256.pem
testecpub-p256.pem
testp7.pem
testreq2.pem
testrsa.pem
testrsapub.pem
testsid.pem
testutil.h Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
testx509.pem
threadstest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
time_offset_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
tls13ccstest.c Use (D)TLS_MAX_VERSION_INTERNAL internally 2018-12-15 12:52:02 +01:00
tls13encryptiontest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
tls13secretstest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
uitest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
Uss.cnf
v3-cert1.pem
v3-cert2.pem
v3ext.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
v3nametest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
verify_extra_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
versions.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
wpackettest.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
x509_check_cert_pkey_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
x509_dup_cert_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
x509_internal_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
x509_time_test.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00
x509aux.c Following the license change, modify the boilerplates in test/ 2018-12-06 14:19:22 +01:00

How to add recipes
==================

For any test that you want to perform, you write a script located in
test/recipes/, named {nn}-test_{name}.t, where {nn} is a two digit number and
{name} is a unique name of your choice.

Please note that if a test involves a new testing executable, you will need to
do some additions in test/Makefile.  More on this later.


Naming conventions
=================

A test executable is named test/{name}test.c

A test recipe is named test/recipes/{nn}-test_{name}.t, where {nn} is a two
digit number and {name} is a unique name of your choice.

The number {nn} is (somewhat loosely) grouped as follows:

00-04  sanity, internal and essential API tests
05-09  individual symmetric cipher algorithms
10-14  math (bignum)
15-19  individual asymmetric cipher algorithms
20-24  openssl commands (some otherwise not tested)
25-29  certificate forms, generation and verification
30-35  engine and evp
60-79  APIs
   70  PACKET layer
80-89  "larger" protocols (CA, CMS, OCSP, SSL, TSA)
90-98  misc
99     most time consuming tests [such as test_fuzz]


A recipe that just runs a test executable
=========================================

A script that just runs a program looks like this:

    #! /usr/bin/perl

    use OpenSSL::Test::Simple;

    simple_test("test_{name}", "{name}test", "{name}");

{name} is the unique name you have chosen for your test.

The second argument to `simple_test' is the test executable, and `simple_test'
expects it to be located in test/

For documentation on OpenSSL::Test::Simple, do
`perldoc util/perl/OpenSSL/Test/Simple.pm'.


A recipe that runs a more complex test
======================================

For more complex tests, you will need to read up on Test::More and
OpenSSL::Test.  Test::More is normally preinstalled, do `man Test::More' for
documentation.  For OpenSSL::Test, do `perldoc util/perl/OpenSSL/Test.pm'.

A script to start from could be this:

    #! /usr/bin/perl

    use strict;
    use warnings;
    use OpenSSL::Test;

    setup("test_{name}");

    plan tests => 2;                # The number of tests being performed

    ok(test1, "test1");
    ok(test2, "test1");

    sub test1
    {
        # test feature 1
    }

    sub test2
    {
        # test feature 2
    }


Changes to test/build.info
==========================

Whenever a new test involves a new test executable you need to do the
following (at all times, replace {NAME} and {name} with the name of your
test):

* add {name} to the list of programs under PROGRAMS_NO_INST

* create a three line description of how to build the test, you will have
to modify the include paths and source files if you don't want to use the
basic test framework:

    SOURCE[{name}]={name}.c
    INCLUDE[{name}]=.. ../include
    DEPEND[{name}]=../libcrypto libtestutil.a

Generic form of C test executables
==================================

    #include "testutil.h"

    static int my_test(void)
    {
        int testresult = 0;                 /* Assume the test will fail    */
        int observed;

        observed = function();              /* Call the code under test     */
        if (!TEST_int_equal(observed, 2))   /* Check the result is correct  */
            goto end;                       /* Exit on failure - optional   */

        testresult = 1;                     /* Mark the test case a success */
    end:
        cleanup();                          /* Any cleanup you require      */
        return testresult;
    }

    int setup_tests(void)
    {
        ADD_TEST(my_test);                  /* Add each test separately     */
        return 1;                           /* Indicate success             */
    }

You should use the TEST_xxx macros provided by testutil.h to test all failure
conditions.  These macros produce an error message in a standard format if the
condition is not met (and nothing if the condition is met).  Additional
information can be presented with the TEST_info macro that takes a printf
format string and arguments.  TEST_error is useful for complicated conditions,
it also takes a printf format string and argument.  In all cases the TEST_xxx
macros are guaranteed to evaluate their arguments exactly once.  This means
that expressions with side effects are allowed as parameters.  Thus,

    if (!TEST_ptr(ptr = OPENSSL_malloc(..)))

works fine and can be used in place of:

    ptr = OPENSSL_malloc(..);
    if (!TEST_ptr(ptr))

The former produces a more meaningful message on failure than the latter.