openssl/ssl/statem
Benjamin Kaduk 572492aaf0 Revert "Delay setting the sig algs until after the cert_cb has been called"
This reverts commit 524006dd1b.

While this change did prevent the sigalgs from getting inadvertently
clobbered by SSL_set_SSL_CTX(), it also caused the sigalgs to not be
set when the cert_cb runs.  This, in turn, caused significant breakage,
such as SSL_check_chain() failing to find any valid chain.  An alternate
approach to fixing the issue from #7244 will follow.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/9157)

(cherry picked from commit 6f34d7bc7d)
2019-06-26 12:59:04 -05:00
..
extensions.c Following the previous 2 commits also move ecpointformats out of session 2019-06-18 14:26:16 +01:00
extensions_clnt.c Following the previous 2 commits also move ecpointformats out of session 2019-06-18 14:26:16 +01:00
extensions_cust.c Update copyright year 2018-02-13 13:59:25 +00:00
extensions_srvr.c Following the previous 2 commits also move ecpointformats out of session 2019-06-18 14:26:16 +01:00
README Add a state machine README 2015-10-30 08:38:18 +00:00
statem.c Update copyright year 2019-02-26 14:05:09 +00:00
statem.h Tolerate encrypted or plaintext alerts 2018-08-08 10:16:58 +01:00
statem_clnt.c Defer sending a KeyUpdate until after pending writes are complete 2019-06-03 11:57:31 +01:00
statem_dtls.c Don't memcpy the contents of an empty fragment 2018-05-12 09:59:02 +01:00
statem_lib.c Defer sending a KeyUpdate until after pending writes are complete 2019-06-03 11:57:31 +01:00
statem_locl.h Update copyright year 2019-02-26 14:05:09 +00:00
statem_srvr.c Revert "Delay setting the sig algs until after the cert_cb has been called" 2019-06-26 12:59:04 -05:00

State Machine Design
====================

This file provides some guidance on the thinking behind the design of the
state machine code to aid future maintenance.

The state machine code replaces an older state machine present in OpenSSL
versions 1.0.2 and below. The new state machine has the following objectives:
    - Remove duplication of state code between client and server
    - Remove duplication of state code between TLS and DTLS
    - Simplify transitions and bring the logic together in a single location
      so that it is easier to validate
    - Remove duplication of code between each of the message handling functions
    - Receive a message first and then work out whether that is a valid
      transition - not the other way around (the other way causes lots of issues
      where we are expecting one type of message next but actually get something
      else)
    - Separate message flow state from handshake state (in order to better
      understand each)
      - message flow state = when to flush buffers; handling restarts in the
        event of NBIO events; handling the common flow of steps for reading a
        message and the common flow of steps for writing a message etc
      - handshake state = what handshake message are we working on now
    - Control complexity: only the state machine can change state: keep all
      the state changes local to the state machine component

The message flow state machine is divided into a reading sub-state machine and a
writing sub-state machine. See the source comments in statem.c for a more
detailed description of the various states and transitions possible.

Conceptually the state machine component is designed as follows:

                        libssl
                           |
---------------------------|-----statem.h--------------------------------------
                           |
                    _______V____________________
                   |                            |
                   |    statem.c                |
                   |                            |
                   |    Core state machine code |
                   |____________________________|
        statem_locl.h     ^          ^
                 _________|          |_______
                |                            |
   _____________|____________   _____________|____________
  |                          | |                          |
  | statem_clnt.c            | | statem_srvr.c            |
  |                          | |                          |
  | TLS/DTLS client specific | | TLS/DTLS server specific |
  | state machine code       | | state machine code       |
  |__________________________| |__________________________|
               |        |_______________|__       |
               |        ________________|  |      |
               |       |                   |      |
   ____________V_______V________   ________V______V_______________
  |                             | |                               |
  | statem_both.c               | | statem_dtls.c                 |
  |                             | |                               |
  | Non core functions common   | | Non core functions common to  |
  | to both servers and clients | | both DTLS servers and clients |
  |_____________________________| |_______________________________|