TLS/SSL and crypto library
Find a file
Nicola Tuveri 9a43a73380 [ec] Match built-in curves on EC_GROUP_new_from_ecparameters
Description
-----------

Upon `EC_GROUP_new_from_ecparameters()` check if the parameters match any
of the built-in curves. If that is the case, return a new
`EC_GROUP_new_by_curve_name()` object instead of the explicit parameters
`EC_GROUP`.

This affects all users of `EC_GROUP_new_from_ecparameters()`:
- direct calls to `EC_GROUP_new_from_ecparameters()`
- direct calls to `EC_GROUP_new_from_ecpkparameters()` with an explicit
  parameters argument
- ASN.1 parsing of explicit parameters keys (as it eventually
  ends up calling `EC_GROUP_new_from_ecpkparameters()`)

A parsed explicit parameter key will still be marked with the
`OPENSSL_EC_EXPLICIT_CURVE` ASN.1 flag on load, so, unless
programmatically forced otherwise, if the key is eventually serialized
the output will still be encoded with explicit parameters, even if
internally it is treated as a named curve `EC_GROUP`.

Before this change, creating any `EC_GROUP` object using
`EC_GROUP_new_from_ecparameters()`, yielded an object associated with
the default generic `EC_METHOD`, but this was never guaranteed in the
documentation.
After this commit, users of the library that intentionally want to
create an `EC_GROUP` object using a specific `EC_METHOD` can still
explicitly call `EC_GROUP_new(foo_method)` and then manually set the
curve parameters using `EC_GROUP_set_*()`.

Motivation
----------

This has obvious performance benefits for the built-in curves with
specialized `EC_METHOD`s and subtle but important security benefits:
- the specialized methods have better security hardening than the
  generic implementations
- optional fields in the parameter encoding, like the `cofactor`, cannot
  be leveraged by an attacker to force execution of the less secure
  code-paths for single point scalar multiplication
- in general, this leads to reducing the attack surface

Check the manuscript at https://arxiv.org/abs/1909.01785 for an in depth
analysis of the issues related to this commit.

It should be noted that `libssl` does not allow to negotiate explicit
parameters (as per RFC 8422), so it is not directly affected by the
consequences of using explicit parameters that this commit fixes.
On the other hand, we detected external applications and users in the
wild that use explicit parameters by default (and sometimes using 0 as
the cofactor value, which is technically not a valid value per the
specification, but is tolerated by parsers for wider compatibility given
that the field is optional).
These external users of `libcrypto` are exposed to these vulnerabilities
and their security will benefit from this commit.

Related commits
---------------

While this commit is beneficial for users using built-in curves and
explicit parameters encoding for serialized keys, commit
b783beeadf6b80bc431e6f3230b5d5585c87ef87 (and its equivalents for the
1.0.2, 1.1.0 and 1.1.1 stable branches) fixes the consequences of the
invalid cofactor values more in general also for other curves
(CVE-2019-1547).

The following list covers commits in `master` that are related to the
vulnerabilities presented in the manuscript motivating this commit:

- d2baf88c43 [crypto/rsa] Set the constant-time flag in multi-prime RSA too
- 311e903d84 [crypto/asn1] Fix multiple SCA vulnerabilities during RSA key validation.
- b783beeadf [crypto/ec] for ECC parameters with NULL or zero cofactor, compute it
- 724339ff44 Fix SCA vulnerability when using PVK and MSBLOB key formats

Note that the PRs that contributed the listed commits also include other
commits providing related testing and documentation, in addition to
links to PRs and commits backporting the fixes to the 1.0.2, 1.1.0 and
1.1.1 branches.

This commit includes a partial backport of
https://github.com/openssl/openssl/pull/8555
(commit 8402cd5f75)
for which the main author is Shane Lontis.

Responsible Disclosure
----------------------

This and the other issues presented in https://arxiv.org/abs/1909.01785
were reported by Cesar Pereida García, Sohaib ul Hassan, Nicola Tuveri,
Iaroslav Gridin, Alejandro Cabrera Aldaya and Billy Bob Brumley from the
NISEC group at Tampere University, FINLAND.

The OpenSSL Security Team evaluated the security risk for this
vulnerability as low, and encouraged to propose fixes using public Pull
Requests.

_______________________________________________________________________________

Co-authored-by: Shane Lontis <shane.lontis@oracle.com>

(Backport from https://github.com/openssl/openssl/pull/9808)

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/9809)
2019-09-09 14:16:18 +03:00
.github
apps Suppress 'No server certificate CA names sent' message 2019-09-04 16:48:49 +02:00
boringssl@2070f8ad91
Configurations Remove x86/x86_64 BSAES and AES_ASM support 2019-09-07 10:26:48 +02:00
crypto [ec] Match built-in curves on EC_GROUP_new_from_ecparameters 2019-09-09 14:16:18 +03:00
demos Fix Typos 2019-07-31 19:48:30 +02:00
doc Correct documented return value for BIO_get_mem_data() 2019-08-20 22:01:02 +10:00
engines engines/build.info: if the padlock engine is disabled, don't build it! 2019-08-12 11:58:24 +02:00
external/perl Update copyright year 2018-09-11 13:45:17 +01:00
fuzz Fix GOST OID 2019-05-24 12:36:06 +03:00
include Change EVP_CIPHER_CTX_iv_length() to return current ivlen for some modes 2019-08-08 13:19:23 +10:00
krb5@b9ad6c4950
ms Update copyright year 2019-02-26 14:05:09 +00:00
os-dep
pyca-cryptography@09403100de Update the pyca-cryptography submodule 2018-09-10 12:04:03 +01:00
ssl Don't send a status_request extension in a CertificateRequest message 2019-09-06 10:12:51 +01:00
test [ec] Match built-in curves on EC_GROUP_new_from_ecparameters 2019-09-09 14:16:18 +03:00
tools Update copyright year 2018-03-20 13:08:46 +00:00
util Teach TLSProxy how to parse CertificateRequest messages 2019-09-06 10:12:51 +01:00
VMS
.gitattributes Don't export the submodules 'boringssl', 'krb5' and 'pyca-cryptography' 2018-11-24 18:43:54 +01:00
.gitignore Add a compile time test to verify that openssl/rsa.h and complex.h can 2018-09-17 09:44:45 +10:00
.gitmodules
.travis-apt-pin.preferences
.travis-create-release.sh Remove all 'make dist' artifacts 2018-11-23 12:42:21 +01:00
.travis.yml .travis.yml: Use travis_terminate on failure 2019-08-18 13:21:29 +02:00
ACKNOWLEDGEMENTS
appveyor.yml CI config: no need to make both install and install_docs 2018-05-14 17:51:48 +02:00
AUTHORS Update AUTHORS list, add commentary 2018-07-08 20:32:04 -04:00
build.info Configurations/10-main.conf: replace -bexpall with explicit list on AIX. 2018-06-13 10:48:27 +02:00
CHANGES [ec] Match built-in curves on EC_GROUP_new_from_ecparameters 2019-09-09 14:16:18 +03:00
config iOS build: Replace %20 with space in config script 2019-07-08 10:57:30 +02:00
config.com Update copyright year 2018-02-13 13:59:25 +00:00
Configure Configure: clang: move -Wno-unknown-warning-option to the front 2019-09-08 11:02:22 +02:00
CONTRIBUTING Remove unnecessary trailing whitespace 2019-02-05 16:29:17 +01:00
e_os.h Don't include the DEVRANDOM being seeded logic on Android. 2019-08-30 08:02:33 +10:00
FAQ
INSTALL INSTALL: clarify documentation of the --api=x.y.z deprecation option 2019-08-15 14:58:32 +02:00
LICENSE Update copyright year 2019-02-26 14:05:09 +00:00
NEWS Fix Typos 2019-07-01 02:02:06 +08:00
NOTES.ANDROID Remove unnecessary trailing whitespace 2019-02-05 16:29:17 +01:00
NOTES.DJGPP Remove unnecessary trailing whitespace 2019-02-05 16:29:17 +01:00
NOTES.PERL Fix typo in NOTES.PERL 2019-05-16 11:47:53 +10:00
NOTES.UNIX NOTES.UNIX: add "Linking your application" paragraph 2018-06-26 12:28:06 +02:00
NOTES.VMS Remove unnecessary trailing whitespace 2019-02-05 16:29:17 +01:00
NOTES.WIN Fix default installation paths on mingw 2019-07-25 13:08:46 +02:00
README Prepare for 1.1.1d-dev 2019-05-28 15:12:39 +02:00
README.ENGINE
README.FIPS

 OpenSSL 1.1.1d-dev

 Copyright (c) 1998-2019 The OpenSSL Project
 Copyright (c) 1995-1998 Eric A. Young, Tim J. Hudson
 All rights reserved.

 DESCRIPTION
 -----------

 The OpenSSL Project is a collaborative effort to develop a robust,
 commercial-grade, fully featured, and Open Source toolkit implementing the
 Transport Layer Security (TLS) protocols (including SSLv3) as well as a
 full-strength general purpose cryptographic library.

 OpenSSL is descended from the SSLeay library developed by Eric A. Young
 and Tim J. Hudson.  The OpenSSL toolkit is licensed under a dual-license (the
 OpenSSL license plus the SSLeay license), which means that you are free to
 get and use it for commercial and non-commercial purposes as long as you
 fulfill the conditions of both licenses.

 OVERVIEW
 --------

 The OpenSSL toolkit includes:

 libssl (with platform specific naming):
     Provides the client and server-side implementations for SSLv3 and TLS.

 libcrypto (with platform specific naming):
     Provides general cryptographic and X.509 support needed by SSL/TLS but
     not logically part of it.

 openssl:
     A command line tool that can be used for:
        Creation of key parameters
        Creation of X.509 certificates, CSRs and CRLs
        Calculation of message digests
        Encryption and decryption
        SSL/TLS client and server tests
        Handling of S/MIME signed or encrypted mail
        And more...

 INSTALLATION
 ------------

 See the appropriate file:
        INSTALL         Linux, Unix, Windows, OpenVMS, ...
        NOTES.*         INSTALL addendums for different platforms

 SUPPORT
 -------

 See the OpenSSL website www.openssl.org for details on how to obtain
 commercial technical support. Free community support is available through the
 openssl-users email list (see
 https://www.openssl.org/community/mailinglists.html for further details).

 If you have any problems with OpenSSL then please take the following steps
 first:

    - Download the latest version from the repository
      to see if the problem has already been addressed
    - Configure with no-asm
    - Remove compiler optimization flags

 If you wish to report a bug then please include the following information
 and create an issue on GitHub:

    - OpenSSL version: output of 'openssl version -a'
    - Configuration data: output of 'perl configdata.pm --dump'
    - OS Name, Version, Hardware platform
    - Compiler Details (name, version)
    - Application Details (name, version)
    - Problem Description (steps that will reproduce the problem, if known)
    - Stack Traceback (if the application dumps core)

 Just because something doesn't work the way you expect does not mean it
 is necessarily a bug in OpenSSL. Use the openssl-users email list for this type
 of query.

 HOW TO CONTRIBUTE TO OpenSSL
 ----------------------------

 See CONTRIBUTING

 LEGALITIES
 ----------

 A number of nations restrict the use or export of cryptography. If you
 are potentially subject to such restrictions you should seek competent
 professional legal advice before attempting to develop or distribute
 cryptographic code.