openssl/ssl/statem
Matt Caswell f8affa2995 Don't send a status_request extension in a CertificateRequest message
If a TLSv1.3 server configured to respond to the status_request extension
also attempted to send a CertificateRequest then it was incorrectly
inserting a non zero length status_request extension into that message.

The TLSv1.3 RFC does allow that extension in that message but it must
always be zero length.

In fact we should not be sending the extension at all in that message
because we don't support it.

Fixes #9767

Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
(Merged from https://github.com/openssl/openssl/pull/9780)

(cherry picked from commit debb64a0ca43969eb3f043aa8895a4faa7f12b6e)
2019-09-06 10:12:51 +01:00
..
extensions.c Add missing EBCDIC strings 2019-08-14 10:52:31 +01:00
extensions_clnt.c Don't generate an unnecessary Diffie-Hellman key in TLS 1.3 clients. 2019-07-25 16:26:06 -04:00
extensions_cust.c Update copyright year 2018-02-13 13:59:25 +00:00
extensions_srvr.c Don't send a status_request extension in a CertificateRequest message 2019-09-06 10:12:51 +01:00
README
statem.c Update copyright year 2019-02-26 14:05:09 +00:00
statem.h Tolerate encrypted or plaintext alerts 2018-08-08 10:16:58 +01:00
statem_clnt.c Defer sending a KeyUpdate until after pending writes are complete 2019-06-03 11:57:31 +01:00
statem_dtls.c Don't memcpy the contents of an empty fragment 2018-05-12 09:59:02 +01:00
statem_lib.c Add missing EBCDIC strings 2019-08-14 10:52:31 +01:00
statem_locl.h Update copyright year 2019-02-26 14:05:09 +00:00
statem_srvr.c Revert "Delay setting the sig algs until after the cert_cb has been called" 2019-06-26 12:59:04 -05:00

State Machine Design
====================

This file provides some guidance on the thinking behind the design of the
state machine code to aid future maintenance.

The state machine code replaces an older state machine present in OpenSSL
versions 1.0.2 and below. The new state machine has the following objectives:
    - Remove duplication of state code between client and server
    - Remove duplication of state code between TLS and DTLS
    - Simplify transitions and bring the logic together in a single location
      so that it is easier to validate
    - Remove duplication of code between each of the message handling functions
    - Receive a message first and then work out whether that is a valid
      transition - not the other way around (the other way causes lots of issues
      where we are expecting one type of message next but actually get something
      else)
    - Separate message flow state from handshake state (in order to better
      understand each)
      - message flow state = when to flush buffers; handling restarts in the
        event of NBIO events; handling the common flow of steps for reading a
        message and the common flow of steps for writing a message etc
      - handshake state = what handshake message are we working on now
    - Control complexity: only the state machine can change state: keep all
      the state changes local to the state machine component

The message flow state machine is divided into a reading sub-state machine and a
writing sub-state machine. See the source comments in statem.c for a more
detailed description of the various states and transitions possible.

Conceptually the state machine component is designed as follows:

                        libssl
                           |
---------------------------|-----statem.h--------------------------------------
                           |
                    _______V____________________
                   |                            |
                   |    statem.c                |
                   |                            |
                   |    Core state machine code |
                   |____________________________|
        statem_locl.h     ^          ^
                 _________|          |_______
                |                            |
   _____________|____________   _____________|____________
  |                          | |                          |
  | statem_clnt.c            | | statem_srvr.c            |
  |                          | |                          |
  | TLS/DTLS client specific | | TLS/DTLS server specific |
  | state machine code       | | state machine code       |
  |__________________________| |__________________________|
               |        |_______________|__       |
               |        ________________|  |      |
               |       |                   |      |
   ____________V_______V________   ________V______V_______________
  |                             | |                               |
  | statem_both.c               | | statem_dtls.c                 |
  |                             | |                               |
  | Non core functions common   | | Non core functions common to  |
  | to both servers and clients | | both DTLS servers and clients |
  |_____________________________| |_______________________________|