wbrawner/openssl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
openssl/crypto
History
Gunnar Kudrjavets d601b9b50c RT3823: Improve the robustness of event logging 
There are a couple of minor fixes here:

1) Handle the case when RegisterEventSource() fails (which it may for
various reasons) and do the work of logging the event only if it succeeds.

2) Handle the case when ReportEvent() fails and do our best in debug builds
to at least attempt somehow indicate that something has gone wrong. The
typical situation would be someone running tools like DbMon, DBWin32,
DebugView or just having the debugger attached. The intent is to make sure
that at least some data will be captured so that we can save hours and days
of debugging time.

3) Minor fix to change the MessageBox() flag to MB_ICONERROR. Though the
value of MB_ICONERROR is the same value as MB_ICONSTOP, the intent is
better conveyed by using MB_ICONERROR.

Testing performed:

1) Clean compilation for debug-VC-WIN32 and VC-WIN32.

2) Good test results (nmake -f ms\ntdll.mak test) for debug-VC-WIN32 and
VC-WIN32.

3) Stepped through relevant changes using WinDBG and exercised the impacted
code paths.

Signed-off-by: Rich Salz <rsalz@akamai.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(cherry picked from commit 4cd94416a4)
2015-09-21 14:36:26 -04:00
..
aes RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
asn1 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
bf RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
bio RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
bn RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
buffer RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
camellia RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
cast RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
cmac RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
cms RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
comp RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
conf RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
des RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
dh RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
dsa This undoes GH367 for non-master 2015-09-18 15:56:23 -04:00
dso RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
ec RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
ecdh RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
ecdsa RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
engine RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
err RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
evp Fix indentation 2015-09-19 09:09:14 -04:00
hmac RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
idea RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
jpake RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
krb5 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
lhash RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
md2 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
md4 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
md5 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
mdc2 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
modes RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
objects RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
ocsp RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
pem RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
perlasm Fix crash in SPARC T4 XTS. 2015-02-24 10:12:57 +01:00
pkcs7 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
pkcs12 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
pqueue RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
rand RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
rc2 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
rc4 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
rc5 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
ripemd RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
rsa RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
seed RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
sha RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
srp Fix SRP memory leaks 2015-09-21 10:23:25 +01:00
stack RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
store RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
threads Cleanup mttest.c : because we no longer use stdio here, don't include it 2015-06-21 22:12:07 +02:00
ts RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
txt_db RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
ui RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
whrlpool RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
x509 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
x509v3 RT4044: Remove .cvsignore files. 2015-09-15 11:58:27 -04:00
alphacpuid.pl Alpha assembler fixed from HEAD. 2011-08-12 12:31:08 +00:00
arm64cpuid.S Add linux-aarch64 taget. 2014-06-10 23:20:55 +02:00
arm_arch.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
armcap.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
armv4cpuid.S Remove inconsistency in ARM support. 2015-01-06 11:14:23 +01:00
constant_time_locl.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
constant_time_test.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
cpt_err.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
cryptlib.c RT3823: Improve the robustness of event logging 2015-09-21 14:36:26 -04:00
cryptlib.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
crypto-lib.com Adjust VMS build to Unix build. Most of all, make it so the disabled 2014-06-18 13:43:09 +02:00
crypto.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
cversion.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
ebcdic.c Appease clang -Wempty-translation-unit 2015-04-08 17:59:40 +02:00
ebcdic.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
ex_data.c Fix memory leak reporting. 2015-02-09 13:01:15 +00:00
fips_err.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
fips_ers.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
ia64cpuid.S IA64 assembler pack update from HEAD. 2011-11-14 20:45:57 +00:00
install-crypto.com Adjust VMS build to Unix build. Most of all, make it so the disabled 2014-06-18 13:43:09 +02:00
LPdir_nyi.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
LPdir_unix.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
LPdir_vms.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
LPdir_win.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
LPdir_win32.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
LPdir_wince.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
Makefile Fix the update target and remove duplicate file updates 2015-05-23 06:25:12 +02:00
md32_common.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
mem.c Fix CRYPTO_strdup 2015-04-22 17:20:38 +01:00
mem_clr.c Make sure OPENSSL_cleanse checks for NULL 2015-09-17 22:31:24 +01:00
mem_dbg.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
o_dir.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
o_dir.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
o_dir_test.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
o_fips.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
o_init.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
o_str.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
o_str.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
o_time.c Re-align some comments after running the reformat script. 2015-01-22 09:31:48 +00:00
o_time.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
opensslconf.h.in Make preprocessor error into real preprocessor error 2015-06-16 13:13:49 +02:00
opensslv.h Prepare for 1.0.2e-dev 2015-07-09 13:18:51 +01:00
ossl_typ.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
pariscid.pl PA-RISC assembler pack: switch to bve in 64-bit builds. 2013-06-30 23:13:23 +02:00
ppc_arch.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
ppccap.c RT3990: Fix #include path. 2015-08-05 22:06:22 -04:00
ppccpuid.pl Initial POWER8 support from development branch. 2014-07-20 14:36:49 +02:00
s390xcap.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
s390xcpuid.S s390x assembler pack update from HEAD. 2011-11-14 20:47:22 +00:00
sparc_arch.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
sparccpuid.S Conversion to UTF-8 where needed 2015-07-14 01:17:45 +02:00
sparcv9cap.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
symhacks.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
uid.c Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
vms_rms.h Run util/openssl-format-source -v -c . 2015-01-22 09:31:38 +00:00
x86_64cpuid.pl x86[_64]cpuid.pl: add low-level RDSEED. 2014-02-14 17:25:14 +01:00
x86cpuid.pl x86[_64]cpuid.pl: add low-level RDSEED. 2014-02-14 17:25:14 +01:00