e56c33b98b
The _clienthello_ in the extensions parsing functions is overly specific. Better to keep the convention to just _client_ Perl changes reviewed by Richard Levitte. Non-perl changes reviewed by Rich Salz Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
532 lines
17 KiB
C
532 lines
17 KiB
C
/*
|
|
* Copyright 2016 The OpenSSL Project Authors. All Rights Reserved.
|
|
*
|
|
* Licensed under the OpenSSL license (the "License"). You may not use
|
|
* this file except in compliance with the License. You can obtain a copy
|
|
* in the file LICENSE in the source distribution or at
|
|
* https://www.openssl.org/source/license.html
|
|
*/
|
|
|
|
#include <stdlib.h>
|
|
#include "../ssl_locl.h"
|
|
#include "statem_locl.h"
|
|
|
|
typedef struct {
|
|
/* The ID for the extension */
|
|
unsigned int type;
|
|
int (*server_parse)(SSL *s, PACKET *pkt, int *al);
|
|
int (*client_parse)(SSL *s, PACKET *pkt, int *al);
|
|
int (*server_construct)(SSL *s, WPACKET *pkt, int *al);
|
|
int (*client_construct)(SSL *s, WPACKET *pkt, int *al);
|
|
unsigned int context;
|
|
} EXTENSION_DEFINITION;
|
|
|
|
/*
|
|
* TODO(TLS1.3): Temporarily modified the definitions below to put all TLS1.3
|
|
* extensions in the ServerHello for now. That needs to be put back to correct
|
|
* setting once encrypted extensions is working properly.
|
|
*/
|
|
static const EXTENSION_DEFINITION ext_defs[] = {
|
|
{
|
|
TLSEXT_TYPE_renegotiate,
|
|
tls_parse_client_renegotiate,
|
|
NULL,
|
|
tls_construct_server_renegotiate,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO | EXT_SSL3_ALLOWED
|
|
| EXT_TLS1_2_AND_BELOW_ONLY
|
|
},
|
|
{
|
|
TLSEXT_TYPE_server_name,
|
|
tls_parse_client_server_name,
|
|
NULL,
|
|
tls_construct_server_server_name,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO
|
|
| /*EXT_TLS1_3_ENCRYPTED_EXTENSIONS*/EXT_TLS1_3_SERVER_HELLO
|
|
},
|
|
#ifndef OPENSSL_NO_SRP
|
|
{
|
|
TLSEXT_TYPE_srp,
|
|
tls_parse_client_srp,
|
|
NULL,
|
|
NULL,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO | EXT_TLS1_2_AND_BELOW_ONLY
|
|
},
|
|
#endif
|
|
#ifndef OPENSSL_NO_EC
|
|
{
|
|
TLSEXT_TYPE_ec_point_formats,
|
|
tls_parse_client_ec_pt_formats,
|
|
NULL,
|
|
tls_construct_server_ec_pt_formats,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_2_AND_BELOW_ONLY
|
|
},
|
|
{
|
|
TLSEXT_TYPE_supported_groups,
|
|
tls_parse_client_supported_groups,
|
|
NULL,
|
|
NULL /* TODO(TLS1.3): Need to add this */,
|
|
NULL,
|
|
EXT_CLIENT_HELLO
|
|
| /*EXT_TLS1_3_ENCRYPTED_EXTENSIONS*/EXT_TLS1_3_SERVER_HELLO
|
|
},
|
|
#endif
|
|
{
|
|
TLSEXT_TYPE_session_ticket,
|
|
tls_parse_client_session_ticket,
|
|
NULL,
|
|
tls_construct_server_session_ticket,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO | EXT_TLS1_2_AND_BELOW_ONLY
|
|
},
|
|
{
|
|
TLSEXT_TYPE_signature_algorithms,
|
|
tls_parse_client_sig_algs,
|
|
NULL,
|
|
NULL,
|
|
NULL,
|
|
EXT_CLIENT_HELLO
|
|
},
|
|
{
|
|
TLSEXT_TYPE_status_request,
|
|
tls_parse_client_status_request,
|
|
NULL,
|
|
tls_construct_server_status_request,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO
|
|
| /*EXT_TLS1_3_CERTIFICATE*/EXT_TLS1_3_SERVER_HELLO
|
|
},
|
|
#ifndef OPENSSL_NO_NEXTPROTONEG
|
|
{
|
|
TLSEXT_TYPE_next_proto_neg,
|
|
tls_parse_client_npn,
|
|
NULL,
|
|
tls_construct_server_next_proto_neg,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO | EXT_TLS1_2_AND_BELOW_ONLY
|
|
},
|
|
#endif
|
|
{
|
|
TLSEXT_TYPE_application_layer_protocol_negotiation,
|
|
tls_parse_client_alpn,
|
|
NULL,
|
|
tls_construct_server_alpn,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO
|
|
| /*EXT_TLS1_3_ENCRYPTED_EXTENSIONS*/EXT_TLS1_3_SERVER_HELLO
|
|
},
|
|
#ifndef OPENSSL_NO_SRTP
|
|
{
|
|
TLSEXT_TYPE_use_srtp,
|
|
tls_parse_client_use_srtp,
|
|
NULL,
|
|
tls_construct_server_use_srtp,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO
|
|
| EXT_TLS1_3_ENCRYPTED_EXTENSIONS | EXT_DTLS_ONLY
|
|
},
|
|
#endif
|
|
{
|
|
TLSEXT_TYPE_encrypt_then_mac,
|
|
tls_parse_client_etm,
|
|
NULL,
|
|
tls_construct_server_etm,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO | EXT_TLS1_2_AND_BELOW_ONLY
|
|
},
|
|
{
|
|
TLSEXT_TYPE_signed_certificate_timestamp,
|
|
/*
|
|
* No server side support for this, but can be provided by a custom
|
|
* extension. This is an exception to the rule that custom extensions
|
|
* cannot override built in ones.
|
|
*/
|
|
NULL,
|
|
NULL,
|
|
NULL,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO
|
|
| /*EXT_TLS1_3_CERTIFICATE*/EXT_TLS1_3_SERVER_HELLO
|
|
},
|
|
{
|
|
TLSEXT_TYPE_extended_master_secret,
|
|
tls_parse_client_ems,
|
|
NULL,
|
|
tls_construct_server_ems,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO | EXT_TLS1_2_AND_BELOW_ONLY
|
|
},
|
|
{
|
|
TLSEXT_TYPE_supported_versions,
|
|
/* Processed inline as part of version selection */
|
|
NULL,
|
|
NULL,
|
|
NULL,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS_IMPLEMENTATION_ONLY
|
|
},
|
|
{
|
|
TLSEXT_TYPE_padding,
|
|
/* We send this, but don't read it */
|
|
NULL,
|
|
NULL,
|
|
NULL,
|
|
NULL,
|
|
EXT_CLIENT_HELLO
|
|
},
|
|
{
|
|
TLSEXT_TYPE_key_share,
|
|
tls_parse_client_key_share,
|
|
NULL,
|
|
tls_construct_server_key_share,
|
|
NULL,
|
|
EXT_CLIENT_HELLO | EXT_TLS1_3_SERVER_HELLO
|
|
| EXT_TLS1_3_HELLO_RETRY_REQUEST | EXT_TLS_IMPLEMENTATION_ONLY
|
|
| EXT_TLS1_3_ONLY
|
|
},
|
|
{
|
|
/*
|
|
* Special unsolicited ServerHello extension only used when
|
|
* SSL_OP_CRYPTOPRO_TLSEXT_BUG is set
|
|
*/
|
|
TLSEXT_TYPE_cryptopro_bug,
|
|
NULL,
|
|
NULL,
|
|
tls_construct_server_cryptopro_bug,
|
|
NULL,
|
|
EXT_TLS1_2_SERVER_HELLO | EXT_TLS1_2_AND_BELOW_ONLY
|
|
}
|
|
};
|
|
|
|
/*
|
|
* Comparison function used in a call to qsort (see tls_collect_extensions()
|
|
* below.)
|
|
* The two arguments |p1| and |p2| are expected to be pointers to RAW_EXTENSIONs
|
|
*
|
|
* Returns:
|
|
* 1 if the type for p1 is greater than p2
|
|
* 0 if the type for p1 and p2 are the same
|
|
* -1 if the type for p1 is less than p2
|
|
*/
|
|
static int compare_extensions(const void *p1, const void *p2)
|
|
{
|
|
const RAW_EXTENSION *e1 = (const RAW_EXTENSION *)p1;
|
|
const RAW_EXTENSION *e2 = (const RAW_EXTENSION *)p2;
|
|
|
|
if (e1->type < e2->type)
|
|
return -1;
|
|
else if (e1->type > e2->type)
|
|
return 1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Verify whether we are allowed to use the extension |type| in the current
|
|
* |context|. Returns 1 to indicate the extension is allowed or unknown or 0 to
|
|
* indicate the extension is not allowed.
|
|
*/
|
|
static int verify_extension(SSL *s, unsigned int context, unsigned int type)
|
|
{
|
|
size_t i;
|
|
|
|
for (i = 0; i < OSSL_NELEM(ext_defs); i++) {
|
|
if (type == ext_defs[i].type) {
|
|
/* Check we're allowed to use this extension in this context */
|
|
if ((context & ext_defs[i].context) == 0)
|
|
return 0;
|
|
|
|
if (SSL_IS_DTLS(s)) {
|
|
if ((ext_defs[i].context & EXT_TLS_ONLY) != 0)
|
|
return 0;
|
|
} else if ((ext_defs[i].context & EXT_DTLS_ONLY) != 0) {
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
/* Unknown extension. We allow it */
|
|
return 1;
|
|
}
|
|
|
|
/*
|
|
* Finds an extension definition for the give extension |type|.
|
|
* Returns 1 if found and stores the definition in |*def|, or returns 0
|
|
* otherwise.
|
|
*/
|
|
static int find_extension_definition(SSL *s, unsigned int type,
|
|
const EXTENSION_DEFINITION **def)
|
|
{
|
|
size_t i;
|
|
|
|
for (i = 0; i < OSSL_NELEM(ext_defs); i++) {
|
|
if (type == ext_defs[i].type) {
|
|
*def = &ext_defs[i];
|
|
return 1;
|
|
}
|
|
}
|
|
|
|
/* Unknown extension */
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Gather a list of all the extensions from the data in |packet]. |context|
|
|
* tells us which message this extension is for. The raw extension data is
|
|
* stored in |*res| with the number of found extensions in |*numfound|. In the
|
|
* event of an error the alert type to use is stored in |*ad|. We don't actually
|
|
* process the content of the extensions yet, except to check their types.
|
|
*
|
|
* Per http://tools.ietf.org/html/rfc5246#section-7.4.1.4, there may not be
|
|
* more than one extension of the same type in a ClientHello or ServerHello.
|
|
* This function returns 1 if all extensions are unique and we have parsed their
|
|
* types, and 0 if the extensions contain duplicates, could not be successfully
|
|
* parsed, or an internal error occurred.
|
|
*/
|
|
/*
|
|
* TODO(TLS1.3): Refactor ServerHello extension parsing to use this and then
|
|
* remove tls1_check_duplicate_extensions()
|
|
*/
|
|
int tls_collect_extensions(SSL *s, PACKET *packet, unsigned int context,
|
|
RAW_EXTENSION **res, size_t *numfound, int *ad)
|
|
{
|
|
PACKET extensions = *packet;
|
|
size_t num_extensions = 0, i = 0;
|
|
RAW_EXTENSION *raw_extensions = NULL;
|
|
|
|
/* First pass: count the extensions. */
|
|
while (PACKET_remaining(&extensions) > 0) {
|
|
unsigned int type;
|
|
PACKET extension;
|
|
|
|
if (!PACKET_get_net_2(&extensions, &type) ||
|
|
!PACKET_get_length_prefixed_2(&extensions, &extension)) {
|
|
SSLerr(SSL_F_TLS_COLLECT_EXTENSIONS, SSL_R_BAD_EXTENSION);
|
|
*ad = SSL_AD_DECODE_ERROR;
|
|
goto err;
|
|
}
|
|
/* Verify this extension is allowed */
|
|
if (!verify_extension(s, context, type)) {
|
|
SSLerr(SSL_F_TLS_COLLECT_EXTENSIONS, SSL_R_BAD_EXTENSION);
|
|
*ad = SSL_AD_ILLEGAL_PARAMETER;
|
|
goto err;
|
|
}
|
|
num_extensions++;
|
|
}
|
|
|
|
if (num_extensions > 0) {
|
|
raw_extensions = OPENSSL_zalloc(sizeof(*raw_extensions)
|
|
* num_extensions);
|
|
if (raw_extensions == NULL) {
|
|
*ad = SSL_AD_INTERNAL_ERROR;
|
|
SSLerr(SSL_F_TLS_COLLECT_EXTENSIONS, ERR_R_MALLOC_FAILURE);
|
|
goto err;
|
|
}
|
|
|
|
/* Second pass: collect the extensions. */
|
|
for (i = 0; i < num_extensions; i++) {
|
|
if (!PACKET_get_net_2(packet, &raw_extensions[i].type) ||
|
|
!PACKET_get_length_prefixed_2(packet,
|
|
&raw_extensions[i].data)) {
|
|
/* This should not happen. */
|
|
*ad = SSL_AD_INTERNAL_ERROR;
|
|
SSLerr(SSL_F_TLS_COLLECT_EXTENSIONS, ERR_R_INTERNAL_ERROR);
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
if (PACKET_remaining(packet) != 0) {
|
|
*ad = SSL_AD_DECODE_ERROR;
|
|
SSLerr(SSL_F_TLS_COLLECT_EXTENSIONS, SSL_R_LENGTH_MISMATCH);
|
|
goto err;
|
|
}
|
|
/* Sort the extensions and make sure there are no duplicates. */
|
|
qsort(raw_extensions, num_extensions, sizeof(*raw_extensions),
|
|
compare_extensions);
|
|
for (i = 1; i < num_extensions; i++) {
|
|
if (raw_extensions[i - 1].type == raw_extensions[i].type) {
|
|
*ad = SSL_AD_DECODE_ERROR;
|
|
goto err;
|
|
}
|
|
}
|
|
}
|
|
|
|
*res = raw_extensions;
|
|
*numfound = num_extensions;
|
|
return 1;
|
|
|
|
err:
|
|
OPENSSL_free(raw_extensions);
|
|
return 0;
|
|
}
|
|
|
|
int tls_parse_all_extensions(SSL *s, int context, RAW_EXTENSION *exts,
|
|
size_t numexts, int *al)
|
|
{
|
|
size_t loop;
|
|
|
|
for (loop = 0; loop < numexts; loop++) {
|
|
RAW_EXTENSION *currext = &exts[loop];
|
|
const EXTENSION_DEFINITION *extdef = NULL;
|
|
int (*parser)(SSL *s, PACKET *pkt, int *al) = NULL;
|
|
|
|
if (s->tlsext_debug_cb)
|
|
s->tlsext_debug_cb(s, 0, currext->type,
|
|
PACKET_data(&currext->data),
|
|
PACKET_remaining(&currext->data),
|
|
s->tlsext_debug_arg);
|
|
|
|
/* Skip if we've already parsed this extension */
|
|
if (currext->parsed)
|
|
continue;
|
|
|
|
currext->parsed = 1;
|
|
|
|
parser = NULL;
|
|
if (find_extension_definition(s, currext->type, &extdef)) {
|
|
parser = s->server ? extdef->server_parse : extdef->client_parse;
|
|
|
|
/* Check if extension is defined for our protocol. If not, skip */
|
|
if ((SSL_IS_DTLS(s)
|
|
&& (extdef->context & EXT_TLS_IMPLEMENTATION_ONLY) != 0)
|
|
|| (s->version == SSL3_VERSION
|
|
&& (extdef->context & EXT_SSL3_ALLOWED) == 0)
|
|
|| (SSL_IS_TLS13(s)
|
|
&& (extdef->context & EXT_TLS1_2_AND_BELOW_ONLY) != 0)
|
|
|| (!SSL_IS_TLS13(s)
|
|
&& (extdef->context & EXT_TLS1_3_ONLY) != 0))
|
|
continue;
|
|
}
|
|
|
|
if (parser == NULL) {
|
|
/*
|
|
* Could be a custom extension. We only allow this if it is a non
|
|
* resumed session on the server side.
|
|
*
|
|
* TODO(TLS1.3): We only allow old style <=TLS1.2 custom extensions.
|
|
* We're going to need a new mechanism for TLS1.3 to specify which
|
|
* messages to add the custom extensions to.
|
|
*/
|
|
if ((!s->hit || !s->server)
|
|
&& (context
|
|
& (EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO)) != 0
|
|
&& custom_ext_parse(s, s->server, currext->type,
|
|
PACKET_data(&currext->data),
|
|
PACKET_remaining(&currext->data),
|
|
al) <= 0)
|
|
return 0;
|
|
|
|
continue;
|
|
}
|
|
|
|
if (!parser(s, &currext->data, al))
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
/*
|
|
* Find a specific extension by |type| in the list |exts| containing |numexts|
|
|
* extensions, and the parse it immediately. Returns 1 on success, or 0 on
|
|
* failure. If a failure has occurred then |*al| will also be set to the alert
|
|
* to be sent.
|
|
*/
|
|
int tls_parse_extension(SSL *s, int type, int context, RAW_EXTENSION *exts,
|
|
size_t numexts, int *al)
|
|
{
|
|
RAW_EXTENSION *ext = tls_get_extension_by_type(exts, numexts, type);
|
|
|
|
if (ext == NULL)
|
|
return 1;
|
|
|
|
return tls_parse_all_extensions(s, context, ext, 1, al);
|
|
}
|
|
|
|
int tls_construct_extensions(SSL *s, WPACKET *pkt, unsigned int context,
|
|
int *al)
|
|
{
|
|
size_t loop;
|
|
int addcustom = 0;
|
|
|
|
/*
|
|
* Normally if something goes wrong during construction its an internal
|
|
* error. We can always override this later.
|
|
*/
|
|
*al = SSL_AD_INTERNAL_ERROR;
|
|
|
|
if (!WPACKET_start_sub_packet_u16(pkt)
|
|
/*
|
|
* If extensions are of zero length then we don't even add the
|
|
* extensions length bytes to a ClientHello/ServerHello in SSLv3
|
|
*/
|
|
|| ((context & (EXT_CLIENT_HELLO | EXT_TLS1_2_SERVER_HELLO)) != 0
|
|
&& s->version == SSL3_VERSION
|
|
&& !WPACKET_set_flags(pkt,
|
|
WPACKET_FLAGS_ABANDON_ON_ZERO_LENGTH))) {
|
|
SSLerr(SSL_F_TLS_CONSTRUCT_EXTENSIONS, ERR_R_INTERNAL_ERROR);
|
|
return 0;
|
|
}
|
|
|
|
for (loop = 0; loop < OSSL_NELEM(ext_defs); loop++) {
|
|
int (*construct)(SSL *s, WPACKET *pkt, int *al);
|
|
|
|
/* Skip if not relevant for our context */
|
|
if ((ext_defs[loop].context & context) == 0)
|
|
continue;
|
|
|
|
construct = s->server ? ext_defs[loop].server_construct
|
|
: ext_defs[loop].client_construct;
|
|
|
|
/* Check if this extension is defined for our protocol. If not, skip */
|
|
if ((SSL_IS_DTLS(s)
|
|
&& (ext_defs[loop].context & EXT_TLS_IMPLEMENTATION_ONLY)
|
|
!= 0)
|
|
|| (s->version == SSL3_VERSION
|
|
&& (ext_defs[loop].context & EXT_SSL3_ALLOWED) == 0)
|
|
|| (SSL_IS_TLS13(s)
|
|
&& (ext_defs[loop].context & EXT_TLS1_2_AND_BELOW_ONLY)
|
|
!= 0)
|
|
|| (!SSL_IS_TLS13(s)
|
|
&& (ext_defs[loop].context & EXT_TLS1_3_ONLY) != 0
|
|
&& (context & EXT_CLIENT_HELLO) == 0)
|
|
|| construct == NULL)
|
|
continue;
|
|
|
|
if (!construct(s, pkt, al))
|
|
return 0;
|
|
}
|
|
|
|
/* Add custom extensions */
|
|
if ((context & EXT_CLIENT_HELLO) != 0) {
|
|
custom_ext_init(&s->cert->cli_ext);
|
|
addcustom = 1;
|
|
} else if ((context & EXT_TLS1_2_SERVER_HELLO) != 0) {
|
|
/*
|
|
* We already initialised the custom extensions during ClientHello
|
|
* parsing.
|
|
*
|
|
* TODO(TLS1.3): We're going to need a new custom extension mechanism
|
|
* for TLS1.3, so that custom extensions can specify which of the
|
|
* multiple message they wish to add themselves to.
|
|
*/
|
|
addcustom = 1;
|
|
}
|
|
|
|
if (addcustom && !custom_ext_add(s, s->server, pkt, al)) {
|
|
SSLerr(SSL_F_TLS_CONSTRUCT_EXTENSIONS, ERR_R_INTERNAL_ERROR);
|
|
return 0;
|
|
}
|
|
|
|
if (!WPACKET_close(pkt)) {
|
|
SSLerr(SSL_F_TLS_CONSTRUCT_EXTENSIONS, ERR_R_INTERNAL_ERROR);
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|