TLS/SSL and crypto library
Find a file
Matt Caswell e9cd6e763c Fix SSL_get_servername() and SNI behaviour
The SNI behaviour for TLSv1.3 and the behaviour of SSL_get_servername()
was not quite right, and not entirely consistent with the RFC.

The TLSv1.3 RFC explicitly says that SNI is negotiated on each handshake
and the server is not required to associate it with the session. This was
not quite reflected in the code so we fix that.

Additionally there were some additional checks around early_data checking
that the SNI between the original session and this session were
consistent. In fact the RFC does not require any such checks, so they are
removed.

Finally the behaviour of SSL_get_servername() was not quite right. The
behaviour was not consistent between resumption and normal handshakes,
and also not quite consistent with historical behaviour. We clarify the
behaviour in various scenarios and also attempt to make it match historical
behaviour as closely as possible.

Fixes #8822

Reviewed-by: Ben Kaduk <kaduk@mit.edu>
(Merged from https://github.com/openssl/openssl/pull/10018)

(cherry picked from commit 7955c1f16e72dc944677fd1dbf4b1300e75f1c84)
2020-01-30 16:07:12 +00:00
.github Remind people to have 'Fixes #XXXX' in the commit message 2017-04-02 21:51:47 +02:00
apps Replace apps/server.pem with certificate with a sha256 signature. 2020-01-25 14:12:07 +01:00
boringssl@2070f8ad91 Update ossl_config.json for later BoringSSL commit 2017-03-14 12:12:13 +00:00
Configurations Fix some typos 2019-12-11 19:17:00 +01:00
crypto Remove remaining references to crypto/include 2020-01-21 14:18:53 +01:00
demos Update copyright year 2019-09-10 13:56:40 +01:00
doc Fix type name typo in d2i/i2d documentation. 2020-01-30 16:17:03 +10:00
engines Fix header file include guard names 2019-09-27 23:58:12 +02:00
external/perl Update copyright year 2018-09-11 13:45:17 +01:00
fuzz Fix GOST OID 2019-05-24 12:36:06 +03:00
include Run make update 2020-01-02 14:45:04 +00:00
krb5@890ca2f401 Update the krb5 submodule 2019-12-29 13:08:55 +01:00
ms Update copyright year 2019-02-26 14:05:09 +00:00
os-dep Move Haiku configuration to separate config file to denote 2016-05-19 22:39:52 +02:00
pyca-cryptography@09403100de Update the pyca-cryptography submodule 2018-09-10 12:04:03 +01:00
ssl Fix SSL_get_servername() and SNI behaviour 2020-01-30 16:07:12 +00:00
test Check that the default signature type is allowed 2020-01-25 14:12:10 +01:00
tools Update copyright year 2018-03-20 13:08:46 +00:00
util OpenSSL::Test: bring back the relative paths 2020-01-27 08:51:11 +01:00
VMS Simplify the handling of shared library version numbers 2017-07-26 22:53:03 +02:00
.gitattributes Don't export the submodules 'boringssl', 'krb5' and 'pyca-cryptography' 2018-11-24 18:43:54 +01:00
.gitignore Reorganize private crypto header files 2019-09-27 23:57:58 +02:00
.gitmodules [extended tests] Enable krb5 tests in Travis 2017-04-18 19:10:25 +02:00
.travis-apt-pin.preferences Fix travis clang-3.9 builds 2017-06-23 17:57:02 +01:00
.travis-create-release.sh Remove all 'make dist' artifacts 2018-11-23 12:42:21 +01:00
.travis.yml Temporarily disable external pyca tests 2019-12-29 13:24:04 +01:00
ACKNOWLEDGEMENTS Refer to website for acknowledgements. 2015-12-08 16:07:09 -05:00
appveyor.yml Configure: Make --strict-warnings meaningful with MSVC cl 2019-11-05 22:51:12 +01:00
AUTHORS Update AUTHORS list, add commentary 2018-07-08 20:32:04 -04:00
build.info Reorganize private crypto header files 2019-09-27 23:57:58 +02:00
CHANGES Fix documentation of return value for EVP_Digest{Sign,Verify}Init() 2020-01-15 01:21:10 +01:00
config iOS build: Replace %20 with space in config script 2019-07-08 10:57:30 +02:00
config.com Update copyright year 2018-02-13 13:59:25 +00:00
Configure Configure: use $list_separator_re only for defines and includes 2020-01-13 09:04:19 +01:00
CONTRIBUTING Remove unnecessary trailing whitespace 2019-02-05 16:29:17 +01:00
e_os.h Revert "Move random-related defines from e_os.h to rand_unix.c" 2020-01-07 16:31:21 +01:00
FAQ Move FAQ to the web. 2015-08-16 19:02:29 -04:00
INSTALL Fix some typos 2019-12-11 19:17:00 +01:00
LICENSE Update copyright year 2019-02-26 14:05:09 +00:00
NEWS Prepare for 1.1.1e-dev 2019-09-10 14:14:31 +01:00
NOTES.ANDROID Remove spurious space from file. 2019-12-05 07:26:54 +10:00
NOTES.DJGPP Remove unnecessary trailing whitespace 2019-02-05 16:29:17 +01:00
NOTES.PERL Fix typo in NOTES.PERL 2019-05-16 11:47:53 +10:00
NOTES.UNIX NOTES.UNIX: add "Linking your application" paragraph 2018-06-26 12:28:06 +02:00
NOTES.VMS Remove unnecessary trailing whitespace 2019-02-05 16:29:17 +01:00
NOTES.WIN Fix default installation paths on mingw 2019-07-25 13:08:46 +02:00
README Prepare for 1.1.1e-dev 2019-09-10 14:14:31 +01:00
README.ENGINE Remove bsd_cryptodev engine 2017-06-19 09:31:45 -04:00
README.FIPS Remove more (rest?) of FIPS build stuff. 2016-01-06 12:07:26 -05:00

 OpenSSL 1.1.1e-dev

 Copyright (c) 1998-2019 The OpenSSL Project
 Copyright (c) 1995-1998 Eric A. Young, Tim J. Hudson
 All rights reserved.

 DESCRIPTION
 -----------

 The OpenSSL Project is a collaborative effort to develop a robust,
 commercial-grade, fully featured, and Open Source toolkit implementing the
 Transport Layer Security (TLS) protocols (including SSLv3) as well as a
 full-strength general purpose cryptographic library.

 OpenSSL is descended from the SSLeay library developed by Eric A. Young
 and Tim J. Hudson.  The OpenSSL toolkit is licensed under a dual-license (the
 OpenSSL license plus the SSLeay license), which means that you are free to
 get and use it for commercial and non-commercial purposes as long as you
 fulfill the conditions of both licenses.

 OVERVIEW
 --------

 The OpenSSL toolkit includes:

 libssl (with platform specific naming):
     Provides the client and server-side implementations for SSLv3 and TLS.

 libcrypto (with platform specific naming):
     Provides general cryptographic and X.509 support needed by SSL/TLS but
     not logically part of it.

 openssl:
     A command line tool that can be used for:
        Creation of key parameters
        Creation of X.509 certificates, CSRs and CRLs
        Calculation of message digests
        Encryption and decryption
        SSL/TLS client and server tests
        Handling of S/MIME signed or encrypted mail
        And more...

 INSTALLATION
 ------------

 See the appropriate file:
        INSTALL         Linux, Unix, Windows, OpenVMS, ...
        NOTES.*         INSTALL addendums for different platforms

 SUPPORT
 -------

 See the OpenSSL website www.openssl.org for details on how to obtain
 commercial technical support. Free community support is available through the
 openssl-users email list (see
 https://www.openssl.org/community/mailinglists.html for further details).

 If you have any problems with OpenSSL then please take the following steps
 first:

    - Download the latest version from the repository
      to see if the problem has already been addressed
    - Configure with no-asm
    - Remove compiler optimization flags

 If you wish to report a bug then please include the following information
 and create an issue on GitHub:

    - OpenSSL version: output of 'openssl version -a'
    - Configuration data: output of 'perl configdata.pm --dump'
    - OS Name, Version, Hardware platform
    - Compiler Details (name, version)
    - Application Details (name, version)
    - Problem Description (steps that will reproduce the problem, if known)
    - Stack Traceback (if the application dumps core)

 Just because something doesn't work the way you expect does not mean it
 is necessarily a bug in OpenSSL. Use the openssl-users email list for this type
 of query.

 HOW TO CONTRIBUTE TO OpenSSL
 ----------------------------

 See CONTRIBUTING

 LEGALITIES
 ----------

 A number of nations restrict the use or export of cryptography. If you
 are potentially subject to such restrictions you should seek competent
 professional legal advice before attempting to develop or distribute
 cryptographic code.