2013-08-17 09:16:48 +00:00
|
|
|
<?php
|
|
|
|
/**
|
|
|
|
* Copyright (c) 2013 Thomas Tanghus (thomas@tanghus.net)
|
|
|
|
* This file is licensed under the Affero General Public License version 3 or
|
|
|
|
* later.
|
|
|
|
* See the COPYING-README file.
|
|
|
|
*/
|
|
|
|
|
|
|
|
namespace OC\AppFramework\Http;
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
use OCP\Security\ISecureRandom;
|
2013-08-17 09:16:48 +00:00
|
|
|
|
2014-11-10 22:30:38 +00:00
|
|
|
class RequestTest extends \Test\TestCase {
|
2015-02-09 10:41:48 +00:00
|
|
|
/** @var string */
|
|
|
|
protected $stream = 'fakeinput://data';
|
|
|
|
/** @var ISecureRandom */
|
|
|
|
protected $secureRandom;
|
2014-11-10 22:30:38 +00:00
|
|
|
|
|
|
|
protected function setUp() {
|
|
|
|
parent::setUp();
|
2013-08-17 09:16:48 +00:00
|
|
|
|
2013-10-02 20:13:40 +00:00
|
|
|
require_once __DIR__ . '/requeststream.php';
|
|
|
|
if (in_array('fakeinput', stream_get_wrappers())) {
|
|
|
|
stream_wrapper_unregister('fakeinput');
|
|
|
|
}
|
|
|
|
stream_wrapper_register('fakeinput', 'RequestStream');
|
2015-02-09 10:41:48 +00:00
|
|
|
|
|
|
|
$this->secureRandom = $this->getMockBuilder('\OCP\Security\ISecureRandom')->getMock();
|
2013-10-02 20:13:40 +00:00
|
|
|
}
|
|
|
|
|
2014-11-10 22:30:38 +00:00
|
|
|
protected function tearDown() {
|
2013-10-02 20:13:40 +00:00
|
|
|
stream_wrapper_unregister('fakeinput');
|
2014-11-10 22:30:38 +00:00
|
|
|
parent::tearDown();
|
2013-10-02 20:13:40 +00:00
|
|
|
}
|
|
|
|
|
2013-08-17 09:16:48 +00:00
|
|
|
public function testRequestAccessors() {
|
|
|
|
$vars = array(
|
|
|
|
'get' => array('name' => 'John Q. Public', 'nickname' => 'Joey'),
|
2013-09-27 12:36:19 +00:00
|
|
|
'method' => 'GET',
|
2013-08-17 09:16:48 +00:00
|
|
|
);
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
2013-08-17 09:16:48 +00:00
|
|
|
|
|
|
|
// Countable
|
|
|
|
$this->assertEquals(2, count($request));
|
|
|
|
// Array access
|
|
|
|
$this->assertEquals('Joey', $request['nickname']);
|
|
|
|
// "Magic" accessors
|
|
|
|
$this->assertEquals('Joey', $request->{'nickname'});
|
|
|
|
$this->assertTrue(isset($request['nickname']));
|
|
|
|
$this->assertTrue(isset($request->{'nickname'}));
|
|
|
|
$this->assertEquals(false, isset($request->{'flickname'}));
|
|
|
|
// Only testing 'get', but same approach for post, files etc.
|
|
|
|
$this->assertEquals('Joey', $request->get['nickname']);
|
|
|
|
// Always returns null if variable not set.
|
|
|
|
$this->assertEquals(null, $request->{'flickname'});
|
2013-09-27 23:35:24 +00:00
|
|
|
|
2013-08-17 09:16:48 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// urlParams has precedence over POST which has precedence over GET
|
|
|
|
public function testPrecedence() {
|
|
|
|
$vars = array(
|
|
|
|
'get' => array('name' => 'John Q. Public', 'nickname' => 'Joey'),
|
|
|
|
'post' => array('name' => 'Jane Doe', 'nickname' => 'Janey'),
|
|
|
|
'urlParams' => array('user' => 'jw', 'name' => 'Johnny Weissmüller'),
|
2014-04-12 14:17:49 +00:00
|
|
|
'method' => 'GET'
|
2013-08-17 09:16:48 +00:00
|
|
|
);
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
2013-08-17 09:16:48 +00:00
|
|
|
|
|
|
|
$this->assertEquals(3, count($request));
|
|
|
|
$this->assertEquals('Janey', $request->{'nickname'});
|
|
|
|
$this->assertEquals('Johnny Weissmüller', $request->{'name'});
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @expectedException RuntimeException
|
|
|
|
*/
|
|
|
|
public function testImmutableArrayAccess() {
|
|
|
|
$vars = array(
|
|
|
|
'get' => array('name' => 'John Q. Public', 'nickname' => 'Joey'),
|
2014-04-12 14:17:49 +00:00
|
|
|
'method' => 'GET'
|
2013-08-17 09:16:48 +00:00
|
|
|
);
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
2013-08-17 09:16:48 +00:00
|
|
|
$request['nickname'] = 'Janey';
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @expectedException RuntimeException
|
|
|
|
*/
|
|
|
|
public function testImmutableMagicAccess() {
|
|
|
|
$vars = array(
|
|
|
|
'get' => array('name' => 'John Q. Public', 'nickname' => 'Joey'),
|
2014-04-12 14:17:49 +00:00
|
|
|
'method' => 'GET'
|
2013-08-17 09:16:48 +00:00
|
|
|
);
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
2013-08-17 09:16:48 +00:00
|
|
|
$request->{'nickname'} = 'Janey';
|
|
|
|
}
|
|
|
|
|
2013-09-27 12:36:19 +00:00
|
|
|
/**
|
2013-09-27 23:35:24 +00:00
|
|
|
* @expectedException LogicException
|
2013-09-27 12:36:19 +00:00
|
|
|
*/
|
|
|
|
public function testGetTheMethodRight() {
|
|
|
|
$vars = array(
|
|
|
|
'get' => array('name' => 'John Q. Public', 'nickname' => 'Joey'),
|
|
|
|
'method' => 'GET',
|
|
|
|
);
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
2013-09-27 12:36:19 +00:00
|
|
|
$result = $request->post;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testTheMethodIsRight() {
|
|
|
|
$vars = array(
|
|
|
|
'get' => array('name' => 'John Q. Public', 'nickname' => 'Joey'),
|
|
|
|
'method' => 'GET',
|
|
|
|
);
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
2013-09-27 12:36:19 +00:00
|
|
|
$this->assertEquals('GET', $request->method);
|
|
|
|
$result = $request->get;
|
|
|
|
$this->assertEquals('John Q. Public', $result['name']);
|
|
|
|
$this->assertEquals('Joey', $result['nickname']);
|
|
|
|
}
|
|
|
|
|
2013-09-27 23:35:24 +00:00
|
|
|
public function testJsonPost() {
|
2013-10-03 01:56:37 +00:00
|
|
|
global $data;
|
|
|
|
$data = '{"name": "John Q. Public", "nickname": "Joey"}';
|
2013-09-27 23:35:24 +00:00
|
|
|
$vars = array(
|
|
|
|
'method' => 'POST',
|
2014-04-12 14:17:49 +00:00
|
|
|
'server' => array('CONTENT_TYPE' => 'application/json; utf-8')
|
2013-09-27 23:35:24 +00:00
|
|
|
);
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
2013-09-27 23:35:24 +00:00
|
|
|
$this->assertEquals('POST', $request->method);
|
|
|
|
$result = $request->post;
|
|
|
|
$this->assertEquals('John Q. Public', $result['name']);
|
|
|
|
$this->assertEquals('Joey', $result['nickname']);
|
2013-09-30 14:23:43 +00:00
|
|
|
$this->assertEquals('Joey', $request->params['nickname']);
|
|
|
|
$this->assertEquals('Joey', $request['nickname']);
|
2013-09-27 23:35:24 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
public function testPatch() {
|
|
|
|
global $data;
|
|
|
|
$data = http_build_query(array('name' => 'John Q. Public', 'nickname' => 'Joey'), '', '&');
|
|
|
|
|
|
|
|
$vars = array(
|
|
|
|
'method' => 'PATCH',
|
|
|
|
'server' => array('CONTENT_TYPE' => 'application/x-www-form-urlencoded'),
|
|
|
|
);
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
2013-09-27 23:35:24 +00:00
|
|
|
|
|
|
|
$this->assertEquals('PATCH', $request->method);
|
|
|
|
$result = $request->patch;
|
|
|
|
|
|
|
|
$this->assertEquals('John Q. Public', $result['name']);
|
|
|
|
$this->assertEquals('Joey', $result['nickname']);
|
|
|
|
}
|
|
|
|
|
2013-10-02 20:13:40 +00:00
|
|
|
public function testJsonPatchAndPut() {
|
2013-09-27 23:35:24 +00:00
|
|
|
global $data;
|
|
|
|
|
2013-10-02 20:13:40 +00:00
|
|
|
// PUT content
|
|
|
|
$data = '{"name": "John Q. Public", "nickname": "Joey"}';
|
|
|
|
$vars = array(
|
|
|
|
'method' => 'PUT',
|
|
|
|
'server' => array('CONTENT_TYPE' => 'application/json; utf-8'),
|
|
|
|
);
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
2013-10-02 20:13:40 +00:00
|
|
|
|
|
|
|
$this->assertEquals('PUT', $request->method);
|
|
|
|
$result = $request->put;
|
|
|
|
|
|
|
|
$this->assertEquals('John Q. Public', $result['name']);
|
|
|
|
$this->assertEquals('Joey', $result['nickname']);
|
2013-09-27 23:35:24 +00:00
|
|
|
|
2013-10-02 20:13:40 +00:00
|
|
|
// PATCH content
|
|
|
|
$data = '{"name": "John Q. Public", "nickname": null}';
|
2013-09-27 23:35:24 +00:00
|
|
|
$vars = array(
|
|
|
|
'method' => 'PATCH',
|
|
|
|
'server' => array('CONTENT_TYPE' => 'application/json; utf-8'),
|
|
|
|
);
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
2013-09-27 23:35:24 +00:00
|
|
|
|
|
|
|
$this->assertEquals('PATCH', $request->method);
|
|
|
|
$result = $request->patch;
|
|
|
|
|
|
|
|
$this->assertEquals('John Q. Public', $result['name']);
|
|
|
|
$this->assertEquals(null, $result['nickname']);
|
|
|
|
}
|
|
|
|
|
2013-10-02 20:13:40 +00:00
|
|
|
public function testPutStream() {
|
2013-09-27 23:35:24 +00:00
|
|
|
global $data;
|
|
|
|
$data = file_get_contents(__DIR__ . '/../../../data/testimage.png');
|
|
|
|
|
|
|
|
$vars = array(
|
|
|
|
'put' => $data,
|
|
|
|
'method' => 'PUT',
|
|
|
|
'server' => array('CONTENT_TYPE' => 'image/png'),
|
|
|
|
);
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
2013-09-27 23:35:24 +00:00
|
|
|
$this->assertEquals('PUT', $request->method);
|
|
|
|
$resource = $request->put;
|
|
|
|
$contents = stream_get_contents($resource);
|
|
|
|
$this->assertEquals($data, $contents);
|
|
|
|
|
|
|
|
try {
|
|
|
|
$resource = $request->put;
|
|
|
|
} catch(\LogicException $e) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
$this->fail('Expected LogicException.');
|
|
|
|
|
|
|
|
}
|
2015-01-15 13:19:56 +00:00
|
|
|
|
|
|
|
|
|
|
|
public function testSetUrlParameters() {
|
|
|
|
$vars = array(
|
|
|
|
'post' => array(),
|
|
|
|
'method' => 'POST',
|
|
|
|
'urlParams' => array('id' => '2'),
|
|
|
|
);
|
|
|
|
|
2015-02-09 10:41:48 +00:00
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
2015-01-15 13:19:56 +00:00
|
|
|
|
|
|
|
$newParams = array('id' => '3', 'test' => 'test2');
|
|
|
|
$request->setUrlParameters($newParams);
|
|
|
|
$this->assertEquals('test2', $request->getParam('test'));
|
|
|
|
$this->assertEquals('3', $request->getParam('id'));
|
|
|
|
$this->assertEquals('3', $request->getParams()['id']);
|
|
|
|
}
|
2015-02-09 10:41:48 +00:00
|
|
|
|
|
|
|
public function testGetIdWithModUnique() {
|
|
|
|
$vars = [
|
|
|
|
'server' => [
|
|
|
|
'UNIQUE_ID' => 'GeneratedUniqueIdByModUnique'
|
|
|
|
],
|
|
|
|
];
|
|
|
|
|
|
|
|
$request = new Request($vars, $this->secureRandom, $this->stream);
|
|
|
|
$this->assertSame('GeneratedUniqueIdByModUnique', $request->getId());
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testGetIdWithoutModUnique() {
|
|
|
|
$lowRandomSource = $this->getMockBuilder('\OCP\Security\ISecureRandom')
|
|
|
|
->disableOriginalConstructor()->getMock();
|
|
|
|
$lowRandomSource->expects($this->once())
|
|
|
|
->method('generate')
|
|
|
|
->with('20')
|
|
|
|
->will($this->returnValue('GeneratedByOwnCloudItself'));
|
|
|
|
|
|
|
|
$this->secureRandom
|
|
|
|
->expects($this->once())
|
|
|
|
->method('getLowStrengthGenerator')
|
|
|
|
->will($this->returnValue($lowRandomSource));
|
|
|
|
|
|
|
|
$request = new Request([], $this->secureRandom, $this->stream);
|
|
|
|
$this->assertSame('GeneratedByOwnCloudItself', $request->getId());
|
|
|
|
}
|
|
|
|
|
|
|
|
public function testGetIdWithoutModUniqueStable() {
|
|
|
|
$request = new Request([], \OC::$server->getSecureRandom(), $this->stream);
|
|
|
|
$firstId = $request->getId();
|
|
|
|
$secondId = $request->getId();
|
|
|
|
$this->assertSame($firstId, $secondId);
|
|
|
|
}
|
2013-08-17 09:16:48 +00:00
|
|
|
}
|